Comments (5)
@marcus-j-davies , do you want me to take a shot at it, or do you want to do it?
from zwavejs.net.
Ooof!
possible of course, but will need some (quite a bit) of re-work - and thought
From the top of my head
- The Controller class to have an internal
Driver
reference be set tothis
within the following code block
Example
Controller C = JO.SelectToken("result.state.controller").ToObject<Controller>();
C._Driver = this
-
Any reference inside the controller to
Driver.Instance
be pointed at it -
Each ZWaveNode/Endpoint class will also need a reference (somehow) - They are instanciated directly from the init JSON presently (we could use the Node collection somehow)
-
Various static properties on the driver class to be made instance only.
- SchemaVersionID
- ServerCommunicationPort
- ServerErrorThrottleTime
These are used (I think) during Driver class instance creation, so will need to be optional params on the ctor's
-
Various static properties in the
server
class be made instance only- this includes static methods
This means having a separate
Server
class instance for eachDriver
instance
There is a lot that surrounds the static approach presently, unless I'm over thinking it π€
from zwavejs.net.
Hi @spudwebb
I am not one to reject free labour! π
Please by all means have a crack at it! π
Thanks
from zwavejs.net.
Is this still open or resolved? I see the latest available is '22 still (from Visual Studio NuGet)
from zwavejs.net.
Hi, this issue is still open, as v4 has not yet been published.
itβs fixed in the v4 branch.
See the PR : #31
from zwavejs.net.
Related Issues (16)
- [Feat] SmartStart support + Wider support for frameworks HOT 11
- Logging config not settable HOT 3
- Ensure security keys are present, for Smart Start and Secure inclusions
- Handle unexpected WS disconnects better (i.e handle them π¬ )
- Access to homeID HOT 2
- ccSpecific in ValueMetadata HOT 2
- No error or exception when websocket client fails to connect in client mode HOT 8
- Driver.Destroy() throws an exception if Driver.Controller is not initialized HOT 3
- Controller Node is filtered out of the Nodes collection HOT 2
- Event handlers block processing of new events HOT 2
- Can't create a second Driver after destroying the first one HOT 10
- VirtualNode.GetDefinedValueIDs() throws a null reference exception (4.0.0 branch) HOT 2
- Method calls for asleep nodes never return HOT 3
- RefreshValues does not return any error when node is dead. HOT 6
- Stack overflow exception in Websocket.Client library HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zwavejs.net.