Giter VIP home page Giter VIP logo

Comments (5)

spudwebb avatar spudwebb commented on June 9, 2024 1

@marcus-j-davies , do you want me to take a shot at it, or do you want to do it?

from zwavejs.net.

marcus-j-davies avatar marcus-j-davies commented on June 9, 2024

Ooof!

possible of course, but will need some (quite a bit) of re-work - and thought

From the top of my head

Example

Controller C = JO.SelectToken("result.state.controller").ToObject<Controller>();
C._Driver = this
  • Any reference inside the controller to Driver.Instance be pointed at it

  • Each ZWaveNode/Endpoint class will also need a reference (somehow) - They are instanciated directly from the init JSON presently (we could use the Node collection somehow)

  • Various static properties on the driver class to be made instance only.

    • SchemaVersionID
    • ServerCommunicationPort
    • ServerErrorThrottleTime

    These are used (I think) during Driver class instance creation, so will need to be optional params on the ctor's

  • Various static properties in the server class be made instance only

    • this includes static methods

    This means having a separate Server class instance for each Driver instance

There is a lot that surrounds the static approach presently, unless I'm over thinking it πŸ€”

from zwavejs.net.

marcus-j-davies avatar marcus-j-davies commented on June 9, 2024

Hi @spudwebb

I am not one to reject free labour! πŸ˜‰
Please by all means have a crack at it! πŸ‘

Thanks

from zwavejs.net.

officialh1 avatar officialh1 commented on June 9, 2024

Is this still open or resolved? I see the latest available is '22 still (from Visual Studio NuGet)

from zwavejs.net.

marcus-j-davies avatar marcus-j-davies commented on June 9, 2024

Hi, this issue is still open, as v4 has not yet been published.

it’s fixed in the v4 branch.
See the PR : #31

from zwavejs.net.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.