When switching to bright theme, code highlighting seems to be in trouble about hugo-theme-zzo HOT 23 CLOSED

set the params to "default" and it will be fixed.

When we set the chroma_theme to something, only one chroma theme can be set.

As you can see in this picture, only the default theme could have 5 different chroma themes.
After you set the chroma_theme param, you should restart hugo

from hugo-theme-zzo.

Oh, I see. Something is wrong. This was not used to happen before. Maybe after some updates, I mistakenly changed something.

from hugo-theme-zzo.

@fandean Did you set in the data/skin.toml file, chroma_theme = "default?

from hugo-theme-zzo.

I set

custom_theme_primary_color = "90"
chroma_theme = "monokai"

from hugo-theme-zzo.

We can solve this problem by setting chroma for each of the themes.

from hugo-theme-zzo.

@fandean I divided chroma_theme param to separate 5 params

...
theme_light_chroma = "default"
theme_dark_chroma = "default"
theme_hacker_chroma = "default"
theme_solarized_chroma = "default"
theme_custom_chroma = "default"

You can override this file at your root/data/skin.toml

from hugo-theme-zzo.

Ah, how to say, and I expect the effect is not the same 😁

from hugo-theme-zzo.

Can we match

    content-pre-main-color: #607d8b,
    content-pre-color: #344952,
    content-pre-number-color: #aaa,
    content-pre-background-color: #F5F2F0,
    content-pre-border-background-color: darken(#F5F2F0, 7%),
    content-pre-header-background-color: darken(#F5F2F0, 3%),
    content-pre-header-color: #344952,

to some of the values in

  /* Background */ .chroma { color: #f8f8f2; background-color: #171f2e }
  /* LineHighlight */ .chroma .hl { display: block; width: 100%;background-color: black }
  /* LineNumbersTable */ .chroma .lnt { margin-right: 0.4em; padding: 0 0.4em 0 0.4em;color: #7f7f7f }
  /* LineNumbers */ .chroma .ln { margin-right: 0.4em; padding: 0 0.4em 0 0.4em;color: #7f7f7f }

of the currently selected chrome, rather than fixing it?

That is to say, the color of all div related to code blocks is completely independent of the color of zzo theme.
If they are independent, users can easily achieve this effect

from hugo-theme-zzo.

Now I understand what you mean.
Actually, I think it's a good idea.
I'll investigate more about it on how to achieve that concept.

from hugo-theme-zzo.

@fandean Thank you for the good suggestion.
Now, we have another option variable in the skin.toml file

...
theme_light_chroma_background = "default"
theme_dark_chroma_background = "default"
theme_hacker_chroma_background = "default"
theme_solarized_chroma_background = "default"
theme_custom_chroma_background = "default"

from hugo-theme-zzo.

I'm sorry, I was not clear enough expression 😨

I've been on a long trip today

background ranges from: light, dark, hacker, solarized, custom.
barely OK 😋,And there is also a problem
I want to think about how to explain to you

from hugo-theme-zzo.

The updated version is not what you expected?

from hugo-theme-zzo.

The way I think about it is this

Also, when I set theme_light_chroma = "github" it gets the color value from _github.scss

from hugo-theme-zzo.

Want to completely customize code block color by setting color codes?

In that case, we have to make 7x5= 35 more variables in the main.scss file. I don't think it's a handy way.

It will generate a lot of code unnecessarily, making the code looks more complicated.

from hugo-theme-zzo.

Feasibility is also a consideration, I can compromise on it
But some details can you optimize it?

from hugo-theme-zzo.

I don't understand what this means

Feasibility is also a consideration, I can compromise on it

Yes, the small code block text color needs to change.

from hugo-theme-zzo.

I think you should know more about zzo and related matters than I do. There may be situations I didn't take into account.

hi, if this sentence bothers you, it should be my misspoken words.

from hugo-theme-zzo.

I'm afraid if we make 35 variables to accomplish the goal, it will slow down the web performance. And it makes the Zzo theme more complicated.

I think setting the color one by one is not a good idea.
But we can make more chroma background color packs.
We currently have 5 color packs(dark, light, hacker, solarized, custom).
But if necessary, we make more pack something like darkorange, darksolarized, something like that

hi, if this sentence bothers you, it should be my misspoken words.

never minds😀, Actually, your suggestion makes the Zzo theme better.

from hugo-theme-zzo.

I am relieved, ha ha, looking forward to your results.

Do you see this?

from hugo-theme-zzo.

Yes, I'm fixing it currently.
The code block background-color will be the same. I just plan to change the text color.

from hugo-theme-zzo.

That's exactly what I meant

from hugo-theme-zzo.

@fandean I uploaded for fixing the code block color.

Do you have any color suggestions for the code block? I'll add it if you have a specific color.

content-code-color: ?,
    content-pre-main-color: ?,
    content-pre-color: ?,
    content-pre-number-color: ?,
    content-pre-background-color: ?,
    content-pre-header-background-color: ?,
    content-pre-border-background-color: ?,
    content-pre-header-color: ?,

from hugo-theme-zzo.

Bro,
I think this session is too long. We can close this issue now.
We can talk further by making a new issue!
And I really welcome any issue that makes the Zzo theme better.

You know I deeply appreciate your keep interest.✌️

from hugo-theme-zzo.