Giter VIP home page Giter VIP logo

Comments (13)

zzossig avatar zzossig commented on August 17, 2024 2

Yes, I know it sometimes happen. That is because photoswipe is not supporting dynamic size image and I forced to do that behavior so this happened. Anyway I was planning to solve this issue.

I have another big issue that is to remove dependency of jquery. After doing it, I’ll take care of this issue

from hugo-theme-zzo.

nocquidant avatar nocquidant commented on August 17, 2024 1

If easier, go for 2. Even if it looks more appropriate for big jpg images which my posts don't have, it would be fine for me too ;)

from hugo-theme-zzo.

zzossig avatar zzossig commented on August 17, 2024

I have done the rebuilding gallery.
Now we use Micromodal(1.8kb minified and gzipped), Swipe(6kb minified) library for the gallery.

from hugo-theme-zzo.

zzossig avatar zzossig commented on August 17, 2024

Feel free re-open this issue if the gallery is not working as expected after you updated the Zzo theme

from hugo-theme-zzo.

nocquidant avatar nocquidant commented on August 17, 2024

OK, just tried now and it looks good! But I thought it would displayed the image in its original size.

My small image in text:
image

Should be bigger when clicked (621x394):
image

--nick

from hugo-theme-zzo.

zzossig avatar zzossig commented on August 17, 2024

Did you intentionally make the image small in the text by setting the width, height?

from hugo-theme-zzo.

nocquidant avatar nocquidant commented on August 17, 2024

Yes, as my text could contains several images, I generally set a size for each image for a nice global looking... (my example above was just a test, I generally set the images much bigger to be at least "readable" when in text)

from hugo-theme-zzo.

zzossig avatar zzossig commented on August 17, 2024

How do you think which one is more natural behavior?

  1. Always show the original image
  2. At first, show the modified size. if we click the image, magnify it to the original size.

from hugo-theme-zzo.

zzossig avatar zzossig commented on August 17, 2024

Many photo swipe library has the feature to magnify the image.
bbbb

from hugo-theme-zzo.

nocquidant avatar nocquidant commented on August 17, 2024

For my case, I would prefer 1 (less clicks).

from hugo-theme-zzo.

zzossig avatar zzossig commented on August 17, 2024

Ok, I'll find a way to solve this problem.

from hugo-theme-zzo.

zzossig avatar zzossig commented on August 17, 2024

I did 1. Hope this time works

from hugo-theme-zzo.

nocquidant avatar nocquidant commented on August 17, 2024

Great, thanks!

from hugo-theme-zzo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.