Giter VIP home page Giter VIP logo

omniwindow's People

Contributors

0x000000 avatar damienalexandre avatar kaciaryna avatar nicholasrbowers avatar rkriegelm avatar xzyfer avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

omniwindow's Issues

Modal window scrolls up on mobile

Hi,

I was using your plugin as part of a template I have purchased. Something I noticed is that if I have a modal window thats longer than my phone screen, and have to scroll down, it keeps moving back to the top.

It seems that this is a weird bug or issue with a lot of jquery modal windows. Do you know if there's something I can do to fix it?

Go to my company's website here: www.imapdata.com . If you go down to News, and click on a title there. Now once the window comes up, scroll down some. Then if you scroll up just a tiny bit, it'll jump to the top.

If this is just how things normally behave, just ignore this issue. I just wanted to get in touch and ask if there's anything that can be done. Keep in mind, I do not know how to write javascript/jquery.

Thanks!

callbacks.internal.positioning

I'm having some issues getting this wired up and could use an example. I'm learning so, I apologize this is elementary, but I just can't seem to figure how to get this to center within the plugin.

options.modal.animations.hide is appending (display: none) during transition.

I'm passing this in as my modal hiding animation:

hide: function(subjects, internalCallback) {
    console.log('modal.animations.hide fired');
    subjects.modal.fadeOut(2000, function(){
        console.log('modal.animations.hide callback');
        internalCallback(subjects);
    });
}

While the jQuery animation does play (in the DOM, you can see the opacity changing from 1 to 0 over the specified duration), display: none; is for some reason applied to the element during the animation, hiding any semblance of an animation.

The proper behavior of a fadeIn/fadeOut scenario should be this:

  • Click triggers 'show'.
  • display: block; is applied to overlay, and opacity is transitioned from 0 to 0.8 over the duration (jQuery fadeIn).
  • ow-closed is removed from overlay.
  • display: block; is applied to modal, and opacity is transitioned from 0 to 1 over the duration (jQuery fadeIn).
  • ow-closed is removed from modal.
  • Click on overlay triggers 'hide'.
  • display: block; is applied to modal, and opacity is transitioned from 1 to 0 over the duration (jQuery fadeOut).
  • ow-closed is added to modal.
  • display: block; is applied to overlay, and opacity is transitioned from 0.8 to 0 over the duration (jQuery fadeOut).
  • ow-closed is added to overlay.

Currently, everything here works like it is supposed to, except we're getting a display: none; during the fadeOut of the modal that I don't believe is coming from jQuery (no other animations work either).

Thoughts?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.