Giter VIP home page Giter VIP logo

Comments (3)

0x48piraj avatar 0x48piraj commented on May 27, 2024

Exactly, I used your script as a boilerplate but similar code snippets can be found over YouTube Adblock by Friendly, squgeim/yt-ad-autoskipper and over more similar Chrome extensions.

Furthermore, the code didn't work properly because of #1. I fixed the script as well as ported it to Opera and Firefox (downgrading to M2). And, the project is less than 24 hours old and I plan to completely rebase the core logic as well as add a small UI.

If an open-source project stabilizes and still uses the majority (or all) of code from a repository, then there's a meaning of having a "Credits" section. Doesn't it?

Edit: I can add the credits but I plan to do a rewrite in a day or two so... I will have to remove it afterward, how does that sound?

from fadblock.

oddlyspaced avatar oddlyspaced commented on May 27, 2024

Edit: I can add the credits but I plan to do a rewrite in a day or two so... I will have to remove it afterward, how does that sound?

As long as the logic is going to be similar to what I had or based off mine, I would like to have the credit. If you're rewriting the logic in your own way then sure I won't say a thing.

from fadblock.

0x48piraj avatar 0x48piraj commented on May 27, 2024

The rewrite is complete (2b26707), and just a small note, in that minuscule script, the only logic was videoPlayer.currentTime = videoPlayer.duration - [0~2] which again, is present in numerous YouTube blocking plugins. And if we talk about the code structure, the logic was a bit flawed over a few places i.e. setting up a listener for intrinsic trigger is redundant (#L46).

At last, I chose your script as a boilerplate only because you were a colleague back at college and we are connected socially (for pete's sake!).

from fadblock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.