0x48piraj / fadblock Goto Github PK

Describe the bug
The Ads are still running, but the screen is blacked out. Audio for the ads is still playing.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Windows
• Browser: Microsoft Edge

videoPlayer.muted = true; does not work for the first ad (works for the second ad that follows). I believe it's because this code really starts working after 100 ms.

I'm not sure if there is a workaround to this. But could you please look into this? Thanks.

Google Chrome: Version 118.0.5993.118 (Official Build) (64-bit)
Windows 10 Home, 64-bit operating system, x64-based processor

I tried logging out of my google account and the problem disappeared. It appeared again when I switch back to the main account.

Only Category 1: Ads visible on the home page have been eliminated

I have the addon installed on Opera LVL5 (core: 102.0.4880.90) and I still get the Youtube error

Describe the bug
When trying to watch a video, the page itself wont load. It will take sometime, it can be seconds or a couple minutes. Once it loads, the video plays fine and everything seems normal, even the adblock works as intended.

To Reproduce
Steps to reproduce the behavior:

1. Go to Youtube
2. Click on any video
3. See error

Expected behavior
The video page loads instantly.

Screenshots

Desktop (please complete the following information):

• OS: Windows 11
• Browser: Chrome
• Version: 118.0.5993.118 (64bits)

Additional context
I tried uninstalling the adblock and it fixes the problem (after a few minutes aswell, maybe something related to cache?), so I'm assuming its related to the adblock itself.

Describe the bug
If you try clicking on a chapter name, the list doesn't appear.

To Reproduce
Steps to reproduce the behavior:

1. Enable the extension
2. Click on the chapter name (the one with arrow next to it)
3. nothing happens
4. See error

Expected behavior
The chapter list is supposed to open

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Windows 10
• Browser Firefox
• Version: 1,3

Additional context
The one under the video progress bar thing, that would say "View Chapter"

When playing YouTube videos continuously like using a playlist, sometimes the loading speed cannot keep up with the playback speed, and the only fix is to open a new tab to watch it.
I'm sure FadBlock is the problem because it was perfectly fine before using this extension

https://addons.opera.com/en-gb/extensions/details/fadblock/ currently gives a 404, see https://archive.ph/2023.10.21-121825/https://addons.opera.com/en-gb/extensions/details/fadblock/

Not sure if there is anything within your power to have it reinstated though.

BTW: Great work. On Chrome it works even without adding an exemption in uBlock.

Raj, my friend, I appreciate everything you do and would love to purchase a license for your superior adblock solution--one that allows me to enjoy YouTube without depriving my favorite creators of ad revenue. It's truly a win-win. I honestly don't even miss uBlock Origin (on YouTube, at least) and won't be going back to it for YouTube.

But I cannot for the life of me figure out how I'm meant to purchase a license for Fadblock. I see the popup about the trial period ending, and as far as I can tell from your release notes, the extension itself is supposed to interact with extensionpay for the sake of the license in question, but there appears to be no link, no nothing, to that end. GitHub offers ways to sponsor you, as does your homepage, but none of these indicate any kind of license purchase for Fadblock.

Please just let me know what I should do.

Updated today to 2.0 but it don't works, i tryed it too on a fresh Firefox install with no other addons, installed and uninstalled the addoin, restarted the browser sometimes, but no changes. I don't know but the v1.3 was the last good working one, since i always messed up with the newer versions :(

Here is a screenshot, and a -i hope usefull- DOM state:

outerhtml.txt

Thank you for your work so far

I'm not sure if this is unaccounted for in the content script (either unintentionally or by design) or was simply a one-off fluke but v1.1 appears to not skip user surveys prompted by Youtube. The survey in question did have a skip button. I didn't have time to check the HTML source for any new class names but will keep an eye out for the next one if it happens again.

Edit: Ok I finally caught another survey. It looks like const skipLock is returning False because .ytp-ad-preview-text is not loaded during the survey. It does load the class .ytp-ad-survey though and still has the same .ytp-ad-skip-button class so perhaps including the survey class as an OR operand for skipLock will fix it. I am adding it to my local branch and will see how it goes.

The addon is now making unnecessary access requests to extensionpay.com, I've disabled addon until removed, there's no expalantion why this is there all of a sudden and extremely worrying

I disabled all adblock plugins and only left FadBlock active while logged in youtube using Chrome, but youtube still blocked videos and said adblock is detected. I switched to incognito mode and only kept FadBlock on (without logging in) and this time it worked.

OperaGx ads are not blocked anymore youtube detect that im using an adblocker

This plugin uses technique called "prototype pollution" which is considered anti-pattern and may cause forward compatibility issues in the future if similar methods would be added by the language itself:

There is no real reason to do that really you can just define your own function and call it directly instead of adding it to global document object.

Describe the bug
Does not stop any ads playing during videos (beginning, duo, middle of vid etc) on MacOS 12.2 on Chrome (Version 118.0.5993.117)

All other adblockers are stopped (Adblock)

im having a issue where i can tell that the blocker is working because i see ads flash for a fraction of a second, but i have to refresh once or twice before the popup telling me to disable my blocker goes away and lets me play the video, i have adblock allowing ads on YT

I've disabled my original adblocker, but every time I click on a video, youtube is blocked with the typical "adblockers violate youtube's terms and service" page. I reloaded the browser, even completely restarted the browser, and still the same. Is there something else I need to do?? This is extremely frustrating

I have been using it for the past few days now. Just today, it has stopped working. I tried the newer version 1.3 but it no longer forwards through any ads.

I am using Opera. Sometimes, when skipping the ad, it also skips a part of the actual video. For instance, if the ad is 1:30 minutes long, it may also skip the video for 1:30 minutes. Additionally, sometimes it does not skip the ad.

Its not really a bug but every since I got this extension my YouTube videos have been lagging out more and started lagging during videos which rarely happens with this computer YouTube.

Firefox asked me to accept new permissions and extensionpay.com was listed as one of the new domains needing permissions. Care to explain?

Describe the bug
"Show transcript" does not work when FadBlock is installed and enabled. If you disable FadBlock, "Show transcript" does work.

To Reproduce
Steps to reproduce the behavior:

1. Go to any YouTube video with transcripts
2. Click on "Show transcript"
3. The transcript panel not appear.

Expected behavior
After clicking on "Show transcript", the transcript shows.

Desktop (please complete the following information):

• OS: Windows 11
• Browser: Chrome, Firefox
• Version: Latest

https://github.com/oddlyspaced/skip/blob/main/background.js

The code is literally the same, down to the logic and method names. I don't have any issues you using my logic, but I would really like to have credits.

IDK if it is just my browser (Brave) but sometimes i get a black screen. Not sure could cause this to happen in the extension.

Yesterday the ads were skipping fine, but thing were unable to autoplay and the "pop out" feature on Firefox videos was not working. With today's update it seems like the pop out feature is back and videos can auto play but ads are not skipping.

Run the script every 0.1 second something may cause lagging on my old PC.

For better performance, I changed the setTimeout to MutationObserver. It can reduce a lot of the number of runs. Should i make a pull request?

Also, I would like to disable reflashing all the YouTube tabs after installed. Because all the YouTube videos will play at the same time after reflash. it's so annoying when I have multiple YouTube tabs.

Youtube mobile version not work in Firefox ?

Youtube Enhancer can be allowed by disabling the following options:

Uncheck the "no ads" icon in "controls"

Also, in "ads management" uncheck both boxes.

This will allow youtube enhancer to be used along with fadblock.

The extension skips through ads just fine, but it unfortunately also prevents video transcripts from loading when enabled. I've tested to make sure, and when the extension is off I can pull up the transcript, but when the extension is on clicking the transcript button does nothing. This extension is wonderful and the issue's not that big of a deal, but if it could be fixed it would be perfect! Thanks!

**I've tried it in Firefox Developer Edition and Google Chrome, and the issue is the same on both

This extension has the exact same implementation for all three different browsers currently: chrome, firefox and opera.

This is of course fine for the beginning but as you will try to maintain this project it will become harder and harder to do so and keep track of changes in all 3 implementations. Also if time will come for another implementation it will add even greater complexity for maintenance.

I would suggest extracting the main extension logic into a reusable code which does not depend on any specific browser extension APIs and then linking it in specific extensions.

If you like I would gladly help you with refactoring as this change most likely will have to introduce a proper build step using something like rollup or vite (not sh/bash).

When I try to watch the video, YouTube starts endlessly refreshing the page. I'm not using any other ad blockers, but I have that issue in the past (while using ad blockers)

I have several extensions (Firefox) for YouTube and I had issues with playing videos because of them conflicting with Fadblock. Is it possible to gather list so the users will know which plugins they should avoid?
For example:

Conflicting:
uBlock Origin (if youtube is not whitelisted)
Enhancer For Youtube

Non-conflicting:
no-more-rounded-corners
Return YouTube Dislike
SponsorBlock for YouTube

I've noticed that this extension will try to reload any YT tab whenever it gets updated in the background or even when browser itself get's updated which makes no sense and is quite disruptive for a UX:

Can you consider removing this option, and just auto reloading on install as this is the only time when reloading is acceptable-ish, even tho I would argue that is also not desirable in some cases, like you would like to note a timestamp of a video you are watching before reload (yes if your YT history is off it will not even remember your last played time geez).

Maybe this option can also be configurable from the extension management so users can opt-in for auto-update as it is right now but that is not that critical I think, the most important is to remove disruptive behavior first I think.

Thanks for the extension btw!

Installed fadblock and was working as expected for ~ 1 week - Youtube ads would load, and then be promptly skipped. Logged in today and found that youtube ads are loading and playing at 1x speed, and without video - only sound.

Earlier today, I tried watching a youtube video when the ad block message from youtube randomly showed up. All my other adblocks are disabled and I went as far as deleting them and only keep fadblock yet the message still shows.

Hi,
this peace of software is so sweet. I cant believe it.
Thank you!

When Enhancer for YouTube is active, the nagging screen appears, when Enhancer for YouTube is disabled, the nagging screen does not appear. Reproduced only on 1 system, needs others.

Not sure if this should be fixed here, or at Enhancer for YouTube, or even if you want to fix this, and start a never ending compatibility chase, but Enhancer for YouTube is used by a million users. So it's up to you if you want to say "fuck off".

Thanks for your work.

When seeking video on Youtube there's a noticable audio delay now. The video starts playing instantly, but the audio takes a second or two to start.

Firefox, latest version 118.0.2 Win 11.

Ads are playing as if there are not ad-blocking/ad-skipping extensions

Platform: Firefox / Linux.

Reproduce: open a new video with new tab will cause it no loading but black screen on the new tab
Reload the new tab doesn't help.

(click on video directly without opening it in new tab works fine)

After the 26-10-2023 update, the extension stopped working

Youtube no longer auto play the next video when extension is on and autoplay button is missing too.

chrome.tabs is not available in a content script by design. Content scripts can access only 4 chrome API so chrome.tabs is only available in a background/popup or other internal extension page that has chrome-extension://<extension-id>/ URL.

Content script can only use chrome.i18n, chrome.dom, chrome.storage, and a subset of chrome.runtime/chrome.extension.

Most chrome APIs such as chrome.tabs are only available the background script (service worker in MV3), popup script, etc.

Solution

Pass a message from the content script to the background script and use the API there.

I hope to speed up the ads on YouTube Music. Currently, when I listen music on YouTube Music, the ads still play in full, and ad blockers consider youtube.com and music.youtube.com as the same domain, so they can only be enabled or disabled at the same time.

Thank you for this amazing extension, it made me realize how much I take adblock for granted. Really small nitpick is I'll be playing some music and between songs i'll sometimes hear a tenth of a second of an ad before it skips it. Would appreciate if ads could be muted to remove the small disturbance.

Found an issue that quite a few ads for me at the start of the video are still played for around 10s. The ads themselves are not shown, just the loading animation. Not sure if this is intentional?

All YouTube videos suddenly refreshed (progress/state lost) and CPU went to 100% for some time as a result.
I presume this was due to the extension updating. It happened once when the extension was installed and today was the second time it happened.

This is undesirable behavior.

I installed the extension yesterday. It seemingly worked (by allowing only 1s of an ad to be played).

Today ads are not skipped for me too. This is the HTML i managed to copy out: Copy-outerHTML-for-v=GmxegKvxvJM-by-sskras.txt