This does not work about fadblock HOT 14 CLOSED

Can you try again with the new release (v1.1) and post results?

It works now, I think they patched the previous release.

from fadblock.

I will add this works for me but intermittently. Some ads I can tell they get fast forwarded and others will play the entire ad. Will try to capture some information next time it happens. I believe it is predominately non-skippable in-stream ads

from fadblock.

Does not work for me on Brave browser. Disabled uBlock Origin. Cleared cookies. 1.59.117 Chromium: 118.0.5993.70 (Official Build) (64-bit)

Brave has a built in Ad Block. That also triggers the popup.
You can disable it by clickin on the icon at the end of the url field and removing the tick.

from fadblock.

In Private Window, it does work but not in regular window in which i have an account logged in. Yesterday it was working fine when logged in and also today maybe I watched 1 video in the morning, i think it was working.

Browser: Firefox
OS: Linux
Version: 1.2 (Updated 19th Oct. 2023)

Edit:
It seems the extension is crashing due to the following error,
TypeError: HTMLMediaElement.currentTime setter: Value being assigned is not a finite floating-point value.

in content.js line no.11, videoPlayer.currentTime = videoPlayer.duration - 0.1;

It was 15 seconds non skippable Ad on which it crashed.

from fadblock.

@vaibhavgoyal09 can you install fadblock-1.2.1 (https://addons.mozilla.org/en-US/firefox/addon/fadblock/) or via https://github.com/0x48piraj/fadblock/releases/tag/1.2.1

from fadblock.

It works. Closing.

from fadblock.

And by 'error' do you mean the ads are not getting blocked/skipped?

from fadblock.

Can you try again with the new release (v1.1) and post results?

from fadblock.

I still get the error.

from fadblock.

I still get the error.

Mine works great so idk what u are doing. You sure u updated to the latest version V1.1 and deleted the V 1.0?

from fadblock.

I still get the error.

Make sure to disable your other adblockers too. For example, I run Ublock Origin but specifically for ANY youtube site, I have made it turn off so that when I go to YT, the ONLY adblock extension running is Fadblock V 1.1

from fadblock.

Does not work for me on Brave browser. Disabled uBlock Origin. Cleared cookies.
1.59.117 Chromium: 118.0.5993.70 (Official Build) (64-bit)

from fadblock.

@boulwabd Thank you for providing some background, as YouTube ads are displayed at random and I don't want to collect user data at all so that makes testing very hard to do without user feedback. I'll look into this issue!

from fadblock.

@boulwabd Thank you for providing some background, as YouTube ads are displayed at random and I don't want to collect user data at all so that makes testing very hard to do without user feedback. I'll look into this issue!

No problem. So I did some more investigating and the class names during the unskipped Ad all match expected values. Also, if I refresh the page when it happens it will skip the reloaded Ad. Could be something with isAdShowing not being called. I should note that it is specifically on very long videos that I have playing continuously in the background like music (1 hour+). I will add some console statements and see if I can pinpoint what's happening.

EDIT: My version was 1.0 still woops. Will monitor if the issue exists in 1.1 and report back

from fadblock.