Giter VIP home page Giter VIP logo

Comments (17)

Grg76 avatar Grg76 commented on May 27, 2024 2

Yes, i closed and restarted my browser. I did it now again plus uninstalled and reinstalled Fadblock, but the ads still there.
Win10 Pro/64 Firefox 119.0

Névtelen-1

On my laptop with Win7 Pro/64 Firefox ESR 115.4.0 the V1.5 works fine, and shows the blocked ad counter.
(But it is slowing down my laptop very much, even my browser tells me that the Fadblock extension is slowing down my laptop. Ok, its not thew newest with I3 2310M and 4GB Ram :) . The V1.3 does not slowing it down, fortunatley is mainly use my PC so this is not a big problem an id can use this version as long it works :) )

Untitled

from fadblock.

imjeffreylee avatar imjeffreylee commented on May 27, 2024 1

I have the same issue, ads are not skipped when I am logged in. Works fine when I'm not logged in.
Chrome version: 118.0.5993.118
Windows 11 Home, 64 bit

from fadblock.

Grg76 avatar Grg76 commented on May 27, 2024 1

Ok, now it is working. I don't know what was the problem... I disabled all my extensions, un/reinstalled Fadblock, restart my browser 2-3 times, and now it is works fine, also with all my addons enabled again. :)

from fadblock.

Shadowized avatar Shadowized commented on May 27, 2024 1

I have the same problem, I updated last night and this morning I load a video and instantly see an ad and it has "undefined" in the menu. Downgraded to 1.3 for the time being.

from fadblock.

0x48piraj avatar 0x48piraj commented on May 27, 2024 1

I am working on it. Seems like a few things are not being initialized properly as well as there are some performance issues.

from fadblock.

0x48piraj avatar 0x48piraj commented on May 27, 2024

Thank you for providing the details. can you dump the current DOM state so I can examine it closely? (it's working for me as well as the majority as of now)

How to?

When FadBlock doesn't work on a specific ad, while the ad is showing, pause the ad, then using the Web Inspector (F12), go to the Elements tab, right-click on the <html> tag in your code, and select Copy->Copy outerHTML. Then paste that into a new file and save.

from fadblock.

Driftlife avatar Driftlife commented on May 27, 2024

How do I provide DOM state?
Is this information what you need?

from fadblock.

0x48piraj avatar 0x48piraj commented on May 27, 2024

I'm investigating that issue currently.

from fadblock.

samliu23 avatar samliu23 commented on May 27, 2024

same for edge
version: 118.0.2088.76
Windows 11 Home, 64 bit
Copy.outerHTML.txt

from fadblock.

CloudOKC avatar CloudOKC commented on May 27, 2024

same on Firefox after Firefox request new authority
win10 pro 21H2, Firefox 119.0 x64

from fadblock.

Grg76 avatar Grg76 commented on May 27, 2024

After updating to V1.5 ads are not skipped, and sponsored content is visible too. When i downgrade to the V1.3 its working fine again. Using Firefox.

Névtelen-1
Névtelen-2

from fadblock.

0x48piraj avatar 0x48piraj commented on May 27, 2024

Did you refresh the browser after updating to v1.5? @Grg76

If so, can I get a screenshot of the FadBlock UI screen?

Edit: The new version implements Observer API which is more efficient, but it seems like the release was rushed. This project is carving up so much of my time which led to implementing an open-core model for sustainability. Read the announcement section for more information.

from fadblock.

Weilun0812 avatar Weilun0812 commented on May 27, 2024

@0x48piraj
My problem is that it doesn't work when I use my main account to watch, but it works when I switch to other accounts.

from fadblock.

0x48piraj avatar 0x48piraj commented on May 27, 2024

@Grg76 (a big shoutout for the detailed report), @Shadowized you guys can update the version to 1.6 manually, an urgent fix was rolled out just now.

from fadblock.

0x48piraj avatar 0x48piraj commented on May 27, 2024

For Chromium users, v1.5 will fix all the issues. Please wait till Chrome reviews and approves the new codebase. Closing.

If you're on Firefox as well, use https://addons.mozilla.org/en-US/firefox/addon/fadblock/ (v1.6) until it gets released.

from fadblock.

imjeffreylee avatar imjeffreylee commented on May 27, 2024

@0x48piraj Do we know long does it usually take Google to approve it?

from fadblock.

0x48piraj avatar 0x48piraj commented on May 27, 2024

@imjeffreylee It usually takes around 24-48 hours.

from fadblock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.