0xavier / sub Goto Github PK

Important: check the doc for possible modification after the renaming.

To be consistant with the main logic of the project, the adapter should not be a notion known by the EventEngine.

Write a method to get the list of pids corresponding to removable players. This method could be used by a player that wants to join the game.

Write documentation about this method in doc/game.md:removable players

Change the way players connect to the game, to be consistant with the documentation (doc/general_architecture.md). More precisely, it should be:

game = GameEngine()
player = AIPlayer(0) # 0 is the player ID 
padapt = LocalPlayerAdapter(player) 
game.add_player(padapt)

Add the possibility to set cards manually for controlled players, in order to interface Players (AI or UI) with another instance of the game (for instance belote-en-ligne.fr).

When a player try to join a game with an id that is already taken by a non-removable user, the GameEngine should raise an explicit exception (and not IndexError).

Relative code:
https://github.com/BobCitron/Sub/blob/refactoring_2/src/game/game_engine.py#L58-L59
https://github.com/BobCitron/Sub/blob/refactoring_2/main.py#L37
https://github.com/BobCitron/Sub/blob/refactoring_2/src/ui/ui_table.py#L344-L345

Create a client and a server to dialog through sockets. The two main aims are:

• Connect remotely players to a game
• Connect remotely UI to a game

The general idea is described in doc/general_architecture.md.

A documentation should also be provided with implementation.

• Create an adapter interface to define correctly the methods that a UIAdapter should implement.
• UIAdapter should inherit from this interface.

Add all imports needed in code snippets in the doc. For instance (from doc/general_architecture.md):

game = GameEngine()
evt = EventEngine()
game.connect_event_manager(evt)

should be:

from src.game.game_engine import GameEngine
from src.event.event_engine import EventEngine 

game = GameEngine()
evt = EventEngine()
game.connect_event_manager(evt)

Use the add_player method in the GameEngine constructor to add default players instead of putting them in the list directly.

The UIAdapter should be more specific, as we can imagine different UI adapters in the future, and more precisely RemoteUIAdapter.

The parameter ìs_removableinPlayerconstructor should be passed through kwargs for more clarity. Also add a default value toFalse`.

Example:
Player(0, is_removable=True) is clearer than Player(0, True).

Some interfaces does not have the correct prefix (i_), e.g. console.py should be i_console.py.

• Check that every interface has the correct prefix
• Check that every method defined by an interface is decorated with @abstractmethod