Giter VIP home page Giter VIP logo

gun-lender's People

Contributors

0xf4lc0n avatar alekongo avatar pujson6767 avatar

Watchers

 avatar

gun-lender's Issues

Restrict ammo actions to admin only

The following actions should be restricted to administrators only:

public void create(@NotNull Context context) {

public void delete(@NotNull Context context, @NotNull String s) {

public void update(@NotNull Context context, @NotNull String s) {

Use https://github.com/0xf4lc0n/gun-lender/blob/d620206a4f8f4d16b180467dc6015b4f07776e2c/src/main/java/gunlender/server/routes/GunController.java as reference.

Lending CRUD endpoints

Using CrudHandler will be convinient.

Every logged user can lend a weapon with the appropriate ammunition (if both are available).

Logged users can view/edit and delete their lending of weapon.
Administrator can view/edit and delete all lending entries.

User CRUD endpoints

Using CrudHandler will be convinient.

Adding a new user will be handled by the register endpoint. We can make a redirection from POST /api/user to POST /register.

Users can be retrieved only via ID (/api/user/{id}).
Normal users can edit and delete their account.
Administrators can edit and delete all accounts.

Typos in method names

void retrievingNoneExistingUserByIdDoesNotThrow() throws Exception {

void retrievingNoneExistingUserByIdDoesNotThrow() throws Exception {

void retrievingNoneExistingUserByIdDoesNotThrow() throws Exception {

void retrievingNoneExistingLendingByUserIdDoesNotThrow() throws Exception {

void retrievingNoneExistingLendingByGunIdDoesNotThrow() throws Exception {

void retrievingNoneExistingLendingByAmmoIdDoesNotThrow() throws Exception {

Instead of NoneExisting there should be NonExisting.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.