Align Rust's NoteTag with MASM create_note about miden-base HOT 5 CLOSED

The new scheme is:

The validation changes to if the two high bits are not 11, then the note must be public.

from miden-base.

Notes:

• The create_note doesn't have the notion of local/network execution. It seems we missed the issue to implement it.
  • The Rust code execution flag is based on this comment, which uses the highest bit
  • The MASM code diverged from this encoding because of this change

from miden-base.

I guess we should add an abstraction of Note's Tags. That is to say, the implementation of NoteTag is basically hardcoded for the P2ID use case. I think we need a less opinionated implementation, to be used by apps.

The implementation would have the note storage and execution types as arguments, and would ensure these are correctly encoded. And would allow the user to define the rest of the bits to anything. The goal would be to support the sync API properly.

I think it would also make sense to have an wrapper of the u32 type, that validates the user specified bits of the the TAG fit in the space available.

from miden-base.

As commented in #642, I don't think there was a bug (as far as I can tell, things worked as intended) - but we were missing a constructor for creating tags for "use case" notes. I left a comment in the PR about a potential way to address this.

from miden-base.

Closed by #657.

from miden-base.