There is a new WordPress version that the plugin hasn't been tested with. Please test it and then change the "Tested up to" field in the plugin readme.

Tested up to: 6.0
Latest version: 6.1

This issue will be closed automatically when the versions match.

Describe the bug
For a great user experience, Gutenberg Block Editor should Match Admin Styles & Frontend Styles.
Some block looks totally different in FE and BE. Would be great if we match both view.

Steps to Reproduce

1. Edit 'Media Kit' page in BE
2. Open same page in FE

Expected behavior
The layout and view/styles should match. So admin will be able to update page style according to requirement and will not need to save changes every time to just see preview of all current changes.

For ex.

1. In the below screenshot, admin screen shows 4 column layout but FE screen shows 5 column layout.
2. In admin screen, background color starting from end of the block and in FE, starting from middle of the block.

Screenshots

Admin View -

FE View-

Environment information
macOS Monterey, Chrome, and 2021 theme.

WordPress information

Additional context

Is your enhancement related to a problem? Please describe.

We are currently running E2E tests by installing dependencies and building plugin files. This is not the most accurate plugin build that will be shipped during the release. To make E2E tests more accurate and match the plugin build with the release build generated by our deploy action, we should generate a plugin build with the "build zip" action. Running E2E tests on this build will give us more accurate results.

PR for reference: 10up/autoshare-for-twitter#206

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Describe the bug
Our packages section should be responsive in ipad
Ipad viewport - (768 *1024)

Steps to Reproduce

Go to Media Kit page
Scroll down
Expected behavior
Frontend should be match with design

Screenshots
https://www.screencast.com/t/xesf1exIsS

Environment information

Device: MacBook
OS: 12.0.1
Browser and version: Chrome 96.0.4664.55, Safari 15.1
WordPress version: 5.8.2
Theme and version: Twenty Twenty-OneVersion: 1.4 , NewspackVersion: 1.54.0-alpha.1 ,
Newspack JosephVersion: 1.53.2
** Site Helth Info**

Is your enhancement related to a problem? Please describe.

We’re looking to take the blocks that are included in the media kit page created by the plugin (see screenshots in the readme file) and then craft each of those blocks (except for the tab blocks one as there’s nothing to base that on currently in core) as block patterns. Our hope is that each of those blocks, tab ones not included, can get into a pattern that we can then submit to the WP.org Block Pattern Directory via the 10up account.

Designs

See existing block/pattern designs within the plugin itself (or screenshots from README.md).

Describe alternatives you've considered

n/a

Code of Conduct

• I agree to follow this project's Code of Conduct

Describe the bug
Gutenberg had been released with the concept of WYSIWYG (what you see is what you get). In simple words, the backed should be styled exactly like the front end. In the PMK, we do not get it same for the Tabs block.

Steps to Reproduce

1. Go to the 'Publisher Media Kit' page in the back end and in the front end.
2. See the tabs block, designs are different on both ends.

Note: Twenty Twenty-One theme was used in this testing. All the other themes (i.e. newspack, etc.) should also be taken care of for this bug fix.

Expected behavior
The design of the tabs block including all the other blocks should be matched and exactly the same as per the WYSIWYG.

Screenshots

Backend:

Frontend:

Environment information

• Device: MacBook
• OS: MacOS 1.6
• Browser and version: Chrome latest
• WordPress version: 5.8.1

Is your enhancement related to a problem? Please describe.

Update the tabs block as per the new upstream block releases.
https://github.com/10up/block-library/releases/tag/1.0.2

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Describe the bug

This issue is for tracking changes for the 1.1.0 release. Target release date: March 2022 or Early April.

Pre-release steps

• Confirm build commands, ensure GitHub Actions building plugin correctly

Release steps

• Branch: Starting from develop, cut a release branch named release/1.1.0 for your changes.
• Version bump: Bump the version number in package-lock.json, package.json, publisher-media-kit.php, readme.txt, and any other relevant files if it does not already reflect the version being released. Update both the plugin "Version:" property and the plugin PUBLISHER_MEDIA_KIT_VERSION constant in publisher-media-kit.php.
• Changelog: Add/update the changelog in CHANGELOG.md and readme.txt.
• Props: update CREDITS.md file with any new contributors, confirm maintainers are accurate.
• New files: Check to be sure any new files/paths that are unnecessary in the production version are included in .distignore.
• Readme updates: Make any other readme changes as necessary. README.md is geared toward GitHub and readme.txt contains WordPress.org-specific content. The two are slightly different.
• Make sure the release date added in the CHANGELOG.md.
• Merge: Make a non-fast-forward merge from your release branch to develop (or merge the pull request), then do the same for develop into trunk (git checkout trunk && git merge --no-ff develop). trunk contains the stable development version.
• Push: Push your trunk branch to GitHub (e.g. git push origin trunk).
• Release: Create a new release, naming the tag and the release with the new version number, and targeting the trunk branch. Paste the changelog from CHANGELOG.md into the body of the release and include a link to the closed issues on the milestone.
• SVN: Wait for the GitHub Action to finish deploying to the WordPress.org repository. If all goes well, users with SVN commit access for that plugin will receive an emailed diff of changes.
• Check WordPress.org: Ensure that the changes are live on https://wordpress.org/plugins/publisher-media-kit/. This may take a few minutes.
• Close milestone: Edit the milestone with release date (in the Due date (optional) field) and link to GitHub release (in the Description field), then close the milestone.
• Punt incomplete items: If any open issues or PRs which were milestoned for 1.1.0 do not make it into the release, update their milestone to1.2.0 or Future Release

Describe the bug
As a part of the process, ES lint errors and warnings are removed recently but it caused the tabs block to stop working. Few ES lint errors displayed constants/components defined/imported but not being used in the file - so they were removed but actually, they were being used in the included files and ES lint is not smart enough to check it.

Steps to Reproduce

1. Install plugin
2. Activate it
3. Go to the Publisher Media Kit page (created on plugin activation)
4. See Tabs block are not registered.

Expected behavior
The tabs block should be visible and editable.

Screenshots

Describe the bug
Still have questions? We can help section - Font style is not proper

Steps to Reproduce

1. Go to Media Kit page
2. Scroll down to Still have questions? We can help section

Expected behavior
Frontend should be match with design

Screenshots
https://www.screencast.com/t/y4CyBEnzrrTh

Environment information

• Device: MacBook

• OS: 12.0.1

• Browser and version: Chrome 96.0.4664.55, Safari 15.1

• WordPress version: 5.8.2

• Theme and version: Twenty Twenty-OneVersion: 1.4 , NewspackVersion: 1.54.0-alpha.1 ,
  Newspack JosephVersion: 1.53.2

`

wp-core

version: 5.8.2
site_language: en_US
user_language: en_US
timezone: +00:00
permalink: /%postname%/
https_status: false
multisite: false
user_registration: 0
blog_public: 1
default_comment_status: open
environment_type: local
user_count: 1
dotorg_communication: true

wp-paths-sizes

wordpress_path: /Users/sudipdadhaniya/Local Sites/pmk/app/public
wordpress_size: 43.72 MB (45844471 bytes)
uploads_path: /Users/sudipdadhaniya/Local Sites/pmk/app/public/wp-content/uploads
uploads_size: 0.00 B (0 bytes)
themes_path: /Users/sudipdadhaniya/Local Sites/pmk/app/public/wp-content/themes
themes_size: 12.82 MB (13445530 bytes)
plugins_path: /Users/sudipdadhaniya/Local Sites/pmk/app/public/wp-content/plugins
plugins_size: 396.75 MB (416017515 bytes)
database_size: 2.88 MB (3014656 bytes)
total_size: 456.16 MB (478322172 bytes)

wp-active-theme

name: Newspack Scott (newspack-scott)
version: 1.53.2
author: Automattic
author_website: https://newspack.blog
parent_theme: Newspack (newspack-theme)
theme_features: core-block-patterns, widgets-block-editor, automatic-feed-links, title-tag, post-thumbnails, menus, html5, custom-logo, customize-selective-refresh-widgets, wp-block-styles, align-wide, editor-styles, editor-font-sizes, editor-color-palette, editor-gradient-presets, custom-spacing, responsive-embeds, amp, post-subtitle, post-formats, web-stories, editor-style, widgets
theme_path: /Users/sudipdadhaniya/Local Sites/pmk/app/public/wp-content/themes/newspack-scott
auto_update: Disabled

wp-parent-theme

name: Newspack (newspack-theme)
version: 1.54.0-alpha.1
author: Automattic
author_website: https://newspack.blog
theme_path: /Users/sudipdadhaniya/Local Sites/pmk/app/public/wp-content/themes/newspack-theme
auto_update: Disabled

wp-themes-inactive (7)

Newspack Joseph: version: 1.53.2, author: Automattic, Auto-updates disabled
Newspack Katharine: version: 1.53.2, author: Automattic, Auto-updates disabled
Newspack Nelson: version: 1.53.2, author: Automattic, Auto-updates disabled
Newspack Sacha: version: 1.53.2, author: Automattic, Auto-updates disabled
Twenty Nineteen: version: 2.1, author: the WordPress team, Auto-updates disabled
Twenty Twenty: version: 1.8, author: the WordPress team, Auto-updates disabled
Twenty Twenty-One: version: 1.4, author: the WordPress team, Auto-updates disabled

wp-plugins-active (1)

Publisher Media Kit: version: 0.1.0, author: 10up, Auto-updates disabled

wp-media

image_editor: WP_Image_Editor_GD
imagick_module_version: Not available
imagemagick_version: Not available
imagick_version: Not available
file_uploads: File uploads is turned off
post_max_size: 1000M
upload_max_filesize: 300M
max_effective_size: 300 MB
max_file_uploads: 20
gd_version: bundled (2.1.0 compatible)
gd_formats: GIF, JPEG, PNG, BMP
ghostscript_version: not available

wp-server

server_architecture: Darwin 21.1.0 x86_64
httpd_software: nginx/1.16.0
php_version: 7.3.5 64bit
php_sapi: fpm-fcgi
max_input_variables: 4000
time_limit: 1200
memory_limit: 256M
max_input_time: 600
upload_max_filesize: 300M
php_post_max_size: 1000M
curl_version: 7.54.0 LibreSSL/2.6.5
suhosin: false
imagick_availability: false
pretty_permalinks: true
htaccess_extra_rules: false

wp-database

extension: mysqli
server_version: 8.0.16
client_version: mysqlnd 5.0.12-dev - 20150407 - $Id: 7cc7cc96e675f6d72e5cf0f267f48e167c2abb23 $

wp-constants

WP_HOME: undefined
WP_SITEURL: undefined
WP_CONTENT_DIR: /Users/sudipdadhaniya/Local Sites/pmk/app/public/wp-content
WP_PLUGIN_DIR: /Users/sudipdadhaniya/Local Sites/pmk/app/public/wp-content/plugins
WP_MEMORY_LIMIT: 40M
WP_MAX_MEMORY_LIMIT: 256M
WP_DEBUG: false
WP_DEBUG_DISPLAY: true
WP_DEBUG_LOG: false
SCRIPT_DEBUG: false
WP_CACHE: false
CONCATENATE_SCRIPTS: undefined
COMPRESS_SCRIPTS: undefined
COMPRESS_CSS: undefined
WP_LOCAL_DEV: undefined
DB_CHARSET: utf8
DB_COLLATE: undefined

wp-filesystem

wordpress: writable
wp-content: writable
uploads: writable
plugins: writable
themes: writable
mu-plugins: writable

Is your enhancement related to a problem? Please describe.

A new Action is released: https://github.com/10up/action-wordpress-plugin-build-zip/. This is already set up in a few PRs: Insert Special Characters, Autoshare for Twitter and Simple Podcasting. As an example, you can see/download the Simple Podcasting zip here.

Please go ahead and create the same in this repository.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Describe the bug

The composer.json file for this plugin sets up psr-4 autoloads for classes within the PublisherMediaKit namespace.

However, the only class PublisherMediaKit\Blocks\BlockContext\Tabs is in the file includes/classes/blocks/BlockContext/Tabs.php so does not meet this convention. The difference is that the namespace fragment Blocks uses an uppercase B, while the folder name blocks uses a lowecase B.

This hasn't come to light as an issue previously as the file for the class is manually required within the main plugin file, the composer autoloader isn't included in the distributed version on WordPress.org so this hasn't caused a problem. I expect the file is manually required as the autoloader was failing on case sensitive file systems.

I see two possible fixes

• Remove PSR-4 autoloading
• Rename the namespace to match the lowercase B of the folder name. I'm suggesting renaming the namespace (even though it's not great to have a mix of case) as PHP namespaces are case insensitive but not all file systems are.

Steps to Reproduce

1. Clone the repository
2. Install composer with the optimized autoloader switch composer install --no-dev --optimize-autoloader
3. Composer will warn: Class PublisherMediaKit\Blocks\BlockContext\Tabs located in ./includes/classes/blocks/BlockContext/Tabs.php does not comply with psr-4 autoloading standard. Skipping.

Screenshots, screen recording, code snippet

$> composer install --no-dev --optimize-autoloader
Installing dependencies from lock file
Verifying lock file contents can be installed on current platform.
Nothing to install, update or remove
Package phpunit/php-token-stream is abandoned, you should avoid using it. No replacement was suggested.
Generating optimized autoload files
Class PublisherMediaKit\Blocks\BlockContext\Tabs located in ./includes/classes/blocks/BlockContext/Tabs.php does not comply with psr-4 autoloading standard. Skipping.

Environment information

• OS: macOS Monterey 12.6.1
• PHP: 7.4.30

WordPress information

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Is your enhancement related to a problem? Please describe.

The cards on the media kit page are not center aligned on the tablet viewport. (1024px * 768px)

Describe the solution you'd like

The cards should be center aligned, like the rest of the elements on the page.

Designs

Is your enhancement related to a problem? Please describe.

There is no problem but the page would look much better with some padding in those highlighted areas.
So

me are too close to the container borders

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Describe your question

So, the plugin will create a 'Media Kit' page.
What happens if I rename that filed to let's say 'Kelvin's Kit'.
If I deactivate and activate back the plugin, is the plugin supposed to create a new 'Media Kit' page?
Currently it won't unless I delete the page itself.
I was just curious as to how the plugin identifies there has already been a 'Media Kit' page created and renamed?

Code of Conduct

• I agree to follow this project's Code of Conduct

Describe the bug
Audience Profiles data section should be responsive in ipad
Ipad viewport - (768 *1024)

Steps to Reproduce

1. Go to Media Kit page
2. Scroll down

Expected behavior
Frontend should be match with design

Screenshots
https://www.screencast.com/t/WfGFbOUL

Environment information

• Device: MacBook
• OS: 12.0.1
• Browser and version: Chrome 96.0.4664.55, Safari 15.1
• WordPress version: 5.8.2
• Theme and version: Twenty Twenty-OneVersion: 1.4 , NewspackVersion: 1.54.0-alpha.1 ,
  Newspack JosephVersion: 1.53.2

** Site Helth Info**

Describe the bug

When I try to change a value and press 'Update', I get the error 'Updating failed. The response is not a valid JSON response.'

Steps to Reproduce

1. Go to the Media page
2. Update a value, e.g. Change the 'The average female visitor is 38 years old' to 'The average female visitor is 37 years old'
3. Click Update

Screenshots, screen recording, code snippet

Environment information

Device MacBook Pro (Retina, 15-inch, Mid 2015)
OS Mc Os Monterey 12.6.3
Chrome Version 111.0.5563.110 (Official Build) (x86_64)

WordPress information

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Since everything is already merged in, leaving some code review feedback in this issue rather than through the normal PR process.

includes/core.php

• We set a transient here that then triggers the showing of an admin notice: https://github.com/10up/publisher-media-kit/blob/develop/includes/core.php#L79. What if the Media Kit page wasn't successfully created for whatever reason? I would suggest we add that transient in the create_media_kit_page method: https://github.com/10up/publisher-media-kit/blob/develop/includes/core.php#L122
• We should probably pass the admin notice text through translation: https://github.com/10up/publisher-media-kit/blob/develop/includes/core.php#L97
• Curious if there was a reason for doing a straight DB query instead of a normal WP_Query here: https://github.com/10up/publisher-media-kit/blob/develop/includes/core.php#L126
• Missing text domain here: https://github.com/10up/publisher-media-kit/blob/develop/includes/core.php#L145
• It's unlikely but we should probably ensure the post creation process succeeded before proceeding here: https://github.com/10up/publisher-media-kit/blob/develop/includes/core.php#L154. This means we don't add the post meta, we don't add the option and we don't set the transient value (mentioned in the first list item here) unless this wp_insert_post call succeeds. We could think about showing an error message if it fails but that's probably overkill

includes/blocks.php

• Curious on this line: https://github.com/10up/publisher-media-kit/blob/develop/includes/blocks.php#L45. We remove a filter but I don't see that filter ever being added. If it's not used, we should remove this line and the actual filter_plugins_url method

includes/blocks/block-editor/tabs/

• I'm assuming this block was just copied over from a 10up block but does seem weird to me to have a CHANGELOG.md and README.md files here

includes/blocks/utils/

• As far as I can see, the isLodash function is never used. Thinking we can just remove that file if that's the case: https://github.com/10up/publisher-media-kit/blob/develop/includes/blocks/utils/isLodash.js
• Doesn't seem like this function is used either: https://github.com/10up/publisher-media-kit/blob/develop/includes/blocks/utils/register-block.js#L21
• If we remove the above, can also remove these comments: https://github.com/10up/publisher-media-kit/blob/develop/includes/blocks/utils/register-block.js#L34

includes/assets/images/

• This image is super large, both dimensions and more importantly the file size: https://github.com/10up/publisher-media-kit/blob/develop/assets/images/cover-image.png. Since this ends up getting used by default in our Media Kit page we create, we should optimize this as much as possible. Just doing a brief test, converting that from a PNG to a JPG goes from ~18MB to ~4MB (which is way better but still really big). Wondering if there's more optimizations we can do here, maybe size dimensions down a bit?

Describe the bug

There is a vertical scroll coming on the Media Kit Page.

Steps to Reproduce

1. Visit the media-kit page in the Front End
2. Try to scroll the page vertically

Expected behavior

There should be no vertical scroll present on the page.

Screenshots

Environment information

• Device: MacBook
• OS: MacOS 11.6
• Browser and version: Chrome 94.0.4606.61
• WordPress version: 5.8.1
• Theme and version: Twenty Twenty One

• Site Health Info:

`

wp-core

version: 5.8.1
site_language: en_US
user_language: en_US
timezone: +00:00
permalink: /%postname%/
https_status: true
multisite: false
user_registration: 0
blog_public: 1
default_comment_status: open
environment_type: production
user_count: 1
dotorg_communication: true

wp-paths-sizes

wordpress_path: /var/www/html
wordpress_size: loading...
uploads_path: /var/www/html/wp-content/uploads
uploads_size: loading...
themes_path: /var/www/html/wp-content/themes
themes_size: loading...
plugins_path: /var/www/html/wp-content/plugins
plugins_size: loading...
database_size: loading...
total_size: loading...

wp-active-theme

name: Twenty Twenty-One (twentytwentyone)
version: 1.4
author: the WordPress team
author_website: https://wordpress.org/
parent_theme: none
theme_features: core-block-patterns, widgets-block-editor, automatic-feed-links, title-tag, post-formats, post-thumbnails, menus, html5, custom-logo, customize-selective-refresh-widgets, wp-block-styles, align-wide, editor-styles, editor-style, editor-font-sizes, custom-background, editor-color-palette, editor-gradient-presets, responsive-embeds, custom-line-height, experimental-link-color, custom-spacing, custom-units, widgets
theme_path: /var/www/html/wp-content/themes/twentytwentyone
auto_update: Disabled

wp-themes-inactive (2)

10up Theme: version: 0.1.0, author: 10up, Auto-updates disabled
Newspack: version: 1.50.0, author: Automattic, Auto-updates disabled

wp-mu-plugins (1)

10up Plugin Scaffold: version: 0.1.0, author: 10up

wp-plugins-active (1)

Publisher Media Kit: version: 0.1.0, author: 10up, Auto-updates disabled

wp-plugins-inactive (2)

Akismet Anti-Spam: version: 4.1.12, author: Automattic (latest version: 4.2.1), Auto-updates disabled
Hello Dolly: version: 1.7.2, author: Matt Mullenweg, Auto-updates disabled

wp-media

image_editor: WP_Image_Editor_Imagick
imagick_module_version: 1692
imagemagick_version: ImageMagick 6.9.12-19 Q16 x86_64 2021-07-18 https://imagemagick.org
imagick_version: 3.5.1
file_uploads: File uploads is turned off
post_max_size: 150m
upload_max_filesize: 150m
max_effective_size: 150 MB
max_file_uploads: 20
imagick_limits:
imagick::RESOURCETYPE_AREA: 4 GB
imagick::RESOURCETYPE_DISK: 9.2233720368548E+18
imagick::RESOURCETYPE_FILE: 786432
imagick::RESOURCETYPE_MAP: 4 GB
imagick::RESOURCETYPE_MEMORY: 2 GB
imagick::RESOURCETYPE_THREAD: 1
imagemagick_file_formats: 3FR, 3G2, 3GP, AAI, AI, APNG, ART, ARW, AVI, AVS, BGR, BGRA, BGRO, BIE, BMP, BMP2, BMP3, BRF, CAL, CALS, CANVAS, CAPTION, CIN, CIP, CLIP, CMYK, CMYKA, CR2, CR3, CRW, CUR, CUT, DATA, DCM, DCR, DCX, DDS, DFONT, DNG, DOT, DPX, DXT1, DXT5, EPDF, EPI, EPS, EPS2, EPS3, EPSF, EPSI, EPT, EPT2, EPT3, ERF, EXR, FAX, FILE, FITS, FRACTAL, FTP, FTS, G3, G4, GIF, GIF87, GRADIENT, GRAY, GRAYA, GROUP4, GV, H, HALD, HDR, HISTOGRAM, HRZ, HTM, HTML, HTTP, HTTPS, ICB, ICO, ICON, IIQ, INFO, INLINE, IPL, ISOBRL, ISOBRL6, J2C, J2K, JBG, JBIG, JNG, JNX, JP2, JPC, JPE, JPEG, JPG, JPM, JPS, JPT, JSON, K25, KDC, LABEL, M2V, M4V, MAC, MAGICK, MAP, MASK, MAT, MATTE, MEF, MIFF, MKV, MNG, MONO, MOV, MP4, MPC, MPG, MRW, MSL, MSVG, MTV, MVG, NEF, NRW, NULL, ORF, OTB, OTF, PAL, PALM, PAM, PANGO, PATTERN, PBM, PCD, PCDS, PCL, PCT, PCX, PDB, PDF, PDFA, PEF, PES, PFA, PFB, PFM, PGM, PGX, PICON, PICT, PIX, PJPEG, PLASMA, PNG, PNG00, PNG24, PNG32, PNG48, PNG64, PNG8, PNM, POCKETMOD, PPM, PREVIEW, PS, PS2, PS3, PSB, PSD, PTIF, PWP, RADIAL-GRADIENT, RAF, RAS, RAW, RGB, RGBA, RGBO, RGF, RLA, RLE, RMF, RW2, SCR, SCT, SFW, SGI, SHTML, SIX, SIXEL, SPARSE-COLOR, SR2, SRF, STEGANO, SUN, SVG, SVGZ, TEXT, TGA, THUMBNAIL, TIFF, TIFF64, TILE, TIM, TTC, TTF, TXT, UBRL, UBRL6, UIL, UYVY, VDA, VICAR, VID, VIDEO, VIFF, VIPS, VST, WBMP, WEBM, WEBP, WMF, WMV, WMZ, WPG, X, X3F, XBM, XC, XCF, XPM, XPS, XV, XWD, YCbCr, YCbCrA, YUV
gd_version: 2.2.5
gd_formats: GIF, JPEG, PNG, WebP, BMP, XPM
ghostscript_version: not available

wp-server

server_architecture: Linux 5.10.47-linuxkit x86_64
httpd_software: nginx/1.21.1
php_version: 7.3.29 64bit
php_sapi: fpm-fcgi
max_input_variables: 1000
time_limit: 30
memory_limit: 128M
admin_memory_limit: 256M
max_input_time: 60
upload_max_filesize: 150m
php_post_max_size: 150m
curl_version: 7.61.1 OpenSSL/1.1.1g
suhosin: false
imagick_availability: true
pretty_permalinks: true

wp-database

extension: mysqli
server_version: 5.7.35
client_version: mysqlnd 5.0.12-dev - 20150407 - $Id: 7cc7cc96e675f6d72e5cf0f267f48e167c2abb23 $

wp-constants

WP_HOME: undefined
WP_SITEURL: undefined
WP_CONTENT_DIR: /var/www/html/wp-content
WP_PLUGIN_DIR: /var/www/html/wp-content/plugins
WP_MEMORY_LIMIT: 40M
WP_MAX_MEMORY_LIMIT: 256M
WP_DEBUG: false
WP_DEBUG_DISPLAY: true
WP_DEBUG_LOG: false
SCRIPT_DEBUG: false
WP_CACHE: false
CONCATENATE_SCRIPTS: undefined
COMPRESS_SCRIPTS: undefined
COMPRESS_CSS: undefined
WP_LOCAL_DEV: undefined
DB_CHARSET: utf8
DB_COLLATE: undefined

wp-filesystem

wordpress: writable
wp-content: writable
uploads: writable
plugins: writable
themes: writable
mu-plugins: writable
`

Additional context

This issue is for tracking changes for the 1.2.0 release. Target release date: Late June 2022 or Early July 2022.

Pre-release steps

• Make sure the #85 is merged/closed.
• Confirm build commands, ensure GitHub Actions building plugin correctly

Release steps

• Branch: Starting from develop, cut a release branch named release/1.2.0 for your changes.
• Version bump: Bump the version number in package-lock.json, package.json, publisher-media-kit.php, readme.txt, and any other relevant files if it does not already reflect the version being released. Update both the plugin "Version:" property and the plugin PUBLISHER_MEDIA_KIT_VERSION constant in publisher-media-kit.php.
• Changelog: Add/update the changelog in CHANGELOG.md and readme.txt. (Recommendation to use: https://github.com/10up/changelog-generator)
• Props: update the CREDITS.md file with any new contributors, and confirm maintainers are accurate. (Recommendation to use: https://github.com/10up/credits-generator)
• New files: Check to be sure any new files/paths that are unnecessary in the production version are included in .distignore.
• Readme updates: Make any other readme changes as necessary. README.md is geared toward GitHub and readme.txt contains WordPress.org-specific content. The two are slightly different.
• Make sure the release date is added in the CHANGELOG.md.
• Merge: Make a non-fast-forward merge from your release branch to develop (or merge the pull request), then do the same for develop into trunk (git checkout trunk && git merge --no-ff develop). trunk contains the stable development version.
• Push: Push your trunk branch to GitHub (e.g. git push origin trunk).
• Release: Create a new release, naming the tag and the release with the new version number, and targeting the trunk branch. Paste the changelog from CHANGELOG.md into the body of the release and include a link to the closed issues on the milestone.
• SVN: Wait for the GitHub Action to finish deploying to the WordPress.org repository. If all goes well, users with SVN commit access for that plugin will receive an emailed diff of changes.
• Check WordPress.org: Ensure that the changes are live on https://wordpress.org/plugins/publisher-media-kit/. This may take a few minutes.
• Close milestone: Edit the milestone with release date (in the Due date (optional) field) and link to GitHub release (in the Description field), then close the milestone.
• Punt incomplete items: If any open issues or PRs which were milestoned for 1.2.0 do not make it into the release, update their milestone to1.2.0 or Future Release

Is your enhancement related to a problem? Please describe.

The icons should be left aligned in the 'Why you should choose digital' section, currently it is center aligned.
I am using the Twenty Twenty One Theme.

Describe the solution you'd like

The icons should be left aligned by default.

Designs

Additional context

Is your enhancement related to a problem? Please describe.

Update the plugin to use the GH Actions Report summary used in 10up/cypress-wp-utils#63. It's a very nice presentation of the test results.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Describe the bug

This is more of a visual bug.
The instagram followers card is laying outside the vertical wall of the Media Page.

Steps to Reproduce

1. Just open the media page
2. Scroll to the area below the audience profile

Screenshots, screen recording, code snippet

Environment information

• Device MacBook Pro (Retina, 15-inch, Mid 2015)
• OS Mc Os Monterey 12.6.3
• Chrome Version 111.0.5563.110 (Official Build) (x86_64)

WordPress information

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Is your enhancement related to a problem? Please describe.

Cypress 11 has been released, it has a new configuration structure, and the test suite needs to be migrated.

https://docs.cypress.io/guides/references/migration-guide

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Describe the bug

The Orientation Options in the Tabs block are not supported unlike upstream. The Media Kit page design does not contain the Vertical orientation so the option can be removed.

Steps to Reproduce

1. Edit the 'Media Kit' page.
2. Go to the 'Our Rates' tabs section.
3. Try changing the 'Orientation Options'.
4. See it only works for horizontal, not vertical.

Screenshots, screen recording, code snippet

image link

Environment information

No response

WordPress information

Code of Conduct

• I agree to follow this project's Code of Conduct

Is your enhancement related to a problem? Please describe.
Update male/female images to be outline only (currently can be interpreted as % of audience).

Describe the solution you'd like
New images for male/female audience members

Designs

• male icon
• female icon

Describe alternatives you've considered

Additional context

Describe the bug

1. As per style guide/design, every border should be full width after the title. In our developed page border with is narrow.

Expected behavior

2. Would be great if increase spacing between the title and bottom border. Will look better.

Our Page -

Expected Design -

Ps. Please do the same changes for all similar blocks on this page.

Screenshots

Environment information
macOS Monterey, Chrome Latest and 2021 theme.

WordPress information

Additional context

This issue is for tracking changes for the 0.9.0 release to submit to WP.org for initial review / approval of the SVN repo. Target release date: November 2021.

Pre-release steps

• None

Release steps

• Branch: Starting from develop, cut a release branch named release/0.9.0 for your changes.
• Version bump: Bump the version number in package-lock.json, package.json, publisher-media-kit.php, readme.txt, and any other relevant files if it does not already reflect the version being released. Update both the plugin "Version:" property and the plugin PUBLISHER_MEDIA_KIT_VERSION constant in publisher-media-kit.php.
• Changelog: Add/update the changelog in CHANGELOG.md and readme.txt.
• Props: update CREDITS.md file with any new contributors, confirm maintainers are accurate.
• New files: Check to be sure any new files/paths that are unnecessary in the production version are included in .distignore.
• Readme updates: Make any other readme changes as necessary. README.md is geared toward GitHub and readme.txt contains WordPress.org-specific content. The two are slightly different.
• Merge: Make a non-fast-forward merge from your release branch to develop (or merge the pull request), then do the same for develop into trunk (git checkout trunk && git merge --no-ff develop). trunk contains the stable development version.
• Push: Push your trunk branch to GitHub (e.g. git push origin trunk).
• Release: Create a new release, naming the tag and the release with the new version number, and targeting the trunk branch. Paste the changelog from CHANGELOG.md into the body of the release and include a link to the closed issues on the milestone.
• SVN: Wait for the GitHub Action to finish deploying to the WordPress.org repository. If all goes well, users with SVN commit access for that plugin will receive an emailed diff of changes.
• Check WordPress.org: Ensure that the changes are live on https://wordpress.org/plugins/publisher-media-kit/. This may take a few minutes.
• Close milestone: Edit the milestone with release date (in the Due date (optional) field) and link to GitHub release (in the Description field), then close the milestone.
• Punt incomplete items: If any open issues or PRs which were milestoned for 0.9.0 do not make it into the release, update their milestone to1.0.0 or Future Release.

This issue is for tracking changes for the 1.0.0 release. Target release date: December 2021.

Pre-release steps

• Confirm build commands, ensure GitHub Actions building plugin correctly <-- @faisal-alvi investigating

Release steps

• Branch: Starting from develop, cut a release branch named release/1.0.0 for your changes.
• Version bump: Bump the version number in package-lock.json, package.json, publisher-media-kit.php, readme.txt, and any other relevant files if it does not already reflect the version being released. Update both the plugin "Version:" property and the plugin PUBLISHER_MEDIA_KIT_VERSION constant in publisher-media-kit.php.
• Changelog: Add/update the changelog in CHANGELOG.md and readme.txt.
• Props: update CREDITS.md file with any new contributors, confirm maintainers are accurate.
• New files: Check to be sure any new files/paths that are unnecessary in the production version are included in .distignore.
• Readme updates: Make any other readme changes as necessary. README.md is geared toward GitHub and readme.txt contains WordPress.org-specific content. The two are slightly different.
• Merge: Make a non-fast-forward merge from your release branch to develop (or merge the pull request), then do the same for develop into trunk (git checkout trunk && git merge --no-ff develop). trunk contains the stable development version.
• Push: Push your trunk branch to GitHub (e.g. git push origin trunk).
• Release: Create a new release, naming the tag and the release with the new version number, and targeting the trunk branch. Paste the changelog from CHANGELOG.md into the body of the release and include a link to the closed issues on the milestone.
• SVN: Wait for the GitHub Action to finish deploying to the WordPress.org repository. If all goes well, users with SVN commit access for that plugin will receive an emailed diff of changes.
• Check WordPress.org: Ensure that the changes are live on https://wordpress.org/plugins/publisher-media-kit/. This may take a few minutes.
• Close milestone: Edit the milestone with release date (in the Due date (optional) field) and link to GitHub release (in the Description field), then close the milestone.
• Punt incomplete items: If any open issues or PRs which were milestoned for 1.0.0 do not make it into the release, update their milestone to1.1.0 or Future Release.

Is your enhancement related to a problem? Please describe.
Initial details noted here: https://10up.github.io/Open-Source-Best-Practices/testing/
Example implementations: https://github.com/10up/simple-podcasting && https://github.com/10up/restricted-site-access

Describe the solution you'd like

• add Cypress e2e framework into project
• add GitHub Action testing workflow
• add base set of plugin e2e tests

Designs

Describe alternatives you've considered

Additional context

Release steps

• Branch: Starting from develop, cut a release branch named release/1.3.1 for your changes.
• Version bump: Bump the version number in package-lock.json, package.json, publisher-media-kit.php, readme.txt, and any other relevant files if it does not already reflect the version being released. Update both the plugin "Version:" property and the plugin PUBLISHER_MEDIA_KIT_VERSION constant in publisher-media-kit.php.
• Merge/Close #105.
• Merge/Close #115.
• Make sure the open issues/PRs targeted for the 1.3.1 release are closed/merged before proceeding.
• Changelog: Add/update the changelog in CHANGELOG.md and readme.txt. (Recommendation to use: https://github.com/10up/changelog-generator)
• If required, Add a note in the CHANGELOG.md and readme.txt files about the min required versions that are bumped, for example: Note that this release bumps the minimum required version of WordPress from 5.5 to 5.7 and PHP from 7.0 to 7.4.
• Props: update the CREDITS.md file with any new contributors, and confirm maintainers are accurate. (Recommendation to use: https://github.com/10up/credits-generator)
• New files: Check to be sure any new files/paths that are unnecessary in the production version are included in .distignore.
• Readme updates: Make any other readme changes as necessary. README.md is geared toward GitHub and readme.txt contains WordPress.org-specific content. The two are slightly different.
• Make sure the release date is added in the CHANGELOG.md.
• Merge: Make a non-fast-forward merge from your release branch to develop (or merge the pull request), then do the same for develop into trunk (git checkout trunk && git merge --no-ff develop). trunk contains the stable development version.
• Test: Run through common tasks while on trunk to be sure it functions correctly.
• Push: Push your trunk branch to GitHub (e.g. git push origin trunk).
• Test the pre-release ZIP locally by downloading it from the Build release zip action artifact to ensure the plugin doesn't break after release.
• Release: Create a new release, naming the tag and the release with the new version number, and targeting the trunk branch. Paste the changelog from CHANGELOG.md into the body of the release and include a link to the closed issues on the milestone.
• SVN: Wait for the GitHub Action to finish deploying to the WordPress.org repository. If all goes well, users with SVN commit access for that plugin will receive an emailed diff of changes.
• Check WordPress.org: Ensure that the changes are live on https://wordpress.org/plugins/publisher-media-kit/. This may take a few minutes.
• Close milestone: Edit the milestone with release date (in the Due date (optional) field) and link to GitHub release (in the Description field), then close the milestone.
• Punt incomplete items: If any open issues or PRs which were milestoned for 1.3.1 do not make it into the release, update their milestone to 1.3.2 or Future Release.

Is your enhancement related to a problem? Please describe.

There is a small try error in the default content, its written as Sponshorship instead of Sponsorship, in the Our Rates section

Describe the solution you'd like

The typo error needs to be fixed, correct typo should be Sponsorship

Designs

Describe alternatives you've considered

Additional context

Theme Name - Newspack theme (https://github.com/Automattic/newspack-theme)

Bump WP & PHP Minimums to the following

• WordPress to 5.7
• PHP to 7.4
• Remove any no-longer-needed conditional code for older version support.
• Take a look at adjusting our testing matrices, if applicable.
• Bump the minimums in plugin documentation and header fields.

Is your enhancement related to a problem? Please describe.

The components of the page gets squeezed when the sidebar is enabled in the theme.

Describe the solution you'd like

The media kit page should be more responsive and adaptive to various viewports.

Designs

Additional context
Theme - Newspack theme (https://github.com/Automattic/newspack-theme)

Describe the bug
Eslint error occurred while building/watching assets.

Is your enhancement related to a problem? Please describe.
Some publishers may track, report, and provide advertising to more diverse segments than just "male/female". This issue is opened to track feedback from the publisher community on alternate options they would like on their Media Kit page.

Describe the solution you'd like
Please provide feedback in comments here with alternates to male/female that you would like as part of your audience profiles.

Designs

Describe alternatives you've considered

Additional context

Release steps

• Branch: Starting from develop, cut a release branch named release/1.3.0 for your changes.
• Version bump: Bump the version number in package-lock.json, package.json, publisher-media-kit.php, readme.txt, and any other relevant files if it does not already reflect the version being released. Update both the plugin "Version:" property and the plugin PUBLISHER_MEDIA_KIT_VERSION constant in publisher-media-kit.php.
• Changelog: Add/update the changelog in CHANGELOG.md and readme.txt. (Recommendation to use: https://github.com/10up/changelog-generator)
• Props: update the CREDITS.md file with any new contributors, and confirm maintainers are accurate. (Recommendation to use: https://github.com/10up/credits-generator)
• New files: Check to be sure any new files/paths that are unnecessary in the production version are included in .distignore.
• Readme updates: Make any other readme changes as necessary. README.md is geared toward GitHub and readme.txt contains WordPress.org-specific content. The two are slightly different.
• Make sure the release date is added in the CHANGELOG.md.
• Merge: Make a non-fast-forward merge from your release branch to develop (or merge the pull request), then do the same for develop into trunk (git checkout trunk && git merge --no-ff develop). trunk contains the stable development version.
• Test: Run through common tasks while on trunk to be sure it functions correctly.
• Push: Push your trunk branch to GitHub (e.g. git push origin trunk).
• Release: Create a new release, naming the tag and the release with the new version number, and targeting the trunk branch. Paste the changelog from CHANGELOG.md into the body of the release and include a link to the closed issues on the milestone.
• SVN: Wait for the GitHub Action to finish deploying to the WordPress.org repository. If all goes well, users with SVN commit access for that plugin will receive an emailed diff of changes.
• Check WordPress.org: Ensure that the changes are live on https://wordpress.org/plugins/publisher-media-kit/. This may take a few minutes.
• Close milestone: Edit the milestone with release date (in the Due date (optional) field) and link to GitHub release (in the Description field), then close the milestone.
• Punt incomplete items: If any open issues or PRs which were milestoned for 1.3.0 do not make it into the release, update their milestone to 1.4.0 or Future Release.

Is your enhancement related to a problem? Please describe.

While testing another issue, I notice that some of the images could be loselessly compressed and save about 17KB on the page.

This is based on running the images through https://compressor.io/

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Describe the bug

The PHPCS linting action is currently failing due to deprecation errors in the version of the sniffer in use.

This prevents two things:

• warnings about coding standard errors
• merging of approved pull requests by non-admins

Steps to Reproduce

See previous action run.

Screenshots, screen recording, code snippet

No response

Environment information

N/A: GitHub action.

WordPress information

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Describe the bug
Our rates section should be responsive on mobile screen.
mobile viewport - (320*568)

Steps to Reproduce
-Go to Media Kit page

• Scroll down

Expected behavior

• Frontend should be match with design

Screenshots
https://www.screencast.com/t/HxT5mmqgQ

Environment information

Device: MacBook
OS: 12.0.1
Browser and version: Chrome 96.0.4664.55, Safari 15.1
WordPress version: 5.8.2
Theme and version: Twenty Twenty-OneVersion: 1.4 , NewspackVersion: 1.54.0-alpha.1 ,
Newspack JosephVersion: 1.53.2
** Site Helth Info**

Describe the bug
It is noted in #29 that the tabs titles are now no more editable from their own location, however, it is now displaying below the tab! See #29 (comment)

It should be editable from their own location as per the upstream tabs.

image link

Steps to Reproduce

1. Go to PMK Media Kit page.
2. Scroll to "Our Rates" section.
3. See the tab titles are editable from below the tab, unlike upstream.

Expected behavior
The tabs titles from the PMK plugin should be editable like upstream tabs.

Release steps

• Branch: Starting from develop, cut a release branch named release/1.2.1 for your changes.
• Version bump: Bump the version number in package-lock.json, package.json, publisher-media-kit.php, readme.txt, and any other relevant files if it does not already reflect the version being released. Update both the plugin "Version:" property and the plugin PUBLISHER_MEDIA_KIT_VERSION constant in publisher-media-kit.php.
• Changelog: Add/update the changelog in CHANGELOG.md and readme.txt. (Recommendation to use: https://github.com/10up/changelog-generator)
• Props: update the CREDITS.md file with any new contributors, and confirm maintainers are accurate. (Recommendation to use: https://github.com/10up/credits-generator)
• New files: Check to be sure any new files/paths that are unnecessary in the production version are included in .distignore.
• Readme updates: Make any other readme changes as necessary. README.md is geared toward GitHub and readme.txt contains WordPress.org-specific content. The two are slightly different.
• Make sure the release date is added in the CHANGELOG.md.
• Merge: Make a non-fast-forward merge from your release branch to develop (or merge the pull request), then do the same for develop into trunk (git checkout trunk && git merge --no-ff develop). trunk contains the stable development version.
• Push: Push your trunk branch to GitHub (e.g. git push origin trunk).
• Release: Create a new release, naming the tag and the release with the new version number, and targeting the trunk branch. Paste the changelog from CHANGELOG.md into the body of the release and include a link to the closed issues on the milestone.
• SVN: Wait for the GitHub Action to finish deploying to the WordPress.org repository. If all goes well, users with SVN commit access for that plugin will receive an emailed diff of changes.
• Check WordPress.org: Ensure that the changes are live on https://wordpress.org/plugins/publisher-media-kit/. This may take a few minutes.
• Close milestone: Edit the milestone with release date (in the Due date (optional) field) and link to GitHub release (in the Description field), then close the milestone.
• Punt incomplete items: If any open issues or PRs which were milestoned for 1.2.1 do not make it into the release, update their milestone to1.3.0 or Future Release

Describe the bug

The update for images from /assets to /dist (due to a change in patterns?) has resulted in broken images for all plugin users who updated to the latest release. It seems the only way to fix this is by re-inserting the block patterns fresh and starting over with that block. But there are too many sites utilizing this plugin to explain that process for fixing 😅

Steps to Reproduce

1. Update to the latest version of the plugin
2. Go to the page editor for the Media Kit
3. You'll see broken links where images should be (see screenshots)
4. Preview the page and you'll see broken links on the frontend

Screenshots, screen recording, code snippet

Environment information

No response

WordPress information

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Describe the bug

As reported on WordPress.org, if a WordPress install is set up in a subdirectory, the images don't work. The issue here is we have hardcoded image paths that point directly to /wp-content. If a site is installed in a subdirectory, this results in images not working because the subdirectory path isn't added to those images.

Steps to Reproduce

1. Set up a new WordPress site in a subdirectory
2. Install and activate this plugin
3. Check the Media Kit page and see broken images

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

Is your enhancement related to a problem? Please describe.
Update the tabs and content within tabs for the Digital Ad Specs and Our Rates sections with content from this Google Doc.

Describe the solution you'd like

Designs

Describe alternatives you've considered

Additional context

Describe the bug
Our packages section should be responsive on mobile screen.
mobile viewport - (320*568)

Steps to Reproduce
-Go to Media Kit page

• Scroll down

Expected behavior

• Frontend should be match with design

Screenshots
https://www.screencast.com/t/nY73anok7Wwb

Environment information

Device: MacBook
OS: 12.0.1
Browser and version: Chrome 96.0.4664.55, Safari 15.1
WordPress version: 5.8.2
Theme and version: Twenty Twenty-OneVersion: 1.4 , NewspackVersion: 1.54.0-alpha.1 ,
Newspack JosephVersion: 1.53.2
** Site Helth Info**

Describe the bug
For a great user experience, Gutenberg Block Editor should not be horizontally scrollable.

Steps to Reproduce
Edit 'Media Kit' page in BE

Expected behaviour
Gutenberg Block Editor should not be horizontally scrollable.

Screenshots

Describe the bug

I am getting a console error on the media-kit page. The error says Uncaught ReferenceError: wp is not defined in editor.js line no 56.

Steps to Reproduce

1. Install and activate any theme I tried install the https://wordpress.org/themes/twentytwentyone/ theme
2. Install and activate the https://github.com/10up/publisher-media-kit/ plugin
3. Visit the media-kit page in the Front End
4. Open Console tab to view the error.

Expected behavior

There should be no errors and warnings in the console tab.

Screenshots

Environment information

• Device: MacBook
• OS: MacOS 11.6
• Browser and version: Chrome 94.0.4606.61
• WordPress version: 5.8.1

Additional context

Is your enhancement related to a problem? Please describe.

Describe the solution you'd like

• test WP New Relic on WordPress 5.9
• open issues for any incompatibilities noted in testing
• resolve issues identified in testing
• bump "tested up to" version
• if code changes needed due to incompatibilities, ship a plugin release, otherwise use "Plugin asset/readme update" action to update "tested up to" version on .org repo

Designs
n/a

Describe alternatives you've considered
None

Additional context

Is your enhancement related to a problem? Please describe.
Once WordPress 6.0 is released, we'll want to test Publisher Media Kit to see if any incompatibility issues arise.

Describe the solution you'd like

• test Publisher Media Kit on WordPress 6.0
• open issues for any incompatibilities noted in testing
• resolve issues identified in testing
• bump "tested up to" version
• if code changes needed due to incompatibilities, ship a plugin release, otherwise use "Plugin asset/readme update" action to update "tested up to" version on .org repo

Designs
n/a

Describe alternatives you've considered
none

Additional context
Related: #56