Only apply redirects on 404 about safe-redirect-manager HOT 7 CLOSED

Only thing tricky about this is that we are doing redirects on parse_request where at the time 404 flags have not been set. Can we move redirection to a different action?

from safe-redirect-manager.

Only thing tricky about this is that we are doing redirects on parse_request where at the time 404 flags have not been set.

I was thinking it could be an opt-in behavior because...

Can we move redirection to a different action?

Moving redirection to a different action by default will cause more of WordPress to load (and decrease performance).

from safe-redirect-manager.

I don't understand what you mean by opt-in behavior. We are doing redirects before WP checks if a 404 occurs.

from safe-redirect-manager.

Right, so opt in to waiting until after the 404 occurs.

On Oct 31, 2013, at 17:52, Taylor Lovett [email protected] wrote:

I don't understand what you mean by opt-in behavior. We are doing redirects before WP checks if a 404 occurs.

—
Reply to this email directly or view it on GitHub.

from safe-redirect-manager.

I see. I wish we could find a better way to handle this rather than moving the redirect to a new action. I'd merge a pull request though.

from safe-redirect-manager.

Two PR's, one setting 404 option as the filter, the other setting it as default.

Personally, I'd like to see this behavior as default. It'd remove redirect processing from occurring on every page load, causing a slight performance increase site-wide. The additional processing of getting to template_redirect for a redirect should be negligible from a user's perspective.

from safe-redirect-manager.

Just occurred to me after all that... A better approach may be to switch redirect detection to use rewrite rules. See #24.

from safe-redirect-manager.