Could you please include srm_check_for_possible_redirect_loops in the GitHub README.md?

It would be nice to check the target whether it is an existing permalink.

I was using this plugin on a project with ~250 redirects. I wrote an import script that made use of the create_redirect method to generate the redirects. After creating the redirects, the WordPress backend was "frozen". It seemed as though something was caught in an infinite loop.

After some searching I realized the problem was the check_for_possible_redirect_loops(). This method checks each redirect against every other redirect meaning it runs in Theta( n^2 ) time where n is the number of redirects. With 250 redirects, the contents of the loop in that function will be executed over 62,000 times.

Proposal: Add another filter "max_redirects_to_check_for_loops" or something to that effect. It should default to 50.

It would be super useful to me if this plugin could handle redirecting http to https for certain URL's. Thoughts on this @danielbachhuber ?

This is a feature of the Redirection plugin.
It could be tied to a define().

Could we have a link to the rule list in the Redirect rule updated/published. notice?

Could there be a notification if I create a new post and its URL is already redirected?

For instance, if my request is:

http://daniel.local/apple/mac/

$current_request->request would be:

apple/mac

This means that if my redirect_to is a wildcard (see #13), my new request is missing a trailingslash. WordPress will redirect again to trailingslashit

@tlovett1 is there a particular reason you chose $current_request->request to begin with, or can we use $_SERVER['REQUEST_URI'] instead?

In wp-admin/includes/class-wp-posts-list-table.php:209

protected function get_bulk_actions() {
$post_type_obj = get_post_type_object( $this->screen->post_type );
...
209: $post_type_obj->cap->delete_posts

the defined redirects are not cleaned between assertion, so for a similar tests it can happen that if one is failing it will actually pass the assertion because a previously defined redirect does the job instead

Building off #31, it would be nice to have full wp-cli support with the following subcommands:

• create
• delete
• list
• clear-cache

I'll take a swing at this over the next couple of weeks

Currently, check_for_possible_redirect_loops() compares each redirect to every other redirect twice.

We should be able to do something like this to improve efficiency.

for ( $i = 0; $i < count( $redirects ); $i++ ) {
    for ( $j = $i + 1; $j < count( $redirects ); $j++ ) {
        // compare $redirects[$i] to $redirects[$j]
    }
}

If we're checking each redirect against itself when it is originally created, the inner loop can be $j = $i + 1, otherwise it needs to be $j = $i.

I noticed that the most recent release tagged was before composer.json was added; this means that a Composer installation that requires stable won't succeed in installation (I believe).

Request a bump to include that support and other recent commits. :)

Please can you insert a export rules created feature so i can import rules created in a new wordpress installation?
thanks

I was using the plugin today on a huge site. We wanted to insert 11,000+ redirects. This resulted an exceeded memory limit fatal error.

The plugin caches all the published redirects in a transient. Then on each page request, the current page is checked against every redirect in the transient. This results in worst case performance O( n ). I think we can definitely do this better.

This plugin needs unit tests. Go!

Some caching systems need a URL to clear a cache at their URL, for example a Varnish of Nginx based caching system. If the Safe Redirect Manager returned the "from" URL (where possible, i.e. where no regex is enabled) then this would enable some cache clearance operations.

Would you accept a pull request to implement a filter on filter_post_type_link to return the "from" URL from get_permalink.

Here's the commit in my fork to do this: simonwheatley@cba5a71

An example of this issue is the Varnish caching setup in WP Engine, where 404s are cached for a long length of time. Occasionally the solution to a 404 with a lot of incoming links is to create a redirect. Creating the redirect_rule post does not trigger a cache clearance, because WP Engine cannot get the URL to clear the cache on.

https://wordpress.org/plugins/safe-redirect-manager/

Generate a POT file and add it to a /languages/ folder

Hi,

Would love to have an option like this on my edit screens for post/pages/custom post types:

In 0b70935, some extra logic was added to deal with slashes that resulted in a $unslashed_requested_path used to match $redirect_from. By default, $redirect_from and $requested_path go through a strtolower() for case insensitive redirects. Because $unslashed_requested_path is not touched in this block, a mixed case URL request will not match.

Related .org support post - http://wordpress.org/support/topic/redirects-with-upper-case-not-working

The function should be called with the proper arguments.

I created a redirect from "/" to "http://apple.com/" and hit publish. The "/" was dropped from the "Redirect From" field but the plugin told me the redirect was published.

Also, the title ended up as "Auto Draft" (viewable from the Manage Redirects view), and I see warnings like this:

[23-Aug-2012 18:12:50 UTC] PHP Warning: Missing argument 2 for SRM_Safe_Redirect_Manager::filter_admin_title() in /Users/danielbachhuber/wp/wp-content/plugins/safe-redirect-manager/safe-redirect-manager.php on line 132

I inherited a blog that was using this plugin and it continues to redirect the home page even after I have removed the plugin. Anything special I need to do to completely remove redirects?

check_for_possible_redirect_loops() is kind of slow. We could add simple loop detection that runs in constant time by checking each redirect individually when it is created. It won't be as comprehensive, but will protect against the most blatant redirect loops.

We should block:

• any rule that redirects to itself
• any rule that redirects all traffic to the current site

Example of the second:

/(.*) -> /$1/

Redirecting ALL traffic to the same site will always be a loop.

Howdy,

I took a look at your plugin this morning. It's pretty neat! I think a lot of VIPs will enjoy using it. Here's some feedback I had:

Code level feedback:

• When we originally suggested using a custom post type, the recommendation was to store all of the redirects in one post, instead of creating a post for each redirect. Having seen your implementation, doing it the way you've done could lead to interesting features (like being able to schedule a redirect). I might remove the visibility option though, and just have a draft or published status
• Should action_redirect_chain_alert() run on every admin request, or just in the context of the plugin? If you're doing a massive get_posts() on every admin page load, probably best to just do it in the context of the plugin
• Similarly, you should create a WP_Query() object instead of using get_posts() so you can limit your query to just posts and postmeta (no taxonomy lookup) and benefit from the built-in caching on wpcom
• There's some spaces that slipped into your indentation
• It would be nice to have a filter where one could limit the number of redirects that can be created.

Aesthetic feedback:

• I'd make this a submenu under tools, as top-level menus should generally be saved for collections of functionality
• When creating a new redirect rule, it might be nice to use the placeholder attribute on the input fields to suggest the format the redirects should be added in.
• I'm not sure "author" is a relevant column. You can probably remove it.
• When I created a '/apple/' redirect to 'http://apple.com/', searching for 'Apple' produced no results. Searching your redirects by the from and to values would be pretty useful.
• Similarly, make sure your bulk actions and quick edit are relevant… I think they could probably be removed.
• I'd make the page title for managing all redirects "Safe Redirect Manager" and use your icon as the page icon

Hope this helps! I figured I'd give this to you all as one issue, and you can break it into separate issues as you need. None of these are blockers, but improvements we'd love to see before deploying. Let me know what you think.

But do it right before release.

It would be neat to be able to enable, via a filter, the ability to only apply redirects if the current page is 404ed. This would be useful when SRM is being used to handle redirects from old post slugs to new post slugs.

I think we should have a README.md file rather than showing readme.txt. I'd like the new readme to run through configuring the plugin and adding a few redirects. This is an awesome plugin; it's a shame the documentation is so poor.

I guess I found a possible bug in the plugin.

Here there is a URL giving me 404:

https://inglesnarede.com.br/dicas-de-ingles/4-maneiras-de-chamar-alguem-de-“pao-duro”-em-ingles/

There is the (") in the url... After changing the url in the Safe Redirect Manager for a new one, the url above is not redirected. I also tried checking the regular expressions checkbox with no success.

My guess is the plugin is not checking if the url has accentuation. And if it is checking, it is not being able to redirect it.

I want to be able to add a redirect for /icecream and have any cased variation of it to work (/ICECREAM or /iCeCrEaM).

It would be nice to have a "Test" quick action for each redirect so you could actually test the redirect.

It doesn't appear that wildcard redirects are working, as I am still getting Page Not Found errors when viewing the old URL.

In the Redirect URL field I have: /gallery/before-after/*
and in the Redirect To: /gallery/ (and also /gallery/*)

However when I still try to visit the URL http://www.bellavou.co.uk/gallery/before-after?pid=2522, I'm still shown a Page not found message, and it doesn't seem as though the redirect is working at all.

I have several other redirects that do not use wildcards, and these seem to work fine.

Request from the forums: http://wordpress.org/support/topic/plugin-safe-redirect-manager-regex?replies=1

Currently indentation is done with spaces in main plugin files, tabs in tests and wpcli command

It would be great if I could easily redirect all requests to /blog/* (or any URI pattern with a wildcard) to a new URL or URI pattern.

An idea for the plugin, maybe I'll create a PR in the coming days.

When you already have several redirections created but they are with the "wrong" HTTP Status Code, you have to manually to change them.

I suggest adding a quick edit and also a bulk edit to the plugin to make it easier to edit in bulk several redirections at once.

If there isn't yet a $post object on the page, the code won't be executed. This is problematic, for instance, when adding the page icon.

If site_url() does not have a path, it is possible that parse_url returns an array without a path key set. This causes an error when checking for its value.

Being able to setup and then export rewrite rules to an .htaccess format would be wonderful.

When you try to redirect from a file past the root level (for example, /files/whatever.pdf) it doesn't trigger the rewrite rule to the destination page/file.

To replicate

• Create a new redirect rule
• In the "from" field add something like /files/myfiles/whatever.pdf)
• Select another url as the destination (I picked something in my uploads directory like /wp-content/uploads/2014/08/my-new-file.pdf)
• Save the redirect rule
• Visit the url (http://example.org/files/myfiles/whatever.pdf); observe a server-level 404 response

I saw this one on the support forums. I think this would be pretty useful.

If you create a redirect from path "/", it will match every path because of some new wildcard code.

Example:

Redirect_from: /(.+)/test
Redirect_to: /$1/live
Requested path: /home/test

This should redirect to /home/live.

Title pretty much says it all. We are checking if false === ( $var = get_post() ). This won't work if get_post returns null.

It would be nice to have a custom WP_Importer implementation (Tools > Import) for bulk-importing redirects via CSV. The import_file() method would be responsible for most of the logic, but this would allow sites with limited/no WP-CLI access to import sites without involving their hosts.

This plugin doesn't seem to work to redirect the front page of a site. I tried today to redirect all of the pages on an old unused site on one domain, to similar pages on a newly updated site, and found that the front page wouldn't redirect.

Everything else redirected just fine, and I like this plugin a lot. Here's hoping I'm just missing something.

Revisions are useful to see when and who made changes to a redirection - especially if the change causes problems.

We can also limit the number of revisions using wp_revisions_to_keep if there is concern around storing too many.

Not having the ability to bulk delete is pretty annoying when dealing with a large amount of redirects.