bonk2021's Issues
Some feedback, questions and notes captured in an issue.
Some feedback now that I have had a chance to look deeper.
You had asked about removing the main class.
I think we should stick with keeping Main.java and the standard.
I see no technical advantages but certainly could add to possible confusion.
I would recommend heeding the warnings in the wpilib docs to not touch main.
What is the advantage to initializing RobotContainer and OI in the Robot constructor instead of robotInit?
You may consider reverting to the WPILIB recommendations on structure.
We don't want to hit any conflicts with the FMS during the competition or cause confusion if new members of the team
copy this project for future projects.
Are these configs correct? They seem reversed.
- rightConfig = ()->driveLeftMotor2;
- leftConfig = ()->driveRightMotor1
You were asking about where to put default commands.
- Some of the examples put them in RobotContainer: https://github.com/wpilibsuite/allwpilib/blob/192d251ee800cefbb60340ff2e33329a3333a724/wpilibjExamples/src/main/java/edu/wpi/first/wpilibj/examples/ramsetecommand/RobotContainer.java
- Heron appears to have put them in OI which probably makes sense for us since that is where we bind the commands.
https://github.com/robototes/InfiniteRecharge2020/blob/8c60b81e06921618e6f2c42bfe830c64fab934a7/src/main/java/frc/team2412/robot/OI.java
Have you confirmed all the hardcoded values (like track width and wheel size) in drive base subsystem?
https://github.com/1198159/Bonk2021/blob/88af49f5914aae80504b55152780b514588fd6f9/src/main/java/frc/team2412/robot/subsystems/DrivebaseSubsystem.java
Should there be any limits on the VictorySpinCommand?
Did you try your code on the simulator? Seems like the ideal use of the simulator since it is just the drive base.
What is the plan for autonomous mode?
Does the drivebasesubsystem have all the methods it needs to setup and follow trajectories?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.