Comments (22)
To recap the story of TLC’s pa11y work that came out of this issue:
- This issue was incorporated into this TLC issue to explore any and all ways to make pa11y faster (without proposing a solution)
- Here is the old proposed ADR for looking into above issue
- Discussion from that led to a new issue for looking into pa11y alternatives
In the interest of keeping the underlying problem ("pa11y runs are too slow") top of mind, I'm going to remove this issue from Blocked, but replace it with the issue in no 3 (TLC Crew 501) in the Blocked column.
from 18f.gsa.gov.
Per our discussion at TLC Planning on 12/11/23, let's try this:
- Adjust the
pa11y-limited
npm script to scan appropriate pages for each Pull Request. (Will be up to the developer to determine pa11y-ci's capabilities here in terms of what sub-set of pages can be reasonably scanned.) - Use
pa11y-limited
script for pull request CI pipeline - Find a way to run the complete scan on some decided-upon schedule (once a week, once a month, etc) outside of the git workflow, and notify a maintainer of any errors.
from 18f.gsa.gov.
For bullet point 3 above, as an example, Tock also runs a job on a daily schedule. Feel free to reuse the Tock configuration. As for notifications, we do an audit every week which lets us catch CI errors, but that probably won't work for TLC.
from 18f.gsa.gov.
Path forward for this ticket may be determined by outcome of TLC-crew #474
from 18f.gsa.gov.
Working on an ADR to search for tools to address this
from 18f.gsa.gov.
Issue that blocks this work is here!
from 18f.gsa.gov.
Thanks @echappen! Can you link to the ADR as well? And then I think we decided we could move this one to done as the ticket names a specific solution. Let me know if you disagree or think the content of the ticket should be captured in the other ticket.
from 18f.gsa.gov.
Actually, I think the easiest thing would be to do what John suggested: keep this issue in Blocked, update the title to "Pa11y runs are too slow" and remove the proposed solution (or at least downgrade it as one option to explore, of many). @alexsoble as the original poster, can you make those changes?
from 18f.gsa.gov.
Tagged the wrong Alex—should be @alexsobledotgov
from 18f.gsa.gov.
@echappen Yep! updated the title, created a "problem" section and a list with a few potential solutions. Good suggestion/catch here @jskinne3 !
from 18f.gsa.gov.
Let's investigate these CI slowdowns and see if we have a quick fix here. I think we should put someone on this issue so we can at least figure out better paths forward since we are probably sticking with pa11y for the immediate future. We should probably timebox the investigation too.
from 18f.gsa.gov.
Related Issues (20)
- Featured post cards: focus state
- Add automation to add opened issues to Delivery Assurance board
- Test issue HOT 1
- BUG -- feature template adds a type:bug label to the issue.
- Add the 18F Delivery Assurance team as an admin HOT 1
- Update dependencies to run on modern hardware HOT 1
- Some anchor elements have empty href attributes HOT 4
- BUG: Width for some blog posts HOT 5
- Open source policy page links to different license file
- Test issue
- Investigate removing 18F style guide HOT 7
- Upgrade Dockerfile and Docker-Compose files to newer versions
- 18f site style guide page—footer displaying over the content HOT 1
- Pull quotes not showing on blog HOT 1
- BUG: Partnership principles page is misaligned
- BUG: pa11y scans failing on site HOT 1
- BUG Social link in the footer opening in the same tab HOT 3
- Prevent pa11y from silently failing in CI
- Have Github automatically delete merged branches HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 18f.gsa.gov.