Giter VIP home page Giter VIP logo

Comments (22)

echappen avatar echappen commented on August 22, 2024 2

To recap the story of TLC’s pa11y work that came out of this issue:

  1. This issue was incorporated into this TLC issue to explore any and all ways to make pa11y faster (without proposing a solution)
  2. Here is the old proposed ADR for looking into above issue
  3. Discussion from that led to a new issue for looking into pa11y alternatives

In the interest of keeping the underlying problem ("pa11y runs are too slow") top of mind, I'm going to remove this issue from Blocked, but replace it with the issue in no 3 (TLC Crew 501) in the Blocked column.

from 18f.gsa.gov.

echappen avatar echappen commented on August 22, 2024 1

Per our discussion at TLC Planning on 12/11/23, let's try this:

  1. Adjust the pa11y-limited npm script to scan appropriate pages for each Pull Request. (Will be up to the developer to determine pa11y-ci's capabilities here in terms of what sub-set of pages can be reasonably scanned.)
  2. Use pa11y-limited script for pull request CI pipeline
  3. Find a way to run the complete scan on some decided-upon schedule (once a week, once a month, etc) outside of the git workflow, and notify a maintainer of any errors.

from 18f.gsa.gov.

cantsin avatar cantsin commented on August 22, 2024 1

For bullet point 3 above, as an example, Tock also runs a job on a daily schedule. Feel free to reuse the Tock configuration. As for notifications, we do an audit every week which lets us catch CI errors, but that probably won't work for TLC.

from 18f.gsa.gov.

echappen avatar echappen commented on August 22, 2024

Path forward for this ticket may be determined by outcome of TLC-crew #474

from 18f.gsa.gov.

juliaklindpaintner avatar juliaklindpaintner commented on August 22, 2024

Working on an ADR to search for tools to address this

from 18f.gsa.gov.

echappen avatar echappen commented on August 22, 2024

Issue that blocks this work is here!

from 18f.gsa.gov.

juliaklindpaintner avatar juliaklindpaintner commented on August 22, 2024

Thanks @echappen! Can you link to the ADR as well? And then I think we decided we could move this one to done as the ticket names a specific solution. Let me know if you disagree or think the content of the ticket should be captured in the other ticket.

from 18f.gsa.gov.

echappen avatar echappen commented on August 22, 2024

Actually, I think the easiest thing would be to do what John suggested: keep this issue in Blocked, update the title to "Pa11y runs are too slow" and remove the proposed solution (or at least downgrade it as one option to explore, of many). @alexsoble as the original poster, can you make those changes?

from 18f.gsa.gov.

echappen avatar echappen commented on August 22, 2024

Tagged the wrong Alex—should be @alexsobledotgov

from 18f.gsa.gov.

alexsobledotgov avatar alexsobledotgov commented on August 22, 2024

@echappen Yep! updated the title, created a "problem" section and a list with a few potential solutions. Good suggestion/catch here @jskinne3 !

from 18f.gsa.gov.

cantsin avatar cantsin commented on August 22, 2024

Let's investigate these CI slowdowns and see if we have a quick fix here. I think we should put someone on this issue so we can at least figure out better paths forward since we are probably sticking with pa11y for the immediate future. We should probably timebox the investigation too.

from 18f.gsa.gov.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.