1forge / javascript-forex-quotes Goto Github PK

Issue:
The main property of the package.json is not set to the correct entry point. So, we can't require properly the module forex-quotes.

Expected behavior:
import ForgeClient from 'forex-quotes';

Workaround:
import ForgeClient from 'forex-quotes/lib/src/ForgeClient';

Version tested:
6.0.0

Error: Cannot find module 'ws'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:690:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/home/jarrieta/Desktop/personal/channel/node_modules/forex-quotes/lib/SocketClient.js:3:17)
    at Module._compile (internal/modules/cjs/loader.js:776:30)
    at Module._compile (/home/jarrieta/Desktop/personal/channel/node_modules/pirates/lib/index.js:99:24)
    at Module._extensions..js (internal/modules/cjs/loader.js:787:10)
    at Object.newLoader [as .js] (/home/jarrieta/Desktop/personal/channel/node_modules/pirates/lib/index.js:104:7)
    at Module.load (internal/modules/cjs/loader.js:653:32)

Version 4.0.1 works fine.

In SocketClient.js file
Please comment console.log : line number: 46

Please add price in this
export interface Quote {
bid: number;
ask: number;
float: number;
symbol: string;
timestamp: number;
}
also fix this

ERROR in node_modules/forex-quotes/lib/ForgeClient.d.ts(45,25): error TS1005: '>' expected. node_modules/forex-quotes/lib/ForgeClient.d.ts(45,32): error TS1003: Identifier expected. node_modules/forex-quotes/lib/ForgeClient.d.ts(45,47): error TS1144: '{' or ';' expected. node_modules/forex-quotes/lib/ForgeClient.d.ts(45,53): error TS1005: '=' expected. node_modules/forex-quotes/lib/ForgeClient.d.ts(45,54): error TS1109: Expression expected. node_modules/forex-quotes/lib/ForgeClient.d.ts(46,22): error TS1005: '>' expected. node_modules/forex-quotes/lib/ForgeClient.d.ts(46,29): error TS1003: Identifier expected. node_modules/forex-quotes/lib/ForgeClient.d.ts(46,44): error TS1144: '{' or ';' expected. node_modules/forex-quotes/lib/ForgeClient.d.ts(46,50): error TS1005: '=' expected. node_modules/forex-quotes/lib/ForgeClient.d.ts(46,51): error TS1109: Expression expected.

Websocket client always disconnected at 9:00PM GMT, so I have to connect again.
Is this an intended behavior?
If it is, I think you should add it to your document.