1inch-docs's People
Forkers
olli1409 anatolyger chrisdipiero r4vp4 lzc1726 adriankliks1 utone vic23m dadadem ariphul suchat932 noneshen xx102510 samegod11 leechunhao2000 alirun friday-james jasoncoker925 ramizemmar taday44 csk7777777 ojuwonjireh tacoo hsghnr y9san9 tuanggolt qubasecrypto hunterr27 saeidahbub atandanny y70333603 aasszzx707 belactriple9 ramos181422 zverwinda72 richardatct rue29 summerkinger badboiz0147 sevoya ubinatus jonnyboy1992 nannasylvest2208 lesteryehgood ruyeduardo omahs naiba4 fais5012 roodeag tamtura75 0xsidd hoanglamcoin bunsdev hsghn abhishekdeshwal11 shahidaleem tor-por muniz-colima mansourmurad7 babayevaterane issavejdani ta77130 capp46hdjju hani1obaid 0791471589 omarelweshy ptws21 pankajjagtapp azoozzooz12 selikal githuberart coderguy1998 haleemshal miami87 0xbaer gezegorz1 sincerelyv10 saberhabeelshohdy znratbou78 bitcoin399 joshhavana doonkelly1991 saviour1001 aexmuxomor cryptographite nnectar orisdorch zodenode bigdawg001 ahmadkhan345 marsrobertson obchakevich setland34 moneybenn-online hoseyntm jesuschristiamgod ratthakorn250999 ys7i ridoikeu prowebza1inch-docs's Issues
0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2
Setland7
Murad
Fix typos
Issue when trying to create limit order using python sample on chain 56 (BSC)
Good afternoon,
Many thanks for adding a python example on how to create a limit order !
(At the end of https://github.com/1inch/1inch-docs/blob/master/docs/limit-order-protocol/guide/create-limit-order.md)
I tested it on chain 1 and it worked great. Nevertheless when trying to change it to chain 56 (BSC), I'm getting a "{"statusCode":400,"message":"order is invalid with reason: cannot decode allowance","error":"Bad Request"}"
I did check that :
- MakerAsset was approved with enough allowance (using https://balances.1inch.io/v1.1/56/allowancesAndBalances/0x1e38Eff998DF9d3669E32f4ff400031385Bf6362/0xCaF683091Ad1C6a1a661FEf67541453112293890?tokensFetchType=baseTokens)
- Wallet had enough of MakerAsset
- Correctly changed limit_order_contract to its chain 56 equivalent (0x1e38Eff998DF9d3669E32f4ff400031385Bf6362)
- Also changed the verifyingContract in the EIP712_data to 0x1e38Eff998DF9d3669E32f4ff400031385Bf6362 and chainId to 56. Is that correct ?
My test case:
chain_id 56
limit_order_contract 0x1e38Eff998DF9d3669E32f4ff400031385Bf6362
WalletAddress 0xCaF683091Ad1C6a1a661FEf67541453112293890
makerAsset 0xbb4CdB9CBd36B01bD1cBaEBF2De08d9173bc095c (WBNB)
takerAsset 0x55d398326f99059fF775485246999027B3197955 (USDT)
makingAmount "100000000"
takingAmount "27500000000"
It would be awsome if you could help me spot what I'm doing wrong or give a bit more details about what this error message is for.
Many thanks & awsome work !
Update 1 Inc
wrong uint of the description of the skipPermitAndThresholdAmount
the original text is
skipPermit is just 255'th byte of skipPermitAndThresholdAmount, when rest of bytes is thresholdAmount
See fillLimitOrder(), fillOrderToWithPermit() and packSkipPermitAndThresholdAmount() utils methods and helpers.
but I consider that the right texts are
skipPermit is just 255'th bit of skipPermitAndThresholdAmount, when rest of bytes is thresholdAmount
See fillLimitOrder(), fillOrderToWithPermit() and packSkipPermitAndThresholdAmount() utils methods and helpers.
convert the 'byte' to 'bit'
- [ ] [](url)
- [ ] [](url)
Originally posted by @Tasukutast in #225 (comment)
Cann't use api fetch quote when protocols is CLIPPER,PMM6
https://api.1inch.io/v4.0/1/quote?fromTokenAddress=0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2&toTokenAddress=0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48&amount=12346000000000000&protocols=CLIPPER,PMM6
{
statusCode: 500,
error: "Internal Server Error",
description: "Internal Server Error",
meta: [ ],
requestId: "c1835f2f-8fdc-4b69-91e7-9980e3db69cf"
}
[![CLA assistant check](https://cla.opensource.tencent.com/pull/badge/not_signed)](https://cla.opensource.tencent.com/Tencent/vConsole?pullRequest=581) <br/>Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla.opensource.tencent.com/Tencent/vConsole?pullRequest=581) before we can accept your contribution.<br/><sub>You have signed the CLA already but the status is still pending? Let us [recheck](https://cla.opensource.tencent.com/check/Tencent/vConsole?pullRequest=581) it.</sub>
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Originally posted by @tencent-adm in Tencent/vConsole#581 (comment)
HMAC_SHA256
HMAC_SHA256
Originally posted by @Hani1obaid in Uniswap/tokenlists-org#1788 (comment)
Originally posted by @Hani1obaid in 0xProject/0x-protocol-specification#58
Broken link in the docs - some routing issue
https://docs.1inch.io/docs/limit-order-protocol/utils/about/
Short video illustrating issue: https://youtu.be/qVVzBHXU5sU
Probably related to React routing.
Broken payments link needs fix
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.