Giter VIP home page Giter VIP logo

default-hub-homepage's People

Contributors

choldgraf avatar consideratio avatar dsludwig avatar georgianaelena avatar jacobtomlinson avatar rabernat avatar yuvipanda avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar

default-hub-homepage's Issues

jupyterhub_config.py should include inline comment its not loaded in production - only for testing

Is it correct that a 2i2c deployed jupyterhub won't load the jupyterhub_config.py file in this repo, and that its only around in order to help users test how things look locally as mentioned in the README?

I think so, but I'm not sure. If that is the case, we should make sure to inline comments about that in the jupyterhub_config.py, and clarify that such config needs to be passed via the 2i2c chart config directly.

Allow multiple funders to be listed on a hub homepage

Context

We have a field where we can provide the name and link of a funder that provides financial support for a hub. However, some communities may have funding from multiple sources that they may wish to acknowledge, e.g.:

Proposal

I propose we move from the current config that only allows us to list a single funder, to a config that would allow us to list multiple

Current config example:

funded_by:
  name: Funder 1
  url: https://www.funder1.org/

Proposed config example (make funded_by an array type):

funded_by:
  - name: Funder 1
    url: https://www.funder1.org/
  - name: Funder 2
    url: https://funder2.com

Updates and actions

  • There will need to be some exploration on how to best display multiple funders in terms of the HTML

Repo management update

Context

I see this was forked originally from https://github.com/utoronto-2i2c/homepage (which is now archived). Should remove the fork so it is clear that this repo lives independently from that historical repo?

Also, there is both a main and a master branch -- we should prune one of them for clarity.

Proposal

No response

Updates and actions

No response

Add inline notes to jupyterhub_config.py to reflect its purpose

I saw this repo and wasn't sure how things worked, and remain unsure. Is jupyterhub_config.py just used for local development, or is it also used by 2i2c's infrastructure cloning this repo somehow?

This is a question relating to 2i2c-org/infrastructure#1501 as finding the jupyterhub_config.py made me think maybe this is a way for hub champions to configure various template vars themselves or similar, at the same time, I think maybe it isn't as I recall seeing this kind of configuration in 2i2c-org/infrastructure for the specific hubs.

My understanding now is that jupyterhub_config.py is just for local testing purposes, but its unclear and it would be valuable to have that clearly noted in this repo. Both in README.md and the jupyterhub_config.py file itself.

Why doesn't this repo show up when I search the org for it?

Context

I've tried multiple search terms in our org to get this repo to show up. It never does and I either have to scrape our basehub values files looking for the right URL or ask someone "where do we configure our hub homepages from?" What is up with that?

Some demo searches providing zero results:

Screenshot 2022-10-18 at 11 57 56

Screenshot 2022-10-18 at 11 57 15

Screenshot 2022-10-18 at 11 55 30

Proposal

No response

Updates and actions

No response

Rename this repo - right?

Background and proposal

I'm not confident what this repo is about, but it includes pilot in its name. Rename it?

Ping @2i2c-org/tech-team

Logout link ends with `//logout` instead of `/logout`

It seems that a template is provided that results in a logout link with double / in it. {{ base_url }} seems to include the /, which I recall is the standard for this configuration.

<div class="text-center">
<a role="button" class='btn btn-jupyter' href='{{base_url}}/logout'>
Tap to try a different account
</a>
</div>

image

There seem to be examples from oauthenticator where logout_url is used directly, which seems more accurate if possible instead of the hardcoded /logout.

Ability to preview changes made

It would be good if users were able to previous this change easily, without needing to merge the PR or similar. Remember that not all hub's come with a dedicated staging hub either, but even if they did, it adds work for us if we merge each time a test to see the outcome is done.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.