3lvis / viewer Goto Github PK
View Code? Open in Web Editor NEWImage viewer (or Lightbox) with support for local and remote videos and images
License: Other
Image viewer (or Lightbox) with support for local and remote videos and images
License: Other
Right now shows the pause button on top of everything. :dolan:
func numerOfItemsInViewerController(_ viewerController: ViewerController) -> Int
Found an issue when rotating the screen here are some steps to reproduce it:
2016-01-26 16:43:07.610 iOS[34694:2279593] App Transport Security has blocked a cleartext HTTP (http://) resource load since it is insecure. Temporary exceptions can be configured via your app's Info.plist file.
Right now is creating one viewer item controller per item, this is terrible.
It should have a buffer of 10 and reuse those controllers once they go offscreen.
Sorry to post as an issue but I don't understand how you make my array of URLs into an array of Viewables.
I'm pulling from 'https://github.com/3lvis/Viewer.git', :commit => 'baaf8ca0c3e93c3a08288c1bdf52116444d20ee8', which seems to work but would be nice to pull from release.
When opening full screen, I would like to drag the screen down and up to dismiss the image.
Somewhat related to #22
if video is playing and that moment we lock and unlock the phone and rotate the video , in that case video does not work.
Using Cocoapods with version 3.0.0
Compile error on line 27
https://github.com/bakkenbaeck/Viewer/blob/master/Source/VideoView.swift#L27
#if os(tvOS)
playerLayer.videoGravity = AVLayerVideoGravity.resizeAspectFill
#else
playerLayer.videoGravity = AVLayerVideoGravity.resizeAspectFill <<<
#endif
Type 'AVLayerVideoGravity' (aka 'NSString') has no member 'resizeAspectFill'
Hi! That's really a great library, i think the only one, which gave ability to customize header/footer view. The only thing that it missed - ability to show photos without collection view. What do you think about adding that functionality?
There is no loading indicator while the image is being loaded so the user simply sees a black screen.
Also, there is no visible dismiss/close icon to dismiss the view, I understand that you can drag-down to dismiss but that is simply not intuitive enough.
Is there a way to enable a loading indicator and dismiss icon?
it's still 3.0.0
Sliding your finger on the video scrubber can cause the video behind to slide. It shouldn't do that.
Most recent version can not be build by Carthage:
*** Skipped building Viewer due to the error:
Dependency "Viewer" has no shared framework schemes
If you believe this to be an error, please file an issue with the maintainers at Optional("https://github.com/bakkenbaeck/Viewer/issues/new")
Describe the bug
Example app crashes in certain circumstances with orientation change, but believe is not regarding example code.
To Reproduce
Steps to reproduce the behavior:
iOS Version (please complete the following information):
Additional context
*** Terminating app due to uncaught exception 'CALayerInvalidGeometry', reason: 'CALayer position contains NaN: [nan 195]. Layer: <CALayer:0x600000c37600; position = CGPoint (1266 195); bounds = CGRect (0 0; 844 390); delegate = <UIImageView: 0x7ffe08322d70; frame = (844 0; 844 390); opaque = NO; autoresize = W+H; gestureRecognizers = <NSArray: 0x6000003996e0>; layer = <CALayer: 0x600000c37600>>; allowsGroupOpacity = YES; backgroundColor = <CGColor 0x600002f9e5d0> [<CGColorSpace 0x600002894d20> (kCGColorSpaceICCBased; kCGColorSpaceModelMonochrome; Generic Gray Gamma 2.2 Profile; extended range)] ( 0 0 )>'
Occurs at imageView.frame = CGRect(origin: CGPoint.zero, size: realImageViewSize)
of ViewableController
Right now UIScrollView pagination is not working, hence, support for tvOS is not available.
Expected:
Since all the UI, buttons and status bar was hidden, then when returning the photo to it's original position, then the status bar should be hidden.
Current:
All UI is hidden, but the status bar is visible.
Hi! That's really a great library.
i just post this issue(inform) here because of you make this library much better.
i am using Xcode 11.0 and swift 4.0 or above.
i am getting issue when i used local option on your demo and also my project.
Hi! First of all thanks for a great library!
I found some small issue while paginating between photos. It's seems like when changing current indexPath, there's some image request appears, so viewer lags a little bit and photo blinks.
I attached small video for demonstration.
https://www.dropbox.com/s/v7tmu0w7n2kzn09/viewer_bug.mp4?dl=0
Evaluate if there's an unneeded extra call here:
https://github.com/bakkenbaeck/Viewer/blob/master/Source/ViewerController.swift#L654
Second method call introduced here:
Hi,
I am using this library to show photos and videos, photos are working fine but video is not.
All i can hear the audio with image but no audio.
Any idea why this is happening ? Same video is working in Viewer sample code. I am using pod version of viewer.
Hello,
I have tried installing viewer using cocoapods and by coping main source file. But none of them is working.
Whenever i am trying to build the project, xcode is getting crashed. After removing Viewer that didn't happen. So because of this i am unable to use viewer.
Please look into this issue and provide some guidation.
Thanks.
The framework seems to complain that i'm missing the following images in my assets. I installed via cocoapods:
-dark-circle
-play
-pause
-repeat
Swiping an image should disable interactions with other buttons until interaction is finished, otherwise is not very clear which element should be dismissed.
iOS's Photos app: Just dismisses the original image
Carousel: Similar to iOS photos but tries to be smart about which image should be dismissed, it also crashes most of the time
Google Photos: Disables interactions with other elements until interaction is finished
apologies as this is more of a "how-to"....I have an imageURL string, how can I conform to the Viewable protocol?
If the user can change from the initialIndexPath, how do we know which Viewable object a header / footer action is occurring? Say I wanted to favorite or delete an photo as in the example, how do we know which photo this is happening to?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.