4d / 4d-netkit Goto Github PK

The file https://github.com/4d/4D-NetKit/blob/48a9b1155b36b0012cd54aba24b4af96ad7a7f52/Resources/Response_Template.html make reference to Wakanda and its licences. Should be updated with 4D…

When I use the component, a WebServer folder with the default index.html file are created.

This prevent my redirect to works because the redirect will return this index.html page instead of going through the On Web Connection database method.

My redirect URI is http://127.0.0.1:8081/

I have to delete manually the WebFolder to make it works.

Pushed in branch YT/Feature/Office365_UpdateMessage

User Story

As a developer, I want to be able to use the 4D Net Kit component to request third party that implement OAuth2 with some specific implementation that are not fully covered by the spec.

Examples

Authorize URL of third party app: {{OAuthBaseUrl}}/authorize?client_id=<Client_ID>&response_type=code&redirect_uri=<Redirect_URL>&customParam={{customValue}}

Another example is : {{OAuthBaseUrl}}/{{tenantUUID}}/token

Features that could help to solve this case

1. Allow to easily add our class inside the component that inherit from a base class. This base class could implement interface functions that allow to have a callback when getting the authorize or token URL. By default the function return the classic URL but our specific class can implement a specific callback to add some custom parameters or replace some placeholder in the URL.

2. Having a collection that allow to add parameters and their values.

3. The tenant in the URL seems to be covered by the Microsoft solution, but I'm not sure if this can be used for other providers.

I would like to request that the corresponding symbol file (a.k.a. syntaxEN.json) is checked in for all commits tagged with a 4D version number.

Reason: There are often several branches of a 4D application. The main branch and several hotfix branches - all of them can be built with a different 4D version within the CI pipeline. In order to be able to trace 4D-NetKit or execute unit tests against it, the appropriate commit must be checked out in the interpreted NetKit source.

Semantics: The symbol file maps the public API of the component. It is directly related to the code, not just the compilation, since the Parser seems to check for them.

It is inconvenient to start a compilation for the symbol file as soon as you check out a tagged commit in 4D-NetKit. However, this must currently be done in order to avoid RT errors in the host application if the public API has changed.

When the redirectUri do not ends with /, the regex for the path and the port in _getPathFromURL and in _getPortFromURL are not working correctly.

Ex: http://127.0.0.1:8081

It should accept such redirectUri.

When intending to implement this in a call from a 4D CLIENT application (aka Remote Mode), you will need a 4D Web Application Expansion for 4D Client license, not the standard 4D Web Application Expansion included as part of 4D Server license.

Just thought it should b mentioned somewhere because the blog post announcing this does not, nor does it seem to be mentioned anywhere here.

per this thread on the forum, once an access token is obtained, it is not checked for expiration.
_BaseAPI._getToken() should have the if block removed, to trigger the expiration check.

it would be great if you would use a more traditional version labeling scheme, and then, if a version was dependent upon a particular version of 4d, add that to the readme/release notes.
right now, for instance, you have R5 as the version level, but R4 is still in beta, R5 is not available, and it doesn't look like there is anything in R5 that won't run in prior versions.
i get that netkit is supposed to be an internal component, but there are features and bugfixes that apply to prior versions, too.