4lt / quake-util Goto Github PK

Current benching apparatus runs several iterations; would like just 1 iteration

Apparently QBSP supports texture names with spaces. But it doesn't support escaped quotes. But TrenchBroom does? Whee.

A) Handle whatever QBSP handles

B) Handle whatever TrenchBroom handles

C) Handle both with a switch, with default behavior rejecting anything ambiguous

Don't handle escape sequences. Read what can be read unambiguously only. Write without quotes if possible.

Parsing

• "some text" lexes to token some text (starts and ends with quotes)
• some"text lexes to token some"text (doesn't start with quote, contains quote)
• so"me text" lexes to tokens so"me and text" (doesn't start with quote, contains quote and space)

Writing

• "sometext" can't be written (starts with quote)
• some"text is written as some"text (contains quote, no spaces)
• some text is written as "some text" (contains space, no quote)
• so"me text can't be written (contains space and quote)

Current state is to check each piece of the map before writing, which could lead to failure during a write; this would result in a "corrupt" file.

Current state writes formatted map representation to sink(); avoid this by using "blackbox"

Pros

• Simplifies code
• "invalid" maps may be useful under a different context (e.g. prefabs?)
• Difficult to determine what will be "valid" or not before compiling

Cons

• May result in needless duplication of code down the line (e.g. multiple crates implementing the same routines)

Alternatives

• Don't leave validation on the map as a whole except for dicts (no duplicate keys), planes (non-degenerate triangles), and brushes (at least 4 planes). Don't invalidate worldspawn-less maps (2nd bullet of Pros), maps without player spawn (who knows what game the map is for) etc.

Rather...

Rename validate to check_writable and only focus on verifying what can be written to file and parsed back

Perform benches on current state, and compare with interned strings.

Also check conversion to number at lexer stage.

Maps are too big. Download maps from another source during testing/benchmarking. DO NOT require downloading just to build.

• remove files from repo
• upload files to ??? (digitalocean for now)
• automate download of files during benchmark and/or test build
• keep checksums of files in repo?