Think about interface. Example: --open on issue list?

ApiHelper took over concepts that should belong to the repository, e.g. links.

Likely, a refactoring would be:

• move those methods into the repository
• encapsulate the api helper inside the repository
• only move the repository around

There are currently two omissions in the VCR testing, at least, in the default configuration.

No expectation about what is sent and what not

The VCR gem replays responses to known requests, and raises an error on unknown requests, but doesn't verify that the expected requests are sent.

It needs to be made sure that the requests sent after creating the PR in the test suite, are really sent.

The body is not checked

The body is not sent. For example, if the service instance doesn't stub GitClient#current_branch:

described_class.new(upstream_repository) #, git_client: git_client)

the body sent will be:

{"title":"Title","body":"Description","head":"<developer_branch>","base":"master"}

different from the expected:

{"title":"Title","body":"Description","head":"mybranch1","base":"master"}

and the UT will still pass.

Duplicate of #75.

Plan:

• add required git client APIs
• raise an error if there is any diff
• if there is no remote branch, create it; otherwise, push

When summary editing via editor was introduced, the parameter for specifying title/description was removed.

Having a --summary parameter is useful especially for performing manual testing when developing.

Requires simple_scripting 0.9.2.

• commands are not up to date
• add issue list

The base will list all the open issues assigned to the currently logged in user, ordered by newest one (this is the standard github display).

In the future, other options will be designed, in particular:

• filters
• custom formatters
• etc.etc.

Where it can be done, parallelize calls:

• create pr
• create issue

In some cases, it's appropriate not to choose anything, eg. for labels.

Likely improvement: add :required option to ManualListSelection.

For example: ListLabels.new(repository).execute

Add support for merging a PR.

Add support for deleting the branch when merging a PR

When exiting vim from a prepopulated description, right now there is no possibility to block the PR creation.

Fix:
- explain to exit with :cq
- detect the error code

Simpler fix: tell the user to just cancel the description.

• the dependencies should be defined in the gemspec, and the Gemfile should have a reference to it
• the Gemfile.lock file should be taken out of the repository

Write title/description in an editor, instead of passing them as parameters.

See https://github.com/piotrmurach/tty-prompt.

On the ticketsolve repo, the the curl command runs fine, but it will hang via ruby.

Sample:

curl --verbose --silent --user "[email protected]:<key>"  https://api.github.com/repos/ticketsolve/ticketsolve/issues?

The API path is the same; Issue#list can therefore be removed, but it must be checked what's the GitLab API.

• remove code duplication
• when GitLab PR listing is implemented, decide if Issue.list must be kept or not.

Add tests suites:

• Research stubbing of external services
• Add test suites
  • list labels
  • list issues
  • list prs
  • create gist
  • create pr
  • list issues (upstream)
  • list prs (upstream)
  • create issue
  • merge pr

Check for example labels

When developing the Geet project, it's very easy to accidentally perform a write operation on its repository, instead of a test one.

Design a way to configure "locked" repositories.

• list
• create

Command: geet {issue,pr} create -m- -u

Stacktrace:

Finding milestone...
lib/geet/utils/manual_list_selection.rb:17:in `select': No milestone provided! (RuntimeError)
  from lib/geet/services/create_issue.rb:136:in `select_entries'
  from lib/geet/services/create_issue.rb:34:in `execute'
  from bin/geet:30:in `launch'

It' very easy to make a mistake an create a local issue on a forked repository.

Review which operations should raise a warning, and implement it

Check if implement (none) entry is usable for lists (no) selection.

This causes an error:

geet gist create /path/to/file description

Disable browser autoopen, and make it configurable.

Think about output (stderr/stdout). Will need:

• an extra output, for the errors
• a review of all the missed stderr instances
• likely redirection options to execute_command

Either (more likely) labels list command, or integrate other commands (less likely)

The newly added Git class will encapsulate all the git local operation.

The proxy pattern used is possibly poor; investigate alternative designs.

Rubocop shows many failures, so it must be configured and the failures fixed.
Also update it to the latest version.

When the - option is selected (for milestones, reviewers, labels), show a multiple choice menu with the options.

Gist creation doesn't need a repository.

Not so easy, as it involves the summary editing, which will need to be reviewed as well.

See https://developer.github.com/v3/issues/#edit-an-issue.