6eero / newpass Goto Github PK

as the title suggests do you have any plan to add function to import keepass database or even use it as backend?

Hi! I noticed the following:

GeneratePasswordViewModel.generateRandomPassword() uses java.util.Random -- which is not cryptographically secure -- instead of java.security.SecureRandom.

EncryptionHelper logs plaintext and keys; understandable for debugging but not something that should occur on users' devices.

(Additionally, I noticed the typo "lenght" a few times.)

Provide user the option to toggle between dark and light mode, with the settings retained.

Do not limit the password to 15 characters

cc @IzzySoft

Maybe it would be a better idea to say "create a secure password for NewPass" and "Unlock NewPass" instead of "login to your account".

Essentially I was confused if this is a local account or not. Also "username" should just be "name" as it literally says "welcome back, pablo!" and doesn't need to be entered.

Include uppercase and numbers by default.

Use at least 14 characters.

Why 14? Strength testing tools rank the complexity as 'centuries' when trying the generated passwords from your app with uppercase and numbers using 14 but not less characters.

Do not limit usernames to 10 characters

Steps to reproduce:

• Login
• Go to Settings
• Toggle the dark mode button
• Change language
• Exit the application
• Log back in
• Go to settings
• Try toggling the dark mode button

Observation:
When the button is toggled, the language of the app also changes. This shouldn't happen

Screen recording:
https://github.com/6eero/NewPass/assets/33260602/f0cb2572-43d4-4bdc-a143-6994f6383d83

Accrescent is an alternative android app store.

See their guide: https://accrescent.app/docs/guide/getting-started/

Defect: Try using the native back navigation and the top back button to navigate to the previous screen. For example, navigate to the main screen after login, add an entry, come back to the main screen, then go to generate a password, come back to the main screen, and then press the back button.

Expected: The user should exit from the app.

Actual: The user stays on the main screen until and unless you press the back button several times till you exit the app, depending on the back stack.

This defect can be recreated in various flows. PFA the screen recording

Since I’m new to creating APKs, I apologize if I’m annoying you, but could you please give me more comprehensive guidance on how to construct APKs, as I’m just starting out?

Hey,

I've just tested your app and it looks great on my Android. Do you plan to release prebuild version ? If you are interested I can list it on my open source repo at https://openapk.net/ so other people can try it !

Thanks for adding Fastlane structures! Could you please slightly adjust full_description.txt? A simple newline (empty line) before the bullet-point list would make it render perfectly as Markdown. You could also add an introductional paragraph:

NewPass is a secure password management application designed to generate and store strong passwords locally on your device. With NewPass, you can create highly secure passwords for your accounts and services without the need to remember them.

(remember to separate that from the "Key features" by an empty line as well). If you wish, you can also use simply HTML formatting, e.g. enclosing "Key features" like this: <b>Key Features:</b>. Optionally, you can make it fully HTML:

<p><i>NewPass</i> is a secure password management application designed to generate and store strong passwords locally on your device. With NewPass, you can create highly secure passwords for your accounts and services without the need to remember them.</p><p><br><b>Key Features:</b></p><ul><li><b>Password Generation:</b> NewPass provides a robust password generator that allows you to create complex and secure passwords tailored to your specific requirements. You can customize the length and the character set (Uppercase, Numbers and Special).</li><li><b>Local Storage:</b> Your passwords are stored locally on your device, ensuring complete privacy and control over your data. NewPass does not store any passwords on external servers, minimizing the risk of unauthorized access (If you uninstall the app, your password are lost!).</li><li><b>AES Encryption:</b> NewPass encrypts all stored passwords using Advanced Encryption Standard (AES) with Cipher Block Chaining (CBC) mode before saving them in the local database.</li><li><b>User-Friendly Interface:</b> NewPass features an intuitive and user-friendly interface, making it easy to generate, view, and manage your passwords. The app offers convenient options for copying passwords to the clipboard and securely sharing them with other applications.</li></ul>

(I've put that into a single line to prevent fdroid from replacing each line break by <br>, which it loves to do otherwise)

Include password strength in the generation process and in the entries themselves