a1igator / repostcheckerbot Goto Github PK

The delete post at -2 votes feature seems to be broken, take a look:
https://www.reddit.com/r/ProgrammerHumor/comments/brpnwx/pretty_sure_those_are_node_modules/eofk07p?utm_source=share&utm_medium=web2x
Also might want to look at implementing something for more accurate detection

In your last commit (49469f8) you might have missed this loop

https://github.com/xXAligatorXx/RepostCheckerBot/blob/d43b314d874f78e695f49b7c4f5b7e4063cc6a2c/database.py#L250-L266

The applied fix to add a sleep will solve the immediate issue. The proper way to handle tasks is to use a task/event scheduler (https://docs.python.org/3/library/sched.html#). If you want to repeatedly run them make sure the task reschedules itself. This way you have more control over, can cancel it at any time, and still execute it even if an exception is thrown in the function.

A second improvement you can implement, if you want t really clean code, do not run the delete task in a fixed delay loop but rather just as necessary. You can retrieve the oldest/newest time in the sql query and compute the next time a deletion operation is necessary and schedule the appropriate task right away.

https://github.com/xXAligatorXx/RepostCheckerBot/blob/d43b314d874f78e695f49b7c4f5b7e4063cc6a2c/app.py#L43

If sqllite for py isn't entirely different than every other db lib I have worked with:

https://github.com/xXAligatorXx/RepostCheckerBot/blob/b11b397baed745df82ae439aacba0ff9bd430af8/database.py#L709-L719

We can reuse the connection, and it definitely should be closed once we are done with it. Closing the cursor is NOT! enough and you'll eventually run out of allowed connections we can establish

Hello,

As I will be making the bot public and very easy to add into any subreddit, I require for it to be able to handle 1000s of posts a minute, and it is just not fast enough for that yet. I have exhausted my knowledge of efficiency in Python, sqlite, and video and image hashing.

I would very much appreciate it if you may help me make the code more efficient in any of those areas. I believe the sqlite implementation is the area that could be improved the most due to the amount of statements that I have.

Most of the slow parts of the code are in database.py . The set up has been explained in the readme. Please make a comment if you are interested or have any questions/problems or even if you believe the code is as efficient as it can be.

Thanks for reading!

If not, you can check out https://github.com/harrisbegca/GeneralReposti and perhaps we can merge the two

I would like to add some documentation on how new contributors can test out the bot while they work on it.