Bashism of "install-dkms.sh" about ipt-netflow HOT 8 CLOSED

I never see such error. What version of bash?

I tried on bash 2.04.0, 3.1.17, 4.1.2, all w/o syntax errors.

from ipt-netflow.

Ah you run via sh. Why?

from ipt-netflow.

"bash" is a strong dependency. It may be not installed on a lot of systems. Do you want keep this dependency?

from ipt-netflow.

I din't know there is anti-bash conspiracy. But please don't report it as bug when you run bash script with sh. Thanks.

from ipt-netflow.

I didn't report this as a bug. It's not a bug. It's just an extra heavy dependency. It's your will to keep it, of course. Just IMHO there's no reason for that.

from ipt-netflow.

There is no reason for anything in general. But, "bashism" is for arrays (which is absent in sh). See there is reason for it. Arrays is for detection of multiple module installs. See another reason for it. That detection is to ease users life and make install very simple. See, third reason for it.

This doesn't look to me as "no reason for that". And doesn't look like "easily fix the problem with bash".

I don't usually code useless things w/o reason.

from ipt-netflow.

$ head -1 /usr/sbin/dkms
#!/bin/bash

Resolve this bashism first. 😱

from ipt-netflow.

which is absent in sh

What is arrays in this context?

$ cat > /tmp/test.sh << EOF
#!/bin/sh

A='el1 el2'

for e in \$A; do
        echo "element: \$e"
done
EOF
$ sh /tmp/test.sh
element: el1
element: el2

This doesn't look to me as "no reason for that".

OK :)

Resolve this bashism first.

Damn. You right! It's very unexpected surprise. Sorry for wasting your time on this issue.

from ipt-netflow.