abakh / nbsdgames Goto Github PK

When trying to build the package on Arch Linux, I got an error:

Makefile:2: *** invalid syntax in conditional.  Stop.

On line 2 in Makefile there is the line ifndef $(CFLAGS). I think this should be ifndef CFLAGS. As explained in the make manual, ifdef and ifndef take a variable name, not a reference. In this case, if CFLAGS is empty, the line would expand to just ifndef , a syntax error.

Man Pages for the games would be kinda nice to have.

Would it be possible to add cribbage (like in the old bsdgames)?
Thanks.

Hey there - could some entry be added to the main readme to state on
which platforms it works? Evidently on Linux (I am git cloning it right
now) but I wonder if it works on OSX or windows too. With mingw I
was able to compile quite a bit, though I only rarely use windows so
far.

It should be easy to solve but I have no idea how to solve it. look at <common.h>.

make
cc sudoku.c -lncurses -lm -o ./sudoku
sudoku.c:22:6: error: redefinition of 'wait' as different kind of symbol
byte wait=0, waitcycles=0;
^
/usr/include/sys/wait.h:248:7: note: previous definition is here
pid_t wait(int ) __DARWIN_ALIAS_C(wait);
^
sudoku.c:139:17: error: invalid operands to binary expression ('pid_t ()(int )' (aka 'int ()(int )') and 'int')
wait=(wait+1)%60;
~~~~~~~~^~~
sudoku.c:140:8: warning: address of function 'wait' will always evaluate to 'true' [-Wpointer-bool-conversion]
if(!wait && waitcycles<3)
~^~~~
sudoku.c:140:8: note: prefix with the address-of operator to silence this warning
if(!wait && waitcycles<3)
^
&
sudoku.c:150:18: warning: ordered comparison between pointer and integer ('int' and 'pid_t ()(int )' (aka 'int ()(int *)'))
for(byte b=0;b<wait;b+=10)
~^~~~~
2 warnings and 2 errors generated.
make: *** [sudoku] Error 1

The package currently fails to build on PPC64 FreeBSD 13.0. The reason for this failure is that the PPC64 version of FreeBSD still uses a fairly old gcc version that defaults to C89, so there are a bunch of errors. Switching to C99 makes some of these go away but exposes new problems: your code apparently redefines a byte type a bunch of times:

jewels.c:27:21: warning: redefinition of typedef 'byte' is a C11 feature [-Wtypedef-redefinition]
typedef signed char byte;
                    ^
./common.h:17:21: note: previous definition is here
typedef signed char byte;
                    ^
1 warning generated.

(while this is a warning with the version of clang I tested, I believe it is an error on the old gcc).

Please fix the code by removing all duplicate definitions of byte. There should only be one such definition in common.h. Then make a new release so I can package the fix. You can check if you fixed it correctly by temporarily adding --std=c99 to CFLAGS.

Couldn't figure why. The error messages aren't very informative.

Hi again! Any plan to new release with new games and feature? Or project is dead?

if you want to post them?

https://screenshots.debian.net/package/nbsdgames

Someone in #debian-games suggested that I open an issue for it.

@alexmyczko would you do it?

What is the file "circlejump.c" for? I don't see a game with that name. I tried compiling it but got errors in the terminal.

Hi @eliasrg
Thank you very much for your help to the project so far.
Would you do this very very simple, very easy act of help that would have a huge impact on me?

That's just making a patreon page for nbsdgames (that is a site where people could donate by subscription, ask for features etc.) and simply just keeping the money until some years later when I could take it. Simply just that. Just a few clicks.

I may sound desperate, since I have asked multiple people through the years and everyone runs away upon hearing the word "money". I can't do that myself, just because of Patreon TOS, but it is otherwise perfectly legal in EU, and people with similar setups have had 0 problems. a real example running for years:
https://www.patreon.com/jadijadi

I would be super-hyper very thankful.
I hope you get the importance it has for me, my pay is below $1/h and I have problems. 169 people have starred this repo, and if they pay just half a dollar a month on average, most of my current problems would be solved, and I could spend much more time on open-source. not only this project, but also many practical ideas I have and currently don't have time for.

Notcurses does some pretty cool TUI stuff. See https://github.com/dankamongmen/notcurses. Use it where appropriate and if installed. Optionally have package managers bundle notcurses as dependency. It's available for several Linux distros such as Debian and Fedora.

Where can I find the controls for these games

Hi. I'm big fan of ascii games. First, I just want to say thank you. Second, you are my hero! :-) Please keep working on this awesome games compilation.

Tell me the games you want to be added

Frogger. I searched GOOD implementation of this game and not found. What is mean GOOD? Like original with bonuses, time and score. Please see gameplay video - https://www.youtube.com/watch?v=WNrz9_Fe-Us

Another stupid question. Why so strange license? Maybe use standard free licenses like MIT, GPL, BSD.

Hi @carlocab, it seems it was you who updated the homebrew nbsdgames bottle for version 4.1.2, thank you for that.

I was wondering how did packaging people find about version 4.1.2 without me announcing it anywhere other than in the releases page?
Also how they didn't find about the new version? Perhaps either I or Github changed a thing.

Some games are not known to everyone. It would be nice to see the rules somehow.

missing ';' at the end of this line

Turns out it matters.
However a fast enough algorithm that adjusts for difficulty and works with all the sizes isn't trivial to write.

A solution is to simply remove Sudoku, since there are a lot of Sudoku games for terminal already. But they don't look this nice.

Help or guidance on that matter is appreciated.

this would be fun to add? https://github.com/cmang/cpong

Hi @alexmyczko
Lubuntu people say that the nbsdgames icon doesn't show for them in the menu, also the nbsdgames command isn't there for them.
Also there is probably no reason for /usr/games/ , /usr/bin/ probably works in more places.

Thanks.

Usually beating a high score means scoring more and not the same.

Usually when you play minesweeper you can't fail on the first move. This is achieved by generating the mine positions when user clicks the first cell so that the clicked one is always empty.

Made an account to say I'm getting the following error:

cp: target '//usr/games' is not a directory
make: *** [Makefile:60: nbinstall] Error 1
==> ERROR: A failure occurred in package().
Aborting...

I don't know enough about code to say how to fix it, but would appreciate if someone could tell me what's going on.

Thanks

http://copyfree.org/resources/works#New%20BSD%20Games

Please let me know if there are inaccuracies to be corrected or improvements to
be made in the listing, including suggestions for changes to the list of tags
associated with your project's entry.

make nb adds the prefix nb in front of each binary, including nbsdgames itself, which becomes nbnbsdgames. I am 80% sure this isn't intended, but in case it is, feel free to close this issue.

Hi, nbsdgames cannot be started after installation from default repo.

1. binary name is not nbsdgames but nbnbsdgames
2. its not in default /usr/bin path
   

I don't know why.