abbat / pytoxcore Goto Github PK

OS X doesn't have (or need) librt. It does support pkg-config. Perhaps you can use pkg-config to detect header locations and linker flags?

ToxCore provides savedata_type settings at instance creation. For now looks like it is impossible to change it using pytoxcore (or I haven't found way to do that).

See TokTok/c-toxcore#40. The toktok repo currently has version 0.0.1. The API will not change in that version. You can test for this version specifically to #if/#endif the change.

Whether there are plans to update library for support of toxcore 0.2.8 from toktok?

I don't know how python setup.py works, but it has a hard-coded path to /usr/tox/{include,lib} in it. This should probably be auto-detected or configurable. If it is in fact configurable, please add that to the installation instructions (also, write installation instructions).

This code seems to have no tests, only examples. It needs a test suite and build with C coverage (gcov) enabled. I suggest using coveralls.io to ensure that coverage becomes and remains high.

The debian/copyright file states the license is GPL v.3, yet the project lacks proper a LICENSE or COPYING file.

Hi,

I believe the code in this repository is partially based on PyTox(https://github.com/aitjcize/PyTox). Since the original code is GPL licensed. Could you please add reference to the original project?

Thanks.

In file included from pytoxcore.h:23:0,
from pytoxav.h:23,
from pytox.c:20:
pytox.h:31:21: fatal error: tox/tox.h: Нет такого файла или каталога
compilation terminated.