acbarbosa1964 / rawflickr Goto Github PK

The proposed change is to move the "Uploader" property out TPhoto and into 
TFlickrEx. The rationale behind this is that Upload/Replace is a sub-API 
in itself, so it seems more logical to use:

* Flickr.Uploader.Upload(...) 

than

* Flickr.Photos.Uploader.Upload(...)

The change, which came about during the development of the upload example, 
will affect both the interface and implementation parts and would render 
the new version incompatible with previous applications. At this point in 
time, though, (March, 2009) there are still very few apps using the 
library, so the impact would be minimal.

The following parameters were missing in TUploder.Upload:

  safety_level
  content_type (opcional)
  hidden (opcional)

Flickr has added a new method "getClusters" photos.tags.*
The method allows to query for a tag and return the clusters (and tags)
associated with it.

ref. http://groups.yahoo.com/group/yws-flickr/message/4218

Synapse support has been retired from rfNetHlp because the implementation
was a mess. I plan to reintroduce it for release 1.4 or before (if possible)

Hi.
Delphi 7 shows the following warnings:

[Warning] StringsExt.pas(547): Symbol 'RaiseLastWin32Error' is deprecated
[Warning] StringsExt.pas(561): Symbol 'RaiseLastWin32Error' is deprecated
[Warning] RawFlickr.pas(350): Property declaration references ancestor
private 'TRESTApi.FSignAll'

Adding the served rawflick.pas to your uses clause and trying to compile
gives these errors:

* In unit DateTimeExt.pas:
  - Can't find function VarToDateTime
* In unit StringsExt.pas:
  -  Unrecognized symbols: SLinstIndexError,  SAssignError

This same errors happen, probably, in other versions of Delphi newer than
Delphi 5.

To reproduce the problem, simply create a TFlickrEx instance and 
callAuthorize w/ an empty token:

----------------------------------------
procedure ItWillFail;
  var Flickr: TFlickrEx;
begin
  Flickr := TFlickrEx.Create('valid api key', ''valid secret');
  if Flickr.Authorize('write', tmpToken) then
    ShowMessage('Authorized as ' + Flickr.User.UserName)
  else
    ShowMessage('Fail! Last response: '#OD#OA +
                Flickr.Auth.LastResponse);
end;
----------------------------------------

You should see the dialogs from DefaultAuthorize, etc. Instead, the call 
returns false as if the authorization had failed.

In TPhotos.Search, missing parameters "contacts", "geo_context" and 
"is_commons"

Flickr added some new parameters to flickr.photos.search related to geo
queries. They have been noew incorporated to the library.

Flickr has added the "The Commons" license to the list of licenses (code  7
- "Not known copyright restrictions").

This change affects TLicenses.getInfo and TPhotos.search


YWS-Flickr ref. http://groups.yahoo.com/group/yws-flickr/message/4161

Eyeballing needed to bring the code up to date with the Flickr API.
When reviewing, please focus on:
- Methods in the API that have not been incorporated
- New parameters that have not been incorporated in the old methods
- Operational mods. in Flickr that should be reflectd in the API (like p.e.
when the authentication proccess changed)
- Changes in the code that have (or will) affect the compatibility with
23hq
- Compatibility of the library across Delphi versions.

After the review/update process, it'll be released the next version: 1.3
The planned date for the release is sometime in May, 2009

Almost all the methods return the UTF-8 response payload as a String, as 
has been normal up to Delphi 2008. Delphi 2009, however, has a new 
UTF8String type and uses encoding-coertion between string types on 
assigment, which can lead to problems (such as garbled outputs) when using 
this library in that platform.

I'm not sure what the solution may be and I can't test because I don't 
have access to a Delphi 2009 to test this issue.

Flickr has added a new "contacts" parameter to photos.search
The announcement says it should be considered experimental so I'm not sure
if/when it'll be incorporated.

ref. http://groups.yahoo.com/group/yws-flickr/message/4162

Memory leak detected in TFlickrEx.Create.

Use FastMM4 to detect the leak.

Hi.
The unit StringsExt.pas does not compile under Delphi 7 because of
Undeclared identifier: SListIndexError 

Hi. 
It is possible to get a tiny demo for this library? Just a very basic
example. It will help us get started in minutes.

Thanks

doc-comments should be explicitly marked as such by using a special marker
such as; p.e.
  {:@summary(A doc comment)} vs. {A regular one}

The reason for this is that as of now PasDoc doesn't allow for exclusion
markers (as I thought at first) so sometimes regular comments en up being
passed to the docs. :-/

Though perhaps the best solution would be changing of system altogether;
sometimes I get the impression that the source is somehow "dirty" with all
the documentation embedded it.