acclimatecontainer / acclimate-container Goto Github PK

After a discussion with @dongilbert on Twitter, it might make sense to change the vendor name and namespace/directory structure of Acclimate to:

1. Broaden the potential scope of Acclimate (which is a cool name) so that other types of adapters could be created (e.g., event dispatching, session handling, etc.).
2. Not be directly associated with my name in the case that the project is passed on to another owner at some point.

This is all pending some more positive feedback/support and evidence of usefulness of the package itself, so I can justify spending time and effort on it. Changing the namespaces would happen before the 1.0 release.

• Current:
  • Package Namespace: Jeremeamia\Acclimate
  • Core Class: Jeremeamia\Acclimate\Acclimate
• Proposed:
  • Package Namespace: Acclimate\Container?
  • Core Class: Acclimate\Container\ContainerAcclimator?

In the (apparently likely) event that PSR-11 is accepted by FIG, should this project switch to providing PSR-11 adapters to containers that need it?

Any chance you would consider breaking this into two projects, one for the container implementation and one for the adaptors (or even one per adaptor). I would love to use this project as a central DI container for a micro-framework project, but having to load all the dev dependencies for any dev project when using the micro-framework is a problem we would like to avoid. Users who want to take advantage of adaptors to other containers may not mind the extra weight, but the burden should not be placed on all users of the container.

Upgrade from Pimple 1 to Pimple 3

Great Dependency Injection Container.

https://github.com/nette/di

Compatibily should be great, according to your readme.

No rush, but it would be cool to see adapters made for https://github.com/rdlowrey/auryn and https://github.com/Level-2/Dice

(Apologies in advance if this is some noob error on my part)

EXPECTED: PSR4 compliance?
namespace Acclimate\Container;
should be found at:
acclimate-container/src/Acclimate/Container/

ACTUAL:
namespace Acclimate\Container;
Is found at:
acclimate-container/src/`

Notes

Acclimate doesn't seem consistent with PSR4 (http://www.php-fig.org/psr/psr-4/) :

"The contiguous sub-namespace names after the "namespace prefix" correspond to a subdirectory within a "base directory", in which the namespace separators represent directory separators. The subdirectory name MUST match the case of the sub-namespace names."

Other projects, even the PHP DI interop, map more directly and consistently, for example:
container-interop/src/Interop/Container/ContainerInterface.php

//
namespace Interop\Container;

interface ContainerInterface
{

I'm not using (and can't use) composer, so perhaps that's why It's affected me?

(PS: Thanks for making and maintaining this library, very useful!)

Ref #28

Hey, thanks for a great tool! I'm trying to integrate PHP DI and larval containers.

This is specifically because Laravel's container has some funky behaviour and from my usage, it seems inferior to PHP DI.

I understand that a make method is outside of the scope of PSR11, but seems like a useful addition to Acclimate?

http://php-di.org/doc/container.html#make
https://laravel.com/docs/5.5/container#resolving

Latest version of Guzzle no longer has a container.

What do you think about Acclimate?
Is it a good idea?
Can you think of any good use cases for it?
Any other thoughts, ideas, feedback, criticism, or praise you want to share?
Please do.