ace-lol / ace Goto Github PK

Hello, why is summoner-tooltip not functional / present?

When the client is resized, the edit mastery page in-queue doesn't currently resize with it. This happens both scaling up and down. I've been resizing to normal size to edit and going back down, but thought I'd speak up about this issue.

Relevant comments in template-content.ts: https://github.com/ace-lol/Ace/blob/master/src/hook-providers/template-content.ts#L10-L13.

Currently, we wrap HTMLTemplateElement.content and give plugins the opportunity to do their initialization/changes there. However, the scope of the hook is fairly big, even if plugins behave and unregister their hook after applying their changes. Ideally, I would like to edit the HTML after insertion, but that gives a whole other range of problems/things to consider.

Currently, HookManager serves as a fairly useless collection of hooks. The hook function does some basic analysis of duplicate hooking, but ideally I would like it to be a lot more useful. For that, at least the following things need to happen:

• Fix the equality check in areParamsEqual.
• Figure out if we want to disallow duplicate hooks, or if we just want to warn about them.
• Find a better way to relay the warnings to the developer/user.

When in queue and resizing the window to a bigger size (but not smaller) the timer for queue disappears.

I can not hear the notification sounds for game invites and chat messages!!

Potential changes:

• Enabling the popout mode that is implemented but not turned on.
• Allowing people to resize the chat window.
• Integrating discord/slack-like emoji.
• Adding discord/slack-like unfurling.

Most of these seem fairly straightforward.

As far as I can tell, there is no simple example plugin (e.g. hello world), nor a list of available APIs to hook.

If this could be provided, there are a few things I personally would like to add as plugins if I could do it quickly.

If an exhaustive list of APIs is too large an undertaking, a short wiki-like page on how to find them would be nice too. I just dont know where to start my reverse engineering,

Currently, the ember-component.ts hook is matching on the classNames property, which is fairly abundant on most Riot components. However, it is not a perfect matching mechanism. In the best situation one could provide a callback for validation, however this gives a fairly large performance penalty (given how much components are internally registered/used).

See https://github.com/ace-lol/Ace/blob/master/src/plugins/summoner-tooltip/index.ts#L83-L85. The only fix from what I can see is by using the APIs available over at developer.riotgames.com, but that requires a key.

when I try to launch ace, I get a popup telling me that access has been denied.
Can you tell me how to fix this

the popup :

thanks for the help.

Improvements could include:

• Custom champion filters (like the current role-based ones). (#13)
• Sorting on mastery.
• Displaying chest received/champion mastery on champion icons.
• Tooltips with general information about the champion (like the collections screen).

If possible:

• Changing skin early (instead of when everyone has locked in).
• Random skin (idea shamelessly stolen from LES).

Hello pls kindly consider an AUTO LOGIN function

as well as FASTER TOOLTIPS when hovering (for example, .5 second delay over mastery hover)

THANK YOU!

Can either be done with transform: scale(x) on the body element and moving it accordingly, or by POSTing to /lol-settings/v1/local/video which is a lot cleaner/better quality but not instant (hides, then shows window, resets it back to middle). Best option would be to apply scale during resizing, then saving the scale with the POST on mouseup.

Seems to be as easy as attaching some listeners to rcp-fe-lol-ready-check and simulating the button press. Testing it is a pain though...

On a side note, might be interesting to consider what to do when someone is in the chat window when they press enter (although to be honest, 99% of the time you are in queue because you want to play).

Something alike to Google's old account picker:

Would allow for easier logins, but needs a reliable/secure way to store data on the computer.

The latest update made Ace stop working completely. Not sure if it was the Ace update or the League update (that brought soloq).

Every time I load the client through ace, it reloads with ace closed. No error message or any thing.

I need to take a look if TypeScript offers a convenient way to add type-safe hooks, but otherwise we will probably need overloads taking a string literal as type and delegating them to the hook, like this:

// Current code, renamed to _hook but stays unchanged.
_hook(plugin: Plugin, hookName: string, callback: Callback, ...matchers: any[]) {}

// More specific overloads per hook.
hook(plugin: Plugin, hookName: "http", callback: Callback, matcher: RegExp | string) {
    this._hook(plugin, hookName, callback, matcher);
}

// etc...
hook(plugin: Plugin, hookName: "ember-component", callback: Callback, matcher: string) {
    this._hook(plugin, hookName, callback, matcher);
}

Would it be easy to bring back a Minutes : Seconds timer for the FWOTD?

edit: RIOT pls ;_;

Currently clicking on a skin in the Skins collection tab simply opens the champion page because there is no way to select a specific page/skin. Might need to inject into rcp-fe-lol-champion-details for that.