achimr / corpus-tools Goto Github PK

The declaration
    my $eAlignedRef,$fAlignedRef; 
should be
    my ($eAlignedRef,$fAlignedRef); 
otherwise $fAlignedRef is not defined.

Repro steps:
1. Add the letters a-z to nonbreaking_prefix.es (one letter per line
2. Run unit tests

Results:
The sentence breaker does not break after the sentence ending "multilingüe."

Possible explanation: the accented character is regarded a word boundary in the 
regular expression breaking the sentences?

Lingua::Sentence version 1.03 exports a 'new' function by default. Not only is 
this unnecessary and wrong for OO (you don't need to export functions called 
via -> like Lingua::Sentence->new), it also breaks when used in classes that 
already have a 'new' provided for them (like those using Moose or Moo).

Please fix. This is a two-line, six-character change (removing 'new' from both 
@EXPORT and @EXPORT_OK: it belongs in neither one).

cpan> install Lingua::Sentence
Running install for module 'Lingua::Sentence'
Fetching with LWP:
http://cpan.strawberryperl.com/authors/id/A/AC/ACHIMRU/Lingua-Sentence-1.05.tar.gz
Fetching with LWP:
http://cpan.strawberryperl.com/authors/id/A/AC/ACHIMRU/CHECKSUMS
Checksum for C:\STRAWB~1\cpan\sources\authors\id\A\AC\ACHIMRU\Lingua-Sentence-1.05.tar.gz ok
Scanning cache C:\STRAWB~1\cpan\build for sizes
............................................................................DONE
Configuring A/AC/ACHIMRU/Lingua-Sentence-1.05.tar.gz with Makefile.PL
Can't locate inc/Module/Install.pm in @INC (you may need to install the inc::Module::Install module) (@INC contains: C:/Strawberry/perl/site/lib C:/Strawberry/perl/vendor/lib C:/Strawberry/perl/lib .) at Makefile.PL line 1.
BEGIN failed--compilation aborted at Makefile.PL line 1.
Warning: No success on command[C:\Strawberry\perl\bin\perl.exe Makefile.PL]
  ACHIMRU/Lingua-Sentence-1.05.tar.gz
  C:\Strawberry\perl\bin\perl.exe Makefile.PL -- NOT OK
Stopping: 'install' failed for 'Lingua::Sentence'.
Failed during this command:
 ACHIMRU/Lingua-Sentence-1.05.tar.gz          : writemakefile NO 'C:\Strawberry\perl\bin\perl.exe Makefile.PL' returned status 512