Adapter Redis about ganesha HOT 7 CLOSED

Hi @chengangcode , thank you for reporting this issue.

I've run the tests locally with latest master but the failures aren't reproduced.

$ docker-compose up
Starting mongo     ... done
Starting redis     ... done
Starting memcached ... done
Starting server    ... done
Starting client    ... done
...
...

$ docker-compose run --rm -w /tmp/ganesha -u ganesha client vendor/bin/phpunit
PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

...............................................................  63 / 102 ( 61%)
.......................................                         102 / 102 (100%)

Time: 39.12 seconds, Memory: 14.00MB

OK (102 tests, 160 assertions)

Could you please let me know the versions you are using? (Ganesha, PHP, OS)

from ganesha.

Builder::buildWithCountStrategy use RedisAdapter

docker-compose run --rm -w /tmp/ganesha -u ganesha client vendor/bin/phpunit Ackintosh/GaneshaTest /tmp/ganesha/tests/Ackintosh/GaneshaTest.php
PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

FFF.FFFF. 9 / 9 (100%)

Time: 928 ms, Memory: 8.00MB

There were 7 failures:

1. Ackintosh\GaneshaTest::recordsFailureAndTrips
   Failed asserting that true is false.

/tmp/ganesha/tests/Ackintosh/GaneshaTest.php:42

2. Ackintosh\GaneshaTest::recordsSuccessAndClose
   Failed asserting that true is false.

/tmp/ganesha/tests/Ackintosh/GaneshaTest.php:55

3. Ackintosh\GaneshaTest::notifyTripped
   Expectation failed for method name is equal to string:receive when invoked 1 time(s).
   Method was expected to be called 1 times, actually called 0 times.

4. Ackintosh\GaneshaTest::failureCountMustNotBeNegative
   Failed asserting that true is false.

/tmp/ganesha/tests/Ackintosh/GaneshaTest.php:116

5. Ackintosh\GaneshaTest::withIntervalToHalfOpen
   Failed asserting that true is false.

/tmp/ganesha/tests/Ackintosh/GaneshaTest.php:132

6. Ackintosh\GaneshaTest::disable
   Failed asserting that true is false.

/tmp/ganesha/tests/Ackintosh/GaneshaTest.php:152

7. Ackintosh\GaneshaTest::reset
   Failed asserting that true is false.

/tmp/ganesha/tests/Ackintosh/GaneshaTest.php:169

FAILURES!
Tests: 9, Assertions: 14, Failures: 7.

from ganesha.

@ackintosh

from ganesha.

@happylhb Thanks your comment. You mean that the unit tests fails if we set Redis adapter here instead of the Memcached adapter?

from ganesha.

@ackintosh yes

from ganesha.

@happylhb Unfortunately Redis Adapter doesn't support the Count strategy for now. 😢

From your comment, I've noticed we should update that make Ganesha throws Exception if using Redis Adapter with the counting strategy so that users can notice that is unsupported. 💡

from ganesha.

Now we can notice that an adapter doesn't support the strategy as an exception is thrown if so.
#36

And I've opened the issue to track the status of a support for Redis + Count.
#37

from ganesha.