Redis Success key keeps growing about ganesha HOT 5 CLOSED

Based on when we where testing the cleanup didn't happen on Ganesha::isAvailable() for some reason. Sadly enough after evaluating Ganesha the company went for another direction are we are now using the istio circuitbreaker where possible,
If wish you all the best of luck with the library!

from ganesha.

Hi @boekkooi-fresh , thanks for reporting this issue. Nice catch!

Yes, your suggestion is a good idea. ✨

from ganesha.

I've started working on this issue.

from ganesha.

@boekkooi-fresh Just a thought, do you have any issues about that the success count keeps growing?

Although the count keeps growing if we keep calling Ganesha::success(), the count will be cleanup once either Ganesha::failure() or Ganesha::isAvailable() is called.
In other words, it is guaranteed that the count loaded via Redis::load() is cleanup.

It seems polite that the count stored in Redis to be cleaned up in realtime but it has trade-off relation with performance.

from ganesha.

It is a shame that Ganesha can't get adopted but I wish the success for the company and I believe that the system will get more resilient. ✨

Thanks for your feedback to this project!

from ganesha.