ackwell / ninjabot Goto Github PK

Seems that on occasion, a player leaving the game (when it is not their turn) will cause the current_player pointer to move to an incorrect position.

Add symbols/letters before the cards, to identify the colour of them.

For

1. Colourblind people
2. People using Colloquy

Currently will throw a hissy if the message is not returned.

The current system only runs Kronos commands in threads, while all of the other triggers run in the main thread. This needs to be fixed before we can implement DoS protection (as suggested in #56) or any other time-sensitive operation. Also, it will allow for better separation of different tasks and make ninjabot more modular from an execution standpoint as well as a design standpoint. We could include limits on plugin threads, making some plugins have a higher priority than others, dedicate CPUs to particular threads, etc.

Seems that on occasion, a player leaving the game (when it is not their turn) will cause the current_player pointer to move to an incorrect position.

Enable plugins to define commands that will be run at set intervals (For things such as polling websites, etc.)

The README is seriously out of date. Should probably be upgraded to a .md (Markdown), and give some info on plugins and how to write them.

While starting sometimes an exception is raised:

ninjabot-allmywut git:master ❯ python ninjabot.py                                                                  ✹ ✭
ninjabot starting up
ERROR DURING TASK EXECUTION Ninjabot instance has no attribute 'message_queue'
Writing storage to disk
Traceback (most recent call last):
  File "/usr/lib/python3.4/asyncore.py", line 411, in __getattr__
    retattr = getattr(self.socket, attr)
AttributeError: 'NoneType' object has no attribute 'message_queue'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/nick/Python/ninjabot-allmywut/kronos.py", line 469, in threadedcall
    self.execute()
  File "/home/nick/Python/ninjabot-allmywut/kronos.py", line 314, in execute
    self.action(*self.args, **self.kw)
  File "ninjabot.py", line 229, in send_queue
    while not self.message_queue.empty():
  File "/usr/lib/python3.4/asyncore.py", line 414, in __getattr__
    %(self.__class__.__name__, attr))
AttributeError: Ninjabot instance has no attribute 'message_queue'

Suggestions:

• Weather Underground
  
  Note: The Weather Channel refers to Weather Underground for an API.
• OpenWeatherMap
• HAMweather Aeris API
• WeatherBug
• Metwit.com
• AccuWeather probably has an API somewhere because of http://www.accuweather.com/en/downloads
• The BoM has a weird API.
• Yahoo! also has RSS feeds.
  
  Note: Yahoo! uses data from The Weather Channel, so we can forget that.
• Weatherzone - We could also scrape http://m.weatherzone.com.au; Weatherzone probably also has an API for their mobile apps.
• World Weather Online

Here's a whole list of weather APIs (filtered to JSON format).

Maybe it's just me, but at the moment, it's hard to tell what cards you have with the colourblind mode turned on.

20:44 < Sugarloaf0> spake: Maybe it's just me, but, I found it difficult to tell what
cards I had at a glance. I was thinking instead of having something
like [r6][r8][y1][b2], you could have something like
R:[6][8], Y:[1], B:[2].

Suggestion dump of Marvin's modules

• help
• modhelp (possibly integrate with help)
• say
• stats
• g (google)

The bot currently does not connect to IRC over SSL.

We don't want certain three-letter government organisations spying on us, do we? 😉

Because editing the main file for config changes is a bitch.

So... it seems I managed to do this:

auscompgeek | s/.*/\r\nJOIN 0/
SuchNCSSBot | auscompgeek meant to say: 
        <-- | SuchNCSSBot (~ninjabot@unaffiliated/auscompgeek/bot/aucgbot) has left

... and now I have to restart it. Oops.

A join trigger would help as well.

Disconnect direct messages, add module API, hook modules.

Possibly add drop-down box for default command?

Doesn't take into account probability. Someone slightly less asleep than I should modify it to weight the random numbers correctly.

not entirely sure what's going on here, but it definitely looks like a race condition.

bot stdout:

PING :cameron.freenode.net
SENT: PONG cameron.freenode.net

Writing storage to disk
:gnustomp!gnustomp@unaffiliated/gnustomp PRIVMSG ##hypnotoad :https://forum.groklearning.com/t/py-malware-dont-test-it/7248
Starting new HTTPS connection (1): forum.groklearning.com
Starting new HTTPS connection (1): groklearning.com
Starting new HTTPS connection (1): forum.groklearning.com
Starting new HTTPS connection (1): groklearning.com
:gnustomp!gnustomp@unaffiliated/gnustomp PRIVMSG ##hypnotoad :.-.
:gnustomp!gnustomp@unaffiliated/gnustomp PRIVMSG ##hypnotoad :i disapprove
:PaperBag!~bucket@unaffiliated/forkbomb/bot/paperbag PRIVMSG ##hypnotoad :\u0ca0_\u0ca0
SENT: PRIVMSG ##hypnotoad :Title: Grok Learning

error: uncaptured python exception, closing channel <__main__.Ninjabot connected chat.freenode.net:6667 at 0x7fb48a518780> (<class 'IndexError'>:deque index out of range [/usr/lib/python3.4/asyncore.py|write|91] [/usr/lib/python3.4/asyncore.py|handle_write_event|461] [/usr/lib/python3.4/asynchat.py|handle_write|178] [/usr/lib/python3.4/asynchat.py|initiate_send|250])
Writing storage to disk

what we saw:

19:15:00  +gnustomp | https://forum.groklearning.com/t/py-malware-dont-test-it/7248
19:15:01  +gnustomp | .-.
19:15:03  +gnustomp | i disapprove
19:15:03   PaperBag | ಠ_ಠ
19:15:06    NCSSBot | Title: Grok Learning
19:15:06    NCSSBot | Title: Grok Learning
19:15:19  +gnustomp | i should just reply with while True: os.fork()
19:15:19        <-- | NCSSBot (~ninjabot@[redacted]) has quit (Remote host closed the connection)

In its current form, the regex plugin is susceptible to ReDoS (as demonstrated by me on @gnustomp's ninjabot instance). A timeout is needed for the execution of the user-provided regex.

It has been suggested that threading may be used to achieve this.

We should use sets more, because performance and ease of use.

Just poking around the code a little bit, I notice Ninjabot.ignored and Ninjabot.admins are good candidates for sets.

Implement a system that keeps track of how many times each user has won the game, with a leaderboard that appears both on request with a command, and after each game. Persistence should probably be to a dotfile in the user's home folder, in the same location as .ncssbot_config.

imp is deprecated since Python 3.4, in favour of importlib.
While importlib is used in some places, imp is used in others.

Allow triggers to require permissions

I'm going to start off by writing some for my Storage rewrite (#62) in any case.

unittest.mock is very helpful in any case, for database and external api interaction :)

Should add functionality that allows the bot to reload all plugins (^reload) or a single plugin (^reload ) without the need of restarting

Should throttle the bot to 1 message a second (or something, probably have a setting in the config file) to prevent channel flood.

During the processing of URLs, there is a race condition in which two requests are made to the server and information sent to the channel twice.
Related error:

ERROR DURING TASK EXECUTION deque index out of range
Traceback (most recent call last):
  File "/home/notackwell/ninjabot/kronos.py", line 469, in threadedcall
    self.execute()
  File "/home/notackwell/ninjabot/kronos.py", line 314, in execute
    self.action(*self.args, **self.kw)
  File "./ninjabot.py", line 232, in send_queue
    self.irc_send(message, now=True)
  File "./ninjabot.py", line 215, in irc_send
    self.push(message_bytes)
  File "/usr/lib/python3.4/asynchat.py", line 190, in push
    self.initiate_send()
  File "/usr/lib/python3.4/asynchat.py", line 250, in initiate_send
    del self.producer_fifo[0]
IndexError: deque index out of range

It appears as though ninjabot tends to leak memory over time. e.g. I just checked the resource usage on the server and it was using roughly 3 times the amount of RAM it uses when it starts up.

We should probably investigate this.

• Is Python's garbage collector being crappy?
• Is it a plugin?
• Is it the storage? I don't see any memleaks in the storage API.
• Is it kronos?
• Is it our __magic__ shiz?
• Could it be the magic import hackery?

Probably a good idea.

https://duckduckgo.com/api

It appears the "official" Python libs are here: http://pypi.python.org/pypi/duckduckgo2/0.2

We could also consume the API through Mashape: http://www.mashape.com/apis/DuckDuckGo%20Zero-click%20Info

Need to do some work on the networking code, get it working with multiple connections, etc.

Also should fix up the passing of context...

A suggestion is to have the bot output statistics of the round when it is over

Some examples of stats could be:

1. Everyone's hands (not technically a stat, but meh)
2. Average time taken to play hand
3. Most skipped person or number players have been skipped
4. Cards played or player who played the most cards

Probably a good idea to make a wiki, with more in-depth details on how to write plugins for the bot. Either that, or write lots of dockstrings, and use ReadTheDocs! or something to generate a gh_pages site.

At the moment, if someone changes their nick mid-game, the game awaits actions from their old nick. Even worse is if a user changes their nick and leaves, which forces an admin to kick the now defunct nick. The proposal is to track nick changes in the plugin to eliminate this issue. Another idea is to add a method like on_nickchange as a standard plugin method in Main.py, enabling tracking of changes across all plugins.

requests seems to take a while (i.e. ~30 s) to complete a request to https://groklearning.com/ and https://stackoverflow.com/ on Debian (wheezy, jessie and sid). curl is fine though.

It works just fine on Ubuntu (saucy and trusty).

@gnustomp has also reported that requests is slow on Windows.

Edit: @gnustomp also says it's fast on Darwin.

Currently plugins have to use a timer_ function to utilise cooldowns, etc. Considering that i've already got kronos.py set up, it would be possible to add a function to Controller that adds functions to kronos. Stuff like a proper cooldown for UNO, etc.

http://thefuckingweather.com/

(not an alternative to implementing issue #55)

Following up from #76 and #102, it seems that asyncio's SSL support is slightly broken. We should figure out why.

From #102:

The behaviour when SSL/TLS is enabled is that a large chunk of messages are never received by the server.

/cc @gnustomp @cyphar

Add a persistence system that plugins (like uno) can easily utilise for stats and other things that should survive many restarts.

Would seem that in some cases (quite a few actually), the Message's "body" and "channel" are empty, as seen below:

To avoid the whole game hanging when an admin isn't around and a player is idling indefinitely, the plugin should automatically make users draw a card after a certain number of seconds of inactivity (maybe 90 seconds?) to avoid ruining everyone else's fun!