Giter VIP home page Giter VIP logo

tea-cozy's People

Contributors

acsgd avatar

Watchers

 avatar  avatar

tea-cozy's Issues

Summary

Overall met expectations.

The html is well structured and organized. You used divs, ids, and classes to organize the content.

The CSS main issue is the nav bar with the padding-left.

Display block is extra work. Usually I would recommend after typing display block for css, you go into the chrome tools and make sure it isn't part of the default. Even if it isn't, unless you see a dramatic visual difference, uncheck from the chrome tools to see if it made a real difference.

Alt texts and comments is more about best practices in accessibility and web site design.

To prepare you for the upcoming projects, use a media query to make this site fit properly on a mobile device.

https://www.w3schools.com/css/css_rwd_mediaqueries.asp

The last set of projects will be using media queries for this purpose and this will help prepare you for them.

Nav bar drops below

nav{
  text-align: right;
  flex-grow: 1;
  padding-left: 700px;
}

The very large padding left is causing this, if you get rid of it then this works. Screenshot attached.

If you work on a wide screen you wouldn't notice this.

navtea-cozy

Comments

Have matching comments in your css file, this makes it easier to line up the html and css together.

display block in css

Divs, paragraphs, and headings have a default of display: block. So adding this is unneeded code as the browser would have already done this.

If you look at the screenshot below, the cross out line represents the browser default.

tea

Alt text

Include descriptive alt text in each picture, the visually impaired use screen readers to go on the web. The screen readers read this to describe the picture.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.