Giter VIP home page Giter VIP logo

Comments (13)

MaksimZhukov avatar MaksimZhukov commented on July 18, 2024 4

Thank you @lucacome for the feedback, we really appreciate it!
We are considering the possibility of expanding the functionality of the alpha version. As soon as we finish the investigation, we will make appropriate changes, if necessary, and release a stable version.
Thank you for your patience!

from labeler.

kachkaev avatar kachkaev commented on July 18, 2024 3

How about setting dot option to true by default? I can craft a PR if this change is desired. From my personal experience, ‘special treatment’ of dot files by labeler is somewhat surprising. I guess that the vast majority of developers would want to set dot: true anyway.

from labeler.

lucacome avatar lucacome commented on July 18, 2024 2

@MaksimZhukov I've been using the alpha for the past moth in multiple repos and everything works as expected.
Any chance we can get a new alpha/beta with all the new features/updates that went into main? 🙏

from labeler.

jorgepiloto avatar jorgepiloto commented on July 18, 2024 2

Hi @MaksimZhukov, I can confirm it fixes the issues with the sync-labels. The fact that this version adds labels based on branch names, is an excellent feature. Thanks for all the effort and time you devoted to this action ❤️

from labeler.

MaksimZhukov avatar MaksimZhukov commented on July 18, 2024 2

@joshdales, this is a great point, thank you. We will switch the nested options to kebab-case

from labeler.

MaksimZhukov avatar MaksimZhukov commented on July 18, 2024 1

@kachkaev Thanks for the suggested idea! We will consider adding it to the new major release.

from labeler.

joshdales avatar joshdales commented on July 18, 2024 1

Thanks for the updates in the new beta version - I was wondering why not use consistent casing for all the config keys names? eg. the new changed-files nested keys are all in PascalCase now rather than kebab-case. Would it not be better to have them all be the same?

I realise that some of this might be my fault as I added some of those keys 😅 I personally don't have a preference, I just went with kebab-case initially because it was the same as the action config, but if the nested changed file options are how y'all would rather future keys are then might make sense to switch changed-files, head-branch, base-branch as well?

from labeler.

dfandrich avatar dfandrich commented on July 18, 2024 1

from labeler.

MaksimZhukov avatar MaksimZhukov commented on July 18, 2024

Hello everyone!
We've released a new beta version of the action. The configuration file structure was changed to provide more flexibility for changed-files. For more information, see the release notes and this issue.

If you have any questions, ideas or concerns, please share them in this issue.

from labeler.

dfandrich avatar dfandrich commented on July 18, 2024

There seems to be a different bug with sync-labels now. When not explicitly setting sync-labels in the GHA job file, the job errors out with

TypeError: Input does not meet YAML 1.2 "Core Schema" specification: sync-labels Support boolean input list: `true | True | TRUE | false | False | FALSE`

There needs to be an explicit sync-labels: false in the workflow file to avoid this; it can't be left out to rely on the default false value.

from labeler.

MaksimZhukov avatar MaksimZhukov commented on July 18, 2024

@dfandrich, thank you for reporting this! Could you please create a new issue?

from labeler.

cwire4 avatar cwire4 commented on July 18, 2024

Have the outputs changed or gone away in the beta? I originally used version 4 of the action and grabbed a snippet that outputs the new-labels and all-labels for the run. When I switched to the beta version, this step no longer outputs any labels even if some were added.

This is the step I have in my yaml:

  • name: "Check Outputs"
    run: |
    echo 'New labels:'
    echo '${{ steps.labeler.outputs.new-labels }}'
    echo '-------------------------'
    echo 'All labels:'
    echo '${{ steps.labeler.outputs.all-labels }}'

The previous step's id is still labeler.

from labeler.

onesneakymofo avatar onesneakymofo commented on July 18, 2024

Is there anyway someone can squeeze #688 in to the v5 release please? We title our PRs with [FEATURE], [BUG], [CHORE], etc. and it would be nice to auto-label based off of that so we can automate our release notes. 🙏

from labeler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.