activeprospect / generator-leadconduit-integration Goto Github PK

The LeadConduit handler is adding support for a validate() function on an integration, to verify essential data is present before making the request (e.g., Telesign shouldn't be called if there's no phone number). An example of this should be added to generated outbound code.

Here are the steps to duplicate the issue:

1. npm update -g generator-leadcoduit-integration
2. cd leadconduit-integration-requestBin
3. Answer all prompt questions
4. run cake test from documents/leadconduit-integration-requestBin

module.js:340
throw err;
^
Error: Cannot find module 'leadconduit-fields'
at Function.Module._resolveFilename (module.js:338:15)
at Function.Module._load (module.js:280:25)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at Object. (/Users/ap/Documents/leadconduit-integration-requestBin/spec/outbound-spec.coffee:2:10)
at Object. (/Users/ap/Documents/leadconduit-integration-requestBin/spec/outbound-spec.coffee:1:1)
at Module._compile (module.js:456:26)
at Object.loadFile (/Users/ap/Documents/leadconduit-integration-requestBin/node_modules/coffee-script/lib/coffee-script/register.js:16:19)
at Module.load (/Users/ap/Documents/leadconduit-integration-requestBin/node_modules/coffee-script/lib/coffee-script/register.js:45:36)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at /Users/ap/Documents/leadconduit-integration-requestBin/node_modules/mocha/lib/mocha.js:184:27
at Array.forEach (native)
at Mocha.loadFiles (/Users/ap/Documents/leadconduit-integration-requestBin/node_modules/mocha/lib/mocha.js:181:14)
at Mocha.run (/Users/ap/Documents/leadconduit-integration-requestBin/node_modules/mocha/lib/mocha.js:393:31)
at Object. (/Users/ap/Documents/leadconduit-integration-requestBin/node_modules/mocha/bin/_mocha:380:16)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Function.Module.runMain (module.js:497:10)
at startup (node.js:119:16)
at node.js:906:3

// regex for either "git://github.com/(user)/(repo).git ..." or "[email protected]:(user)/(repo).git ..."
var match = githubRepoUrl.match(/git[@:]/*github.com://([a-z0-9-_.]+).git/i);

Here is a regular expression that will parse either git://github.com/(user)/(repo).gitor[email protected]:(user)/(repo).git from the variable githubRepoUrl:

([email protected]:[a-z0-9-.]+/[a-z0-9-.]+.git)|(git://github.com/[a-z0-9-.]+/[a-z0-9-.]+.git)

it seems that often when I build an integration, I'm looking for ways to parse integers and prices and etc in a way that doesn't break or return NaN. seems like we might be able to build a standard helper file to help guide newbies and oldbies alike.

The generated package.json has the following reference, but no index.js is created.

"main": "index.js",

Here are the steps for recreating the error:

1. create a public repo: ros3bud/leadconduit-integration-requestBin1
2. create and cd into directory: Documents/leadconduit-integration-requestBin1
3. run yo leadconduit-integration
4. hit enter for name of service '(RequestBin1)'
5. select integration type: 'Outbound'
6. add service's URL: 'http://requestb.in/130wl15'
7. hit enter for HTTP method 'POST'
8. hit enter for 'No or not sure' for does the service require authentication?
9. hit enter for 'Standard Form POST' for what format is the service expecting?
10. arrow down to select 'XML (text/xml)' for what format does the service respond with?
11. hit space bar for 'First Name', 'Last Name', 'Email'
12. hit enter

After hitting enter, the following error is visible in my terminal:

/usr/local/lib/node_modules/yo/node_modules/yeoman-environment/node_modules/inquirer/node_modules/rx/dist/rx.all.js:8913
throw e;
^
TypeError: Cannot read property '1' of null
at yeoman.generators.Base.extend._processAnswers (/usr/local/lib/node_modules/generator-leadconduit-integration/app/index.js:275:30)
at PromptUI.completed (/usr/local/lib/node_modules/generator-leadconduit-integration/app/index.js:215:14)
at PromptUI.onCompletion (/usr/local/lib/node_modules/yo/node_modules/yeoman-environment/node_modules/inquirer/lib/ui/prompt.js:69:10)
at AnonymousObserver.Rx.AnonymousObserver.AnonymousObserver.completed (/usr/local/lib/node_modules/yo/node_modules/yeoman-environment/node_modules/inquirer/node_modules/rx/dist/rx.all.js:1761:12)
at AnonymousObserver.Rx.internals.AbstractObserver.AbstractObserver.onCompleted (/usr/local/lib/node_modules/yo/node_modules/yeoman-environment/node_modules/inquirer/node_modules/rx/dist/rx.all.js:1698:14)
at AutoDetachObserverPrototype.completed (/usr/local/lib/node_modules/yo/node_modules/yeoman-environment/node_modules/inquirer/node_modules/rx/dist/rx.all.js:8933:31)
at%

Here is an image of my terminal window with the error: