Originally noted here: adafruit/Adafruit_CircuitPython_RGB_Display#111 (comment)

The Image interface seems incomplete. With the changed import:

adafruit_rgb_display/rgb.py:68: error: "Image" has no attribute "convert" [attr-defined]
adafruit_rgb_display/rgb.py:213: error: "Image" has no attribute "rotate" [attr-defined]
adafruit_rgb_display/rgb.py:228: error: "Image" has no attribute "getpixel" [attr-defined]

I will still commit the change.

Image needs to have convert, rotate, and getpixel to satisfy those errors.

This library missed the conversion to pyproject.toml and will need to be manually converted.

I found that the docs badge leads to https://docs.circuitpython.org/projects/typing/en/latest/ but I think the proper target is https://docs.circuitpython.org/projects/adafruit-circuitpython-typing/en/latest/

The assets on the release page that are supposed to contain mpy files for the library don't actually contain library files. Instead they contain only the examples:

This library is not typically used on devices so it's unlikely many people would be looking for it there, I guess that is why it has gone undiscovered.

I ran across a need to put it on a device to check something and noticed I'm unable to install it circup or grab the mpy files manually from the release assets.

While taking on some "good first issues" the typing issues always seem to popup. Wthout a good prior knowledge of Python types and custom Circuit Python types such as i2c: busio.I2C it's actually much harder than expected. A place that lists most if not all the different types that can be used and examples of their syntax usage would be greatly appreciated. Having that live inside the typing repo as an example or multiple examples seems the most logical place.

Tekktrik suggested making this an issue and volunteered as tribute to do it.

typing.Protocol and the / syntax for function arguments both require python 3.8.
https://www.python.org/dev/peps/pep-0570/
https://www.python.org/dev/peps/pep-0544/

Python 3.7.3 (default, Jan 22 2021, 20:04:44) 
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import adafruit_mprls
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/pi/temp/venv/lib/python3.7/site-packages/adafruit_mprls.py", line 37, in <module>
    from adafruit_bus_device.i2c_device import I2CDevice
  File "/home/pi/temp/venv/lib/python3.7/site-packages/adafruit_bus_device/i2c_device.py", line 13, in <module>
    from circuitpython_typing import ReadableBuffer, WriteableBuffer
  File "/home/pi/temp/venv/lib/python3.7/site-packages/circuitpython_typing/__init__.py", line 45
    def read(self, count: Optional[int] = None, /) -> Optional[bytes]:
                                                ^
SyntaxError: invalid syntax
>>>

>>> from typing import Protocol
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name 'Protocol' from 'typing' (/usr/lib/python3.7/typing.py)
>>> 

Based on type annotating adafruit_debouncer, it may be helpful to add an Input and Output and InputOutput protocol definining getters/setters for value, similar to how @Neradoc explains:

adafruit/Adafruit_CircuitPython_Debouncer#39 (comment)

One can't important circuitpython_typing.socket if the socket stub file is socket.pyi. If it's renamed to socket.py, it can be imported. I've asked about this on stackoverflow: https://stackoverflow.com/questions/71106529/cannot-import-pyi-file-in-stubs-package.

This library is missing Adafruit Blinka in it's requirements.txt, It can be fixed by add Adafruit-Blinka to the file similar to most other CircuitPython libraries.

This library is imported by import circuitpython_typing, which causes some issues, because the "circuitpython" prefix is often dropped for other libraries.

We could change it to import typing_circuitpython, and rename the repo to Adafruit_CircuitPython_Typing_CircuitPython, which is a mouthful, but would make its naming scheme consistent.

See discussion in #9.

Should be using https://github.com/adafruit/workflows-circuitpython-libs

Following in the footsteps of issue #3, the use of / notation has been reintroduced as of 1.10.2 and in doing so requires the use of Python 3.8. This is not a thing that can be guaranteed, especially when multiple devices are being built in a commercial capacity on limited hardware.

Rather than removing the / notation again, one option would be to restrict 1.10.2 to Python 3.8, and leave the current python requirements for older versions of the module.

Could easily go in led.py! As of now it must at least define the fill() method:

https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol/blob/2ad3e56a542b9c975243bb3a3e908ef359b2b6be/adafruit_espatcontrol/adafruit_espatcontrol_wifimanager.py#L23

This library is not meant to run on CircuitPython directly. It does need mpy bundles build (they don't work anyway: #34), and now any CI PR build is failing because it's trying to run mpy-cross, but there's some syntax that's not compatible (def x(a, /):).

Now that we've factored out the build options, I don't see a way to force mpy-cross builds not to be done. There are parameters to the release actions that let you suppress certain bundles from being built, and those should be used. But there is no corresponding parameter in the build action. If you agree, we could open an appropriate issue in https://github.com/adafruit/circuitpython-build-tools.

@FoamyGuy @tekktrik