addthis / fluxthis.io Goto Github PK

Hey all,

Pulling FluxThis into my project because it's awesome, hands down. It's saving me so much time, so thanks for that!

In addition to hitting a restful API from my web client, I'm also publishing messages to a cloud messaging solution, PubNub.

What would be awesome, is if there was a nice place to plug their js client (or any other remote protocol client) into some kind of ActionCreator that manages the remote message flow just like ApiActionCreator does. However, instead of send(...) building and sending the XmlHttpRequest, send could be a required function supplied in the options hash. successTest could be required in this case as well to determine response validity.

So, you'd have ActionCreator for generic internal actions, ApiActionCreator that covers (probably most) server communication, and a RemoteActionCreator to support other remote client frameworks.

I totally get that your "super opinionated" framework may not want to include a hook to "send stuff however you want" so I'd understand hesitation, but I'm hoping you could see the value-add here for scenarios like mine.

In the meantime, I've simply extended ActionCreator to do what I've described above and I'd be happy to submit a pull request! Or, is there a more appropriate way to do this within the bounds of the framework as is? I've seen some code examples of making remote requests in ActionCreator.createPayload, which seems a little odd/misleading to me. But if that's the preferred approach, let me know!

Thanks!

Is there a reason that the gulpfile is empty?

-Daan

npm ERR! Darwin 14.3.0
npm ERR! argv "node" "/usr/local/bin/npm" "install"
npm ERR! node v0.12.4
npm ERR! npm v2.10.1
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package phantomjs does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer [email protected] wants [email protected] - 1.9.7-15