adebayo10k / expressvpn-version-upgrader Goto Github PK

tried to use it on my raspberry pi but it does not download the right architecture.
I tried to manually change the
detected_plat="U64" to
detected_plat="RPi"
in pkg-regexes.inc.sh

but it stills download the amd64.
Not sure where the error is. In any case could it be possible to put a self platform detector in the script?

Hi. Pulled latest updates today and got this error
pi@raspberrypi:~/expressvpn-version-upgrader $ ./expressvpn-version-upgrader.sh
/home/pi/expressvpn-version-upgrader/includes/helper.inc.sh: line 25: lib10k_check_program_dependencies: command not found

I # the line 25 and got this. Not sure what's happening.

pi@raspberrypi:~/expressvpn-version-upgrader $ ./expressvpn-version-upgrader.sh

Ubuntu_64_bit 3) Fedora_64_bit 5) Arch_64_bit 7) None
Ubuntu_32_bit 4) Fedora_32_bit 6) Raspberry_Pi_OS
Select your OS Platform to check online for VPN client updates (or choose None): 6
You Selected the "Raspberry_Pi_OS" OS platform. Nice!

This program has not been tested on the "Raspberry_Pi_OS" OS platform.

Usage: expressvpn-version-upgrader.sh [dev|help]

Checks a public web page for latest product information.
Optionally downloads, verifies and installs latest package.

Be aware that this program is an interesting workaround, but
relies on a public data source that is not guaranteed to persist.
It should therefore not really be used outside of hobby and
development environments.
Read the source, extend and test if you wish.

dev Run program in development only mode.

help Show this text.

pi@raspberrypi:~/expressvpn-version-upgrader $

If I run ./expressvpn-version-upgrader.sh dev I get the exactly same output.

Please advise
Thanks

Here we go :)

I think the good use of a script eventually it is when you can run it as a cronjob and leave it to make things for you.
At this stage the script is interacting with the user to provide a few details, most important the OS arch. The rest of the details for me are less important but maybe I m missing some important points.
My advise would be:
either to skip all the questions / user interactions but to achieve this you need at least to be able to recognize the OS arch within the script execution,
or leave the interactions as they are but save all the answers (upon confirmation) in a config file and eventually be able to use it maybe with an argument to the sh, like "./xxx.sh dev -config" or something like this

What do you think?