Giter VIP home page Giter VIP logo

adibags's Introduction

AdiBags

Discord Banner 2

AdiBags is a World of Warcraft addon that displays the contents of your bags in single view, distributed into several sections using smart filters. It is heavily inspired by Nargiddley's Baggins.

Configuration is available through Blizzard addon panel, the /adibags chat command, and by configuring "right-click to open options" and right clicking on any blank space in the bag window.

Main Features

Filter Partitions

AdiBags will automatically filter and group items into partitions so that all like-items are always grouped together. AdiBags tries to make sure there are intelligent defaults that require little-to-no out of the box configuration for item grouping. The partitions them selves are laid out automatically as well, with no human interaction. The result is a beautiful item and bag experience, right from the start!


Automatic filters based on Auction House categories, gear sets, and more!

Character Currencies

AdiBags supports in-frame display of currencies. The specific currencies to display can be configured in the options panel, and currency display supports a dynamic layout that grows to the number of columns configured.


Currencies viewable directly in your bags.

Full-text Item Searching

AdiBags has built-in support for item searching based on item names. Results are highlighted directly in the bag frame so they can be utilized right away.


Items fade away when they don't match a search term.

Modules

Users can write their own modules that integrate with AdiBags to extend the AddOn's functionality. There are two modules for AdiBags written by the authors:

Feel free to submit your own modules in this readme!

Tips & Tricks

  • Custom item sections can be created using the "manual filter" option in the configuration panel. Items can then be dragged and dropped on section titles to reassign that item permanently to that section.

Known Issues, Bugs, and Feature Requests

We welcome all bug reports and feature requests, though we can't promise every single feature will be implemented. Please report any issues or feature requests via GitHub issues.

We highly suggest installing both BugGrabber and BugSack in order to capture bugs in AdiBags. These bug messages should then be used in any bug reports filed through GitHub issues.

Roadmap and Future Thoughts

Guild Bank

AdiBags is an abstraction on top of Blizzard bags, and does not work to make Blizzard bags consistent or sorted. Due to this abstraction, two users of AdiBags accessing the same underlying store, such as a guild bank, may see two different views. For this reason, we've shied away from implementing a Guild Bank for now. However, there is renewed interest in solving this problem overall, so stay tuned for changes in this space.

Alt Bags and Bank

For the moment, alt bags and banks are not supported. Once we invest a bit more time into our abstraction engine, we may revisit this as an added feature.

In-Depth Filter Editing

There are no plans to add a fully featured, scriptable, or logic/waterfall based filtering engine at this time.

License

AdiBags is licensed under the GNU General Public License version 3.

adibags's People

Contributors

acidweb avatar adirelle avatar aglarcz avatar amyloid avatar cidan avatar jnwhiteh avatar kaqualls avatar legowxelab2z8 avatar mdklein avatar meivyn avatar neun0eil avatar ntowle avatar p5hema2 avatar pegoth avatar sammyisra avatar smb avatar struz avatar talyrius avatar veyh avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

adibags's Issues

AdiBags_Outfitter doesn't do anything

I have been using AdiBags for a while and then started using Outfitter to keep my Tank and DPS gear sets separate. I found AdiBags_Outfitter and installed it thinking it would create filters for "Tank" and "DPS" (the names of my gears sets) in AdiBags but nothing seems to have changed. When I am in DPS set my Tank weapon and shield just appear in the "Weapon" section and I'm worried I'll accidently sell them.

I have confirmed that AdiBags_Outfitter is installed and loaded but cannot see anywhere to configure it. What am I missing?

Error on startup

I get the following when logging into my character:

Date: 2014-12-24 06:29:07
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\AdiBags\core\Filters.lua line 126:
Usage: EmbedLibrary(addon, libname, silent, offset): 'libname' - Cannot find a library instance of "AceEvent-3.0".
Debug:

...ce\AddOns\AdiBags\libs\AceAddon-3.0\AceAddon-3.0.lua:220: EmbedLibrary()
...ce\AddOns\AdiBags\libs\AceAddon-3.0\AceAddon-3.0.lua:202: EmbedLibraries()
...ce\AddOns\AdiBags\libs\AceAddon-3.0\AceAddon-3.0.lua:283: NewModule()
AdiBags\core\Filters.lua:126: RegisterFilter()
...rface\AddOns\AdiBags_PT3Filter\AdiBags_PT3Filter.lua:13: in main chunk
Locals:
(*temporary) = "Usage: EmbedLibrary(addon, libname, silent, offset): 'libname' - Cannot find a library instance of "AceEvent-3.0"."

AddOns:
Swatter, v5.21c.5521 (SanctimoniousSwamprat)
AdiBags, vv1.8.3
AdiBagsPT3Filter, vv1.3.1
LibSharedMedia30, v3.0-89
Scrap, v12.21
SyLevel, v1.8
BlizRuntimeLib_enUS v6.0.3.60000
(ck=c4)

Error with item in bags

Im not sure which item causes this bug, but since i've got the "War Ravaged Weaponry" item in my bag I get this error popping up everytime I open my bags.

Error:

7x ...\AdiBags\libs\18LibItemUpgradeInfo-1.0-6\Core.lua:177: attempt to index a nil value
...\AdiBags\libs\18LibItemUpgradeInfo-1.0-6\Core.lua:177: in function "GetHeirloomTrueLevel"
...\AdiBags\libs\18LibItemUpgradeInfo-1.0-6\Core.lua:199: in function "GetUpgradedItemLevel"
AdiBags-v1.8.1\modules\ItemLevel.lua:118: in function "?"
libs\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:145: in function <libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:145>
:"safecall Dispatcher[2]":4: in function :"safecall Dispatcher[2]":4

:"safecall Dispatcher[2]":13: in function "?"
libs\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:90: in function "SendMessage"
AdiBags-v1.8.1\widgets\ItemButton.lua:308: in function "Update"
AdiBags-v1.8.1\widgets\ItemButton.lua:280: in function "FullUpdate"
AdiBags-v1.8.1\widgets\ItemButton.lua:245: in function <AdiBags\widgets\ItemButton.lua:234>

AdiBags-v1.8.1\widgets\Section.lua:112: in function <AdiBags\widgets\Section.lua:110>

AdiBags-v1.8.1\widgets\ContainerFrame.lua:920: in function "PrepareSections"
AdiBags-v1.8.1\widgets\ContainerFrame.lua:1024: in function "FullUpdate"
AdiBags-v1.8.1\widgets\ContainerFrame.lua:547: in function <AdiBags\widgets\ContainerFrame.lua:533>

AdiBags-v1.8.1\core\Utility.lua:89: in function <AdiBags\core\Utility.lua:81>
AdiBags-v1.8.1\widgets\LayeredRegion.lua:119: in function <AdiBags\widgets\LayeredRegion.lua:108>

Locals:
nil

Reagent Bank - Background Colour

Hiya,

This is more a request rather than a bug report.

When switching to the reagent bank tab, it would be lovely if the window's background colour could be changed so it was a clearer indicator of what you were looking at. I sometimes find myself trying to put gear items into the reagent bank and wondering why it's not working.

Is it possible to have the bank and reagent tab windows open at the same time?

Option to Use Old Layout?

I really dislike the new layout where it puts the categories into columns instead of merging everything (as it did before). Meaning now, there is a lot of wasted space. I am currently still running version 1.7.9, and was wondering if there were any plans to implement the old layout (as an option in the settings).

I just find it odd that you would alienate many people who supported you and even disable comments on curse? (not sure what happened there)...we love your addon Adirelle, just please give us the option for the old layout! :)

Request: show bank offline

Hello and thanks for great addon.
Please consider adding ability to see cached bank contents of current character.
Thanks in advance and Happy new Year!
Dmitry

Looting items on alts causes all items to appear as new

Problem described in title. This only seems to occur on my alts. When I run a dungeon and check my bags after coming out my entire inventory shows up in the new section with a huge section of empty categories below it.

Request: Filter to exclude items from autotransfer regents

I like that my regents automatically gets moved to regenttab when visiting my bank
BUT I really really would like to be able to use a custom filter to exclude some items.
Cpl examples on what I would add to the filter is Fractured Temporal Crystal and Enchanting Vellum
both I like to keep in bags due to not being able to use them when they are in regent bank I need them on me.
I'm sure there are more examples on items one would like to exclude from the auto regent transfer.

"Heirloom" quality bags appear to trigger an error. (curse #240)

Can you reproduce this problem? What steps will reproduce it?

  1. Obtain a satchel from completing a preferred role in dungeon finder.
  2. Open the backpack.
  3. Receive error.

What is the expected output?

It appears that some checks intended for heirloom gear are causing errors when heirloom bags (i.e., satchels are BoA) are obtained/opened.

What do you see instead?

Visually, no significant issue. However, BugSack/!BugGrabber catch an error.

What version of the addon are you using?

AdiBags v1.8.0-beta-10-gc5ee91a

  • AdiBags_Outfitter v1.4
  • AdiBags_PT3Filters v1.3-5.2

Do you have an error log of what happened? (Please enable the display of Lua errors or install an error-reporting addon to be sure whether an error happens or not.)

2x AdiBags\libs\LibItemUpgradeInfo-1.0-6\Core.lua:177 attempt to index a nil value
AdiBags\libs\LibItemUpgradeInfo-1.0-6\Core.lua:177 in function GetHeirloomTrueLevel' AdiBags\libs\LibItemUpgradeInfo-1.0-6\Core.lua:199 in functionGetUpgradedItemLevel'
AdiBags\modules\ItemLevel.lua:118 in function `?'
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:147 in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
[string "safecall Dispatcher[2]"]:4: in function <[string "safecall Dispatcher[2]"]:4>

[string "safecall Dispatcher[2]"]:13: in function ?' ...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:92 in functionSendMessage'
AdiBags\widgets\ItemButton.lua:308 in function Update' AdiBags\widgets\ItemButton.lua:280 in functionFullUpdate'
AdiBags\widgets\ItemButton.lua:245 in function <AdiBags\widgets\ItemButton.lua:234
[C]: in function Show' ... ...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:92 in function SendMessage'
AdiBags\core\Core.lua:458 in function `?'
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:147 in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
[string "safecall Dispatcher[1]"]:4: in function <[string "safecall Dispatcher[1]"]:4>

[string "safecall Dispatcher[1]"]:13: in function ?' ...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:92 in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:87 (tail call): ? [C]: in functionTurnOrActionStop'
[string "TURNORACTION"]:4: in function <[string "TURNORACTION"]:1>

Locals:
nil

Please provide any additional information below.

AdiBags is great, definitely my preferred bag addon, though the changes to sorting/columns/grouping are a bit odd and take some getting used to.

Adibags LDB and reagent vs regular bank

The reagent bank counts are lumped into the regular bank counts in the LDB display. It would be nice to separate them or be able to exclude the reagent bank from the count.

I almost always have space in my reagent bank but frequently run out of space in my regular bank (darn salvage yard and xmog addiction).

Thanks!

Recent Items Tab

Before the latest update (when you removed a lot of your code in favor of Blizzards code) new items went straight to there own category if new items filter was turned off. Now whether it is turned on or off every item that enters my bag first goes into a "recent items" tab and I would like to remove this as it is highly annoying. Is there a possibility of doing this? I have been using Adi bags since the start more or less and would hate to look for a new addon, but for whatever reason this is annoying me more than it probably should :p

Recent items can't be disabled.

I love your addon, but one thing i dread is the recent items function as it seems too random if an item shows there or in it's normal group when emptying mail, etc.

So i have always had that disabled so stuff automatically just get sorted to the group it's supposed to be in, but with your new "re-write version" 1.8 or what it was, even with it disabled in modules section, every time i get a new item, it will STILL show up in recent items in bag.

Switching Gear Sets

When I switch gear sets with the new AdiBags it puts all the gear i took off into a category called most recent instead of the gear set I have it filtered to go to ex. Healing or Dps. I closed the bag thinking this would make it think its not new or most recent when I reopen the bag it is still in the most recent category. So I used the S button to sort the bag the gear stays under most recent still. The only way I can get it back into its normal filtered category is to go into the gear filter options and switch from One section to four sections if i do that then put it back on one section in the filter then everything is fine until i switch gear back again.

GUI going off screen

When switching between my Bank and my Reagent Bank I cannot keep both windows on the screen, when I have it set so that I can see the Reagent bank, my regular Bank extends off the left side of the screen, and when I have it set so that I can see my regular Bank, my Reagent Bank extends off the top of the screen.

Messing with the Maximum Bag Height setting does not seem to fix either of these issues.

For some reason I can't upload screenshots or I would provide screenshots of my settings.

Bag width doesn't change

On one of my characters the bag witdh doesn't change no matter what options I chose. I re-installed several different AdiBags versions, disabled all other addons, cleaned everything there is to clean - to no effect. The only explanation I could come up with so far is that it's somehow related to the kind of bags my character is using: Grummlepack, Embersilk Bag, Tattered Hexcloth Bag and Illusionary Bag. I know it's far fetched, but I'm really out of ideas what could cause this (especially since on all other characters the resizing works) and constantly having a bag as wide as possible interferes with other windows (bank, auction house etc.).

You can see the empty space on the right side of the bag. No matter, how many items per columns I chose, there is always a lot of space left as the window doesn't resize:

adibags

Lua Error

Bug with Version 1.84

4x AdiBags\widgets\ContainerFrame.lua:985: AdiBagsSection9:SetPoint(): AdiBagsSection4 is dependent on this
C: in function SetPoint' AdiBags\widgets\ContainerFrame.lua:985: in functionLayoutSections'
AdiBags\widgets\ContainerFrame.lua:1054: in function <AdiBags\widgets\ContainerFrame.lua:1030>
...dia\libs\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:155: in function <...dia\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:155>
[string "safecall Dispatcher[2]"]:4: in function <[string "safecall Dispatcher[2]"]:4>

[string "safecall Dispatcher[2]"]:13: in function ?' ...dia\libs\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:90: in functionSendMessage'
AdiBags\core\Core.lua:445: in function `?'
...dia\libs\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:145: in function <...dia\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:145>
[string "safecall Dispatcher[1]"]:4: in function <[string "safecall Dispatcher[1]"]:4>

[string "safecall Dispatcher[1]"]:13: in function `?'
...dia\libs\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:90: in function <...dia\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:85>
(tail call): ?

Locals:
nil

Huge sections (like glyphs) do not break into a second column when needed (curse #239)

Can you reproduce this problem? What steps will reproduce it?

Very long sections do not seem to break across multiple columns. This causes the top of adibags to override the "height as percentage of screen" setting, and overrun out the top of the screen. Commonly this happens on a toon with a huge glyph inventory (I cannot find a setting to break glyphs up, say, by class.)

What version of the addon are you using?
1.8.0-Beta

Auc

11x ...aceTradeSkillMaster\Auction\AuctionFrame.lua:152: attempt to index field 'db' (a nil value)
...aceTradeSkillMaster\Auction\AuctionFrame.lua:152: in function InitializeAuctionFrame' ...aceTradeSkillMaster\Auction\AuctionFrame.lua:214: in functionInitializeAHTab'
...aceTradeSkillMaster\Auction\AuctionFrame.lua:298: in main chunk

Locals:
self =

{
ADDON_LOADED = defined @TradeSkillMaster\Auction\AuctionFrame.lua:284
TabHidden = defined @TradeSkillMaster\Auction\AuctionFrame.lua:264
RegisterMessage = defined @AdiBags\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:116
UnregisterAllEvents = defined @AdiBags\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:200
OnTabClick = defined @TradeSkillMaster\Auction\AuctionFrame.lua:240
IsHooked = defined @AdiBags\libs\AceHook-3.0\AceHook-3.0.lua:493
PLAYER_MONEY = defined @TradeSkillMaster\Auction\AuctionFrame.lua:276
UnregisterMessage = defined @AdiBags\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:179
InitializeAuctionFrame = defined @TradeSkillMaster\Auction\AuctionFrame.lua:150
SecureHook = defined @AdiBags\libs\AceHook-3.0\AceHook-3.0.lua:336
SendMessage = defined @AdiBags\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:85
SecureHookScript = defined @AdiBags\libs\AceHook-3.0\AceHook-3.0.lua:410
hooks =
{
}
IsTSMTab = defined @TradeSkillMaster\Auction\AuctionFrame.lua:197
Hook = defined @AdiBags\libs\AceHook-3.0\AceHook-3.0.lua:274
UnhookAll = defined @AdiBags\libs\AceHook-3.0\AceHook-3.0.lua:477
CreateTSMAHTab = defined @TradeSkillMaster\Auction\AuctionFrame.lua:28
RegisterEvent = defined @AdiBags\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:116
UnregisterAllMessages = defined @AdiBags\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:200
GetAuctionFrame = defined @TradeSkillMaster\Auction\AuctionFrame.lua:201
RawHookScript = defined @AdiBags\libs\AceHook-3.0\AceHook-3.0.lua:395
AUCTION_HOUSE_SHOW = defined @TradeSkillMaster\Auction\AuctionFrame.lua:226
HookScript = defined @AdiBags\libs\AceHook-3.0\AceHook-3.0.lua:366
queuedTabs =
{
}
RawHook = defined @AdiBags\libs\AceHook-3.0\AceHook-3.0.lua:313
Unhook = defined @AdiBags\libs\AceHook-3.0\AceHook-3.0.lua:418
InitializeAHTab = defined @TradeSkillMaster\Auction\AuctionFrame.lua:209
UnregisterEvent = defined @AdiBags\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:179
auctionTabs =
{
}
}
private =
{
ADDON_LOADED = defined @TradeSkillMaster\Auction\AuctionFrame.lua:284
TabHidden = defined @TradeSkillMaster\Auction\AuctionFrame.lua:264
RegisterMessage = defined @AdiBags\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:116
UnregisterAllEvents = defined @AdiBags\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:200
OnTabClick = defined @TradeSkillMaster\Auction\AuctionFrame.lua:240
IsHooked = defined @AdiBags\libs\AceHook-3.0\AceHook-3.0.lua:493
PLAYER_MONEY = defined @TradeSkillMaster\Auction\AuctionFrame.lua:276
UnregisterMessage = defined @AdiBags\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:179
InitializeAuctionFrame = defined @TradeSkillMaster\Auction\AuctionFrame.lua:150
SecureHook = defined @AdiBags\libs\AceHook-3.0\AceHook-3.0.lua:336
SendMessage = defined @AdiBags\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:85
SecureHookScript = defined @AdiBags\libs\AceHook-3.0\AceHook-3.0.lua:410
hooks =
{
}
IsTSMTab =

Copying profiles to second account

I have two WoW accounts and I'd like to just copy my filters and setup (profile) from one account to the other. I can't seem to find where profiles are saved in the addon's directory or find a way to do this from the addon's interface options in-game.

Random Items Filter to New Items Occasionally

Every now and then bags will sort all items into the "Recent items" category regardless of how long they've been in your bags. I hope the attached screenshot shows why this is a problem. (It goes off the screen.)

image

Most times you can work around it temporarily by closing/reopening bags, or by clicking the "Reset new items" button. This doesn't always work. This started happening a couple of versions ago, I believe as of 1.8.0. I'm currently running 1.8.2.

Issue with adibags_outfitter enabled

Interface\AddOns\AdiBags\core\Filters.lua:126: Usage: EmbedLibrary(addon, libname, silent, offset): 'libname' - Cannot find a library instance of "AceEvent-3.0\

Action is blocked (occasionally)

AdiBags v1.8.3

2.open bag
UI interface using items such as: box (occasional)

Blizzard UI:Action is blocked (occasionally)
Translation:插件=UI,嘗試調用保護功能=Try calling Protection

BugSack:

1x [ADDON_ACTION_FORBIDDEN] 插件 'AdiBags' 嘗試調用保護功能 'UseContainerItem()'。
!BugGrabber\BugGrabber.lua:589: in function <!BugGrabber\BugGrabber.lua:589>
[C]: in function UseContainerItem' FrameXML\ContainerFrame.lua:1004: in functionContainerFrameItemButton_OnClick'
[string ":OnClick"]:12: in function <[string ":OnClick"]:1>

Locals:
nil

Issue #16 still a problem

Can't bump a closed thread, #16

Issue just happened for me in 1.8.3, only once in the last two hours or so though.

Error when Caging Battle Pets

Greetings!

When caging a battle pet from the journal, the following error comes up:

5x AdiBags-v1.5.1\Utility.lua:165: Usage: GetItemInfo(itemID|"name"|"itemlink")
<in C code>
AdiBags-v1.5.1\Utility.lua:165: in function <AdiBags\Utility.lua:164>
(tail call): ?
(tail call): ?
AdiBags-v1.5.1\modules\NewItemTracking.lua:274: in function "UpdateBag"
AdiBags-v1.5.1\modules\NewItemTracking.lua:302: in function <AdiBags\modules\NewItemTracking.lua:284>
(tail call): ?
<in C code>
<string>:"safecall Dispatcher[2]":9: in function <string>:"safecall Dispatcher[2]":5
(tail call): ?
...\AdiBags\libs\AceBucket-3.0\AceBucket-3.0-3.lua:116: in function <...\AdiBags\libs\AceBucket-3.0\AceBucket-3.0.lua:109>
(tail call): ?
<in C code>
<string>:"safecall Dispatcher[1]":9: in function <string>:"safecall Dispatcher[1]":5
(tail call): ?
AdiBags-v1.5.1\libs\AceTimer-3.0\AceTimer-3.0-6.lua:166: in function <AdiBags\libs\AceTimer-3.0\AceTimer-3.0.lua:138>

Locals:
nil

The caged pets also do not appear in the AdiBags window, though I am sure they are actually in my bags.

Help!

Integrate with LibItemSearch

It would be extremely useful if https://github.com/Jaliborc/LibItemSearch-1.2 was integrated into this addon. Adibags is my favorite bag addon, but this advanced searching is something I've been missing for a long time. For an example of how it works you can try Bagnon or BagSync, or read the documentation on the github repo.

A quick example is: slot:feet&lvl:>=640 This would find all boots with an ilvl of 640 or higher.

Formatting Issues

Particularly with the latest 1.8.3 version, My bags frames are often off the screen. Particularly problematic when the (N)(D) buttons are inaccessible. This happened before, but not as badly. I have been playing with the settings, but each change raises a new problem, and things like this keep happening. examples:
Bank off left side of screen:
wowscrnshot_122314_185344 - adibags1_a
Bank (Reagents) off top of screen:
wowscrnshot_122314_191224 - adibags2_a

As a side note, I think I found the rows-sorting method easier to navigate than the new column-based formatting method. Also, often leaves several column-widths of space empty on right side. Love the addon, though. Can't work without it. Thanks, hope this helps.

Request: Automatically Open (advanced)

Instead of a blanket setting I'd like to be able to set which types of windows open bags.

Example:
Automatically Open at merchants and bank but NOT at Auctioneer

lua error

[C]: in function`SetPoint'
AdiBags\widgets\ContainerFrame.lua:985: in function `LayoutSections'
AdiBags\widgets\ContainerFrame.lua:1054: in function <AdiBags\widgets\ContainerFrame.lua:1030>
...ist\libs\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:155: in function <...ist\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:155>
[string "safecall Dispatcher[2]"]:4: in function <[string "safecall Dispatcher[2]"]:4>

[string "safecall Dispatcher[2]"]:13: in function `?'
...ist\libs\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:90: in function`SendMessage'
AdiBags\core\Core.lua:445: in function `?'
...ist\libs\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:145: in function <...ist\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:145>
[string "safecall Dispatcher[1]"]:4: in function <[string "safecall Dispatcher[1]"]:4>

...
[C](?): in function `Hide'
FrameXML\UIParent.lua:1982: in function`SetUIPanel'
FrameXML\UIParent.lua:2005: in function `MoveUIPanel'
FrameXML\UIParent.lua:2029: in function`HideUIPanel'
FrameXML\UIParent.lua:1713: in function <FrameXML\UIParent.lua:1705>
[C](?): in function `SetAttribute'
FrameXML\UIParent.lua:2484: in function <FrameXML\UIParent.lua:2471>

[C](?): in function `HideUIPanel'
[string "_:OnClick"]:1: in function <[string "_:OnClick"]:1>

Locals:
nil```

Without looking further at the code, but seeing "AdiBagsSection" i would think this could be related to the bags fucking up with everything being grouped above the first section like in:
https://github.com/Adirelle/AdiBags/issues/29

THANK YOU!

Sorry, this isn't really an issue, just a thank you for your hard work and dedication to the wonderful addon. I would be lost without it. It is by far my most favorite, and most relied on addon I have. And I have a lot of addons (185 currently), as I play 11 toons.
Thank you again for everything you do to try and improve AdiBags, Love it!

p.s. I registered just to thank you :)

Can't unequip tradeskill bag

I am trying to replace a tradeskill bag (leatherworking) with a standard pack and it refuses to let me. The leatherworking bag is empty, and I am able to replace any of my other standard packs with the new one, but for some reason cannot unequip or replace the leatherworking bag in any way. If I am missing something obvious please let me know, otherwise hopefully we can get a fix asap, thanks!

Option to disable "deposit/withdraw all" functions (Feature Request)

I was hoping that you could add an option to disable the Deposit All Regents Button, and disable the ability to right click a Filter Title to withdraw/deposit the entire category.

While I am sure a lot of people get good use out of this feature, I don't find myself ever using it, and I tend to accidentally deposit or withdraw large numbers of items on a daily basis while moving things around manually.

Sorting not fully working (curse #237)

Can you reproduce this problem? What steps will reproduce it?
1.Problem happens at login
2.
3.

What is the expected output?

Saved items in correct grouping and items going into the correct categories.

What do you see instead?

Some saved set items being put into single categories as well as random items being put into set item categories.

What version of the addon are you using?

Latest version v1.8.0-beta-9-gfaadd47

Do you have an error log of what happened? (Please enable the display of Lua errors or install an error-reporting addon to be sure whether an error happens or not.)

There are no errors

Please provide any additional information below.

Ever since v1.8.0-beta, i've been having a sorting problem. People are having similar issues and you released a version(s) to fix it but i'm still experiencing the same problem. The huge spacing is all still an issue.

Wrong Icons when using Clean Up Bags

When you a number of "New Items" and you click "Clean Up Bags" it will reset the new items as well as merge stacks, but it will leave almost every item with the wrong icon, sometimes duplicating icons that you only had one of in the bag (for instance, I now have two abrogator stone items.)
wowscrnshot_121614_084943

This is very problematic if you don't realize it has happened, as you can accidentally disenchant the wrong item. It requires a reload to fix.

Wrong texture on items from time to time (curse #241)

Can you reproduce this problem? What steps will reproduce it?
1.I collected herbs in my herb garden
2.open bag
3.press N

What is the expected output?

The expected output is that the herbs are moved into the herb category I have made, and so they do, however, the fireweed has the texture of hexweave cloth.

I have to close and open bag to restore the texture.

This doesn't happen all the time, but textures (on a random item) going wrong has happened a lot the last week.

What do you see instead?
1.8.0-beta 10

What version of the addon are you using?

Do you have an error log of what happened? (Please enable the display of Lua errors or install an error-reporting addon to be sure whether an error happens or not.)

Please provide any additional information below.

Error caused by hidden BankFrame when UpdateContainerFrameAnchors() is called

There is an issue with AdiBags when UpdateContainerFrameAnchors() is called by any other addon, because Adibags moves the BankFrame to a hidden frame.

The underlying reason is Blizzard's UpdateContainerFrameAnchors() function in FrameXML/ContainerFrame.lua:820 (as of 6.0.3), where Bankframe:GetRight() is called, but the result is not checked against nil. The subsequent arithmetic operation causes the following error, when the Bank is opened every 5-10 seconds:

Interface\\FrameXML\\ContainerFrame.lua:820: attempt to perform arithmetic on a nil value
Backtrace:
Interface\\FrameXML\\ContainerFrame.lua:820: in function <Interface\\FrameXML\\ContainerFrame.lua:814>
[C]: ?
[C]: in function `UpdateContainerFrameAnchors'
Interface\\AddOns\\Titan\\TitanMovable.lua:351: in function `TitanMovableFrame_MoveFrames'
Interface\\AddOns\\Titan\\TitanMovable.lua:527: in function `TitanPanel_AdjustFrames'
Interface\\AddOns\\Titan\\TitanMovable.lua:542: in function `func'
...ce\\AddOns\\Skillet\\Libs\\AceTimer-3.0\\AceTimer-3.0-17.lua:55: in function <...ce\\AddOns\\Skillet\\Libs\\AceTimer-3.0\\AceTimer-3.0.lua:48>
Locals:
= <function> defined @Interface\\FrameXML\\ContainerFrame.lua:814
= <function> defined @Interface\\AddOns\\TradeSkillMaster\\Libs\\AceHook-3.0\\AceHook-3.0.lua:100

Here is a quick fix for this issue, which is inserted in Bags.lua line 35:

--<dirty fix
-- for a bug in Blizzard's function UpdateContainerFrameAnchors() in
-- FrameXML/ContainerFrame.lua:820 (as of 6.0.3), where Bankframe:GetRight()
-- is called, but the result is not checked against nil
addon.BankFrameGetRightOrig = _G.BankFrame.GetRight
function addon.BankFrameGetRight(self)
    local p = self:GetParent()
    if p and p:IsVisible() then 
        return addon.BankFrameGetRightOrig(self)
    else 
        return 0
    end
end
_G.BankFrame.GetRight = addon.BankFrameGetRight
--dirty fix>

Req: Cloak Filter

Would it be possible to create a filter that separates Back/Cloak pieces from the "Cloth" section, since they are universal?

As a plate-wearer, it's confusing to have cloaks and other cloth in the same section.

Also, Would it be possible to create one that separates Trinkets into a sub-section of "Jewelry"?
I want to divide sections by armor type ("four basic sections"), but have subsections for Ring, Neck, Trinket. As well as Cloak, Shield.

I also posted this request on the project site for "AdiBags_Bound".
Looking at the code in that addon; I think it's doable by making some simple changes to the code around the lines of:
for i = 1,6 do if self.db.profile.enableBoE and t == ITEM_BIND_ON_EQUIP then

Thank you.

Adding Garrison Hearthstone to "default" Junk exclude list

On the Junk LUA you might consider updating the excludes list from listing just the hearthstone to add in the Garrison Hearthstone

OLD (starts on line 52):
exclude = {
[6948] = true,
},

NEW:
exclude = {
[6948] = true,
[110560] = true,
},

Maximum bag height

Hi i cant change the bag height at all i have removed all files disabled all addons except adibags and even downgraded to before 1.8. but nothing works with trying to change bag height.. i just want my bag to scale vertically not horizontally. Thanks

[Request] Add new Junk "Coin Icon" to junk items

I know that the default call to show the new junk coin icon is:

if (quality == LE_ITEM_QUALITY_POOR and not noValue and MerchantFrame:IsShown()) then
itemButton.JunkIcon:Show();
end

Which looks like this
image

Any chance you could add this to items that are marked as "Junk" in AdiBag? I've gotten so use to looking for them I'm finding myself really missing it.

Changing layout between vertical/horizontal

I want my bag layout to be narrow and tall (as shown in your screenshot on Curse.com) instead of wide and short. I can't seem to find an option to change the amount of columns/rows.

Lua Error

Date: 2015-03-15 10:36:06
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\AdiBags\core\Filters.lua line 126:
Usage: NewModule(name, [prototype, [lib, lib, lib, ...]): 'name' - Module 'Bound' already exists.
Debug:

...ce\AddOns\AdiBags\libs\AceAddon-3.0\AceAddon-3.0.lua:270: NewModule()
AdiBags\core\Filters.lua:126: RegisterFilter()
AdiBags_Bound\AdiBags_Bound.lua:52: in main chunk
Locals:
(*temporary) = "Usage: NewModule(name, [prototype, [lib, lib, lib, ...]): 'name' - Module 'Bound' already exists."

AddOns:
Swatter, v5.21c.5521 (SanctimoniousSwamprat)
AdiBags, vv1.8.4
AdiBagsBoEBoA, vv1.3
AdiBagsBound, vv1.1
LibSharedMedia30, v3.0-91
LibStub, v
BlizRuntimeLib_deDE v6.1.0.60100
(ck=c2)

Unable to set bags to "ignore" for purposes of deposit.

I've grown sick of having to drag enchanting vellum out of my reagent bag .... or buy another stack when I forget. I've been looking for the option to set a specific bag to "ignore" for cleanup and deposit, but I can't find the option.

Could you please add one, or let me know where it is? I'm sorry I had to raise an issue on github, but there is no other way to provide feedback or ask questions as the thread on wowace hasn't been monitored in 2 years and you've turned off comments in Curse.

Stacking Problem (curse #224)

Can you reproduce this problem? What steps will reproduce it?

  1. Unstackable items in my bank,won't stack, even when all the stack options are selected included merge unstackable.

What is the expected output?
All items that are the same should stack

What do you see instead?
Multiple stacks, mostly 1 per stack but sometimes 2.

What version of the addon are you using?
1.7.12

Do you have an error log of what happened? (Please enable the display of Lua errors or install an error-reporting addon to be sure whether an error happens or not.)
No error log.

Please provide any additional information below.
Previously my unstackable items used to stack correctly, but now they don't, primarily this seems to be happening with my Timeless Isles tokens in my bank, but as these are the only unstackable items in my bank that I have more then 1 of, this could just be coincidence. The problem started with 1.7.11 and was not fixed with 1.7.12.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.