Giter VIP home page Giter VIP logo

commerce-frontend-core's Introduction

Adobe Commerce Developer Documentation

Welcome! This site contains the latest Adobe Commerce and Magento Open Source developer documentation for ongoing releases of both products. For additional information, see our Contribution Guide.

Contributors

Our goal is to provide the Adobe Commerce and Magento Open Source communities with comprehensive and quality technical documentation. We believe that to accomplish that goal we need experts from the community to share their knowledge with us and each other. We are thankful to all of our contributors for improving the documentation.

Commerce contributors

Local development

This is a Gatsby project that uses the Adobe I/O Theme.

To build the site locally:

  1. Clone this repo.

  2. Install project dependencies.

    yarn install
  3. Launch the project in development mode.

    yarn dev

Resources

See the following resources to learn more about using the theme:

If you have questions, open an issue and ask us. We look forward to hearing from you!

commerce-frontend-core's People

Contributors

abukatar avatar alzota avatar bdenham avatar c0casio45 avatar danieluniform avatar dependabot[bot] avatar dfelton avatar dmitrymatio avatar dobooth avatar dshevtsov avatar ejaz-alam avatar ferrmolina avatar footshop-andy avatar hguthrie avatar jeff-matthews avatar jhadobe avatar keharper avatar magedevjosh avatar malkmaneth avatar malunem avatar meker12 avatar pykettk avatar sedonik avatar shivek-webkul avatar stuartaware avatar thiaramus avatar timkim avatar tsuimath avatar tuvandev avatar wowpixels avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

commerce-frontend-core's Issues

Not working as explained in the Doc.

Is there an existing issue for this?

  • I have searched the existing issues

Which topic?

https://developer.adobe.com/commerce/frontend-core/ui-components/components/on-off-column/

What's wrong with the content?

Not able to toggle individual records. when enabling any one toggle all toggles are enabled and the same with disable. see below my code and result.

Please let me know what mistake I am doing. Thanks

ezgif-4-f319f2a884

image

What changes do you propose?

Please attach any example code with the full listing code in the official Doc (https://developer.adobe.com/commerce/frontend-core/ui-components/components/on-off-column/).

Anything else that can help to cover this?

Please update the DOC

frontend-core/javascript/custom does not include the standard function format

Hey!

This new page: https://developer.adobe.com/commerce/frontend-core/javascript/custom/ shows many examples of how requirejs is used in magento, with jquery ui and widgets but it does not show the most simple usage format, which is returning a function and I think this should be like an entry point.
The format is only shown in https://developer.adobe.com/commerce/frontend-core/javascript/practice/ but I think an overview would be good and it should come first. WDYM?

Incorrect description: the second option is to copy the file from the same place where I should then paste it.

Is there an existing issue for this?

  • I have searched the existing issues

Which topic?

https://developer.adobe.com/commerce/frontend-core/guide/responsive-design/breakpoints/

What's wrong with the content?

The topic says that you need to copy the file (_responsive.less),
but judging by what is written there,
the second option is to copy the file from the same place where I should then paste it.

Copy the _responsive.less file to your <your_theme_dir>/web/css/source/lib/ directory from one of the following locations: ... <your_theme_dir>/web/css/source/lib/_responsive.less: the library file.

What changes do you propose?

It seems that the second option should sound like

<your_magento_root_dir>/lib/web/css/source/lib/_responsive.less: the library file.`

or something like it

Anything else that can help to cover this?

No response

Wrong order of example images?

While reading the docs about translations, I came across the Theme translation dictionary example page. I was a bit confused, because the example images did not seem to match the context of the text. It seems to me that the images should be put the other way round.

Currently the docs show these two images:

magento docs translate current state image1

magento docs translate current state image2

Shouldn't these images be shown the other way round?

Issue in /src/pages/guide/translations/practice.md

_extend or _extends?

Issue in /src/pages/guide/css/quickstart/customize-styles.md

In the Docs, it is written that the proper way to extend the style is to create an _extend.less file in the theme. However, when looking at Magento implementation, there is _extends.less file (with 's'). Is this an error in the Docs? Or it works using both file names?
Also, if it does, please mention that since it is confusing.

Css issue

Is there an existing issue for this?

  • I have searched the existing issues

Expected behavior

Text is overriding right container
image

Actual behavior

flexbox need to be correctly assigned.

Steps to reproduce

flexbox need to be correctly assigned.

Environment

  • Browser: Chrome
  • OS: Ubuntu 20

Sample code

No response

Logs

No response

Page builder custom type creation

Is there an existing issue for this?

  • I have searched the existing issues

Which topic?

https://developer.adobe.com/commerce/frontend-core/page-builder/architecture/configurations/

What's wrong with the content?

The documentation is giving headlines on how to configure the content type component.

<elements>
    <element name="main">
        <style name="display" source="display" converter="Magento_PageBuilder/js/content-type/button-item/converter/style/display" preview_converter="Magento_PageBuilder/js/converter/style/preview/display"/>
        <attribute name="name" source="data-content-type"/>
        <attribute name="appearance" source="data-appearance"/>
        <css name="css_classes"/>
    </element>
    <element name="link">
        <style name="text_align" source="text_align"/>
        <style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
        <style name="border_color" source="border_color"/>
        <style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
        <style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
        <style name="margins" storage_key="margins_and_padding" reader="Magento_PageBuilder/js/property/margins" converter="Magento_PageBuilder/js/converter/style/margins"/>
        <style name="padding" storage_key="margins_and_padding" reader="Magento_PageBuilder/js/property/paddings" converter="Magento_PageBuilder/js/converter/style/paddings"/>
        <attribute name="button_link" reader="Magento_PageBuilder/js/property/link" persistence_mode="read"/>
        <attribute name="virtual_link_href" storage_key="button_link" source="href" converter="Magento_PageBuilder/js/converter/attribute/link-href" persistence_mode="write"/>
        <attribute name="virtual_link_target" storage_key="button_link" source="target" converter="Magento_PageBuilder/js/converter/attribute/link-target" persistence_mode="write"/>
        <attribute name="virtual_link_type" storage_key="button_link" source="data-link-type" converter="Magento_PageBuilder/js/converter/attribute/link-type" persistence_mode="write"/>
        <css name="button_type"/>
    </element>
    <element name="empty_link">
        <style name="text_align" source="text_align"/>
        <style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
        <style name="border_color" source="border_color"/>
        <style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
        <style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
        <style name="margins" storage_key="margins_and_padding" reader="Magento_PageBuilder/js/property/margins" converter="Magento_PageBuilder/js/converter/style/margins"/>
        <style name="padding" storage_key="margins_and_padding" reader="Magento_PageBuilder/js/property/paddings" converter="Magento_PageBuilder/js/converter/style/paddings"/>
        <css name="button_type"/>
    </element>
    <element name="link_text">
        <html name="button_text" converter="Magento_PageBuilder/js/converter/html/tag-escaper"/>
    </element>
</elements>

What changes do you propose?

I would suggest to add the matching ui component form configuration so as the master and preview html matching the documentation example, because in the current state the example remains incomplete.

Overall, considering the whole process of creating a new content type :

The documentation is pretty complete to create simple text elements as describe in the whole section : https://developer.adobe.com/commerce/frontend-core/page-builder/content-types/create/

But overall it lacks of clarity when it come to extend more complex component like how to render a simple link or image.

Anything else that can help to cover this?

No response

incorrect link in left menu

Issue in /src/pages/ui-components/components/dynamic-rows.md
Hello, in left menu "DynamicRows" point menu with incorrect link

Typo mistake

Issue in /src/pages/guide/themes/index.md

There should be "admin" which is currently "Sdmin", see below full paragraph:

A theme is a component of application which provides a consistent look and feel (visual design) for entire application area (for example, storefront or Sdmin) using a combination of custom templates, layouts, styles or images.

Grunt LESS documentation needs clarification

Issue in /src/pages/guide/css/debug.md

The original issue was reported in magento/devdocs#9385

What's wrong with the content?

When following these instructions the user will always get the error “Error: Cannot find module ….” because the tutorial suggests to edit themes.js directly. The "important note" there just says "check the path in your grunt-config.json file and correct as necessary."

What changes do you propose?

Update to either recommend copying themes.js into local-themes.js (which is the file referenced by default in grunt-config.json) instead of editing themes.js directly or update grunt-config.json to reference themes.js if it is preferred to edit this file instead.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.