adpe / moodle-local_rocketchat Goto Github PK

As @semteacher raised in !11 there is a problem to get the Rocket.Chat user by Moodle's username.

Once a $userid is provided, two times a $user object.

Lots of things run on the hour - moodle has a special value "R" that allows a random number to be used on install rather than setting a specific value - see: https://docs.moodle.org/dev/Task_API#Cron_syntax_examples for more info.

not a requirement - just a suggestion, feel free to close as won't fix.

The courseid parameter in set_rocketchat_event_based_sync_parameters, set_rocketchat_event_based_sync_parameters, manually_trigger_sync_parameters
and
roleid in set_rocketchat_role_sync_parameters - all in externallib.php - could be set to PARAM_INT instead of PARAM_TEXT.

More information in discussion under https://tracker.moodle.org/browse/CONTRIB-8445

Moodle uses sentence case - please check your lang strings as some use camel case.

for example strings like:
$string['mystring'] = "My String";
should be:
$string['mystring'] = "My string";

Note: this is not a blocker for approval in the plugins db.

You have Moodle GPL headers in lots of places in your code and then state the licencse is MIT in phpdocs...

Please note that all moodle plugin files must be GPL as per:
https://docs.moodle.org/dev/Plugin_contribution_checklist#Licensing

You can include 3rd party libaries (not based on Moodle code) under a different license within your plugin as mentioned in that doc, but the main Moodle plugin files need to be licesnsed under GPL.

note this is a blocker for approval in the plugins db.

Please refer to https://docs.moodle.org/dev/Coding_style#Rules_for_level2

It is not a blocker but it would be nice to eventually refactor the code and move it to the appropriate namespace.

At the moment if there's a problem with the user or channel sync, the observers events for the based sync are still working. This should be automatically deactivated if the lastsync fails. Furthermore, the checkbox should only be reavailable if the lastsync has no errors.

The install.xml is no longer valid and was either created for an old version of Moodle or has been handwritten.

This needs to be fixed using the Moodle xmldb editor (under admin > development > XMLDB.)

Please hit the "load" link for your plugin install.xml file in the moodle xmldb editor, and then make Moodle think there is an update to the file (easiest way to do this is to change the description of a table - add a full stop or something similar.) Then get XMLDB to "Save" the updated file which will remove all the old invalid xml from your file.

If the group will be deleted in the Moodle course the channel remains on Rocket.Chat and the users will not be unsubscribed.

Please implement this functionality and a checkbox, that the user must check to delete the remote channels. He must be aware that data will be loss.

as your plugin exports private user information to an external service you need to include this information in the privacy class - more details here:

https://docs.moodle.org/dev/Privacy_API#Indicating_that_you_export_data_to_an_external_location

Please note - this is a blocker for approval in the plugins db. - thanks!