adventistchurch / alps-gutenberg-blocks Goto Github PK

When running npm run i18n:update-pot on the most recent version of the ALPS Gutenberg Blocks module, the following error shows in the terminal:

./src/blocks/media-block/components/edit.js:231: warning: RegExp literal terminated too early
./src/blocks/media-block/components/save.js:68: warning: unterminated string
./src/blocks/cta/block.js:269: warning: unterminated string
./src/blocks/gallery/block.js:81: warning: unterminated string
./src/blocks/gallery/block.js:101: warning: RegExp literal terminated too early
./src/blocks/image-2up/block.js:81: warning: RegExp literal terminated too early
./src/blocks/image-breakout/block.js:79: warning: unterminated string

With the way the code is currently getting compiled, blocks.editor.build.css and blocks.style.build.css are duplicated 15-16 times for each files.

We need to work on the compilation process to prevent this from happening.

Is there a possibility, to use this Block on the Startpage without the Sidebar. (So that it uses without the Sidebar 5 instead of 4 columns?

See on the attachment below. One module on startpage uses 5-grid, one 4-grid.

Here is space to keep the Gutenberg plugin. Please work in integrating this into the dev workflow of it.

The Kernl uuid is: 5bedddc4b4555c4c52a591aa

Within Article, the Gutenberg-Download Block is not available <!-- wp:download /-->

We need to redesign the backend blocks to provide a consistency to all the blocks in the edit interface.

I have a new Russian .po file and need to generate the .json files. When I ran the command, npm run i18n:create-json, I get the following error:

❌ ReferenceError: chalk is not defined
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] i18n:create-json: `node devtools/runner.js i18n:create-json`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] i18n:create-json script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Version of ALPS for Wordpress
v3

Describe the bug
I've been working with someone to translate the theme into Korean. He let me know that there are still a few missing phrases in the i18n files.

In the Media Testimonies block, the "Read More" and "Watch Video", and "See All Stories" phrases are either missing or unable to be replaced.

Screenshots

Problem

After working with @kelscahill on the Media Testimonies Block, we found that there is an issue with not being able to paste when the isSelected: false property is set.

Solution:

We need to make sure that the following blocks can all have text pasted into them:

• ALPS Blockquote
• ALPS CTA
• ALPS Content Block
• ALPS Accordion
• ALPS Content Expand
• ALPS Content Show More

After review by @sergsadovyi, we found that the blocks will need to be refactored to improve maintainability and reliability in the future.

The blocks in question are:

• accordion
• blockquote
• content-block
• content-expand
• content-show-more
• highlighted-paragraph
• image-breakout
• image-2up
• gallery
• latest-posts
• media-testimonies
• media-testimony
• cta

With version 1.9.0, the front.js file is returning a 404. You can see, as example, on Adventist.org, there is a 404 for https://www.adventist.org/wp-content/plugins/alps-gutenberg-blocks/src/front.js.

Please find why this is missing or even linked, and resolve this error.

Build out the Media Testimonies section that can be found on https://www.adventist.org/ as a Gutenberg Block.

We found a Google API key that is supposedly for ALPS. @YauheniKapliarchuk or @designerbrent do you have any knowledge of what this is supposed to do for us? Can we remove it?

I tried to insert a video with Gutenberg-Video-Block. Tried to insert Youtube-URL. But nothing happens after insertion. I tried with the same browser and same url on standard wordpress install, and it worked. It seems to be an ALPS issue.

Interesting to know. On standard wordpress, there is an explicit Youtube-Block. Don't know, if this is the solution for ALPS, to add this block.

Between the 700px and 900px widths, the images push the wrong direction, causing odd margins.

ALPS Quote block has bags and doesn't meet our UX requirements; we need to redesign it.

New design (developer will get access to Figma):

The way the block looks in the block editor should remain the same.

On my test machine, when I go to a page and edit it... momentarily I see the following error message:

Also, when I go to change the parent here I see the same error in a response header field (numbered arrows are steps to reproduce it):

Note that both calls listed that go to "/index.php?rest_route=/wp/v2/pages*" have this error.

Now on the https://www.adventist.org site, the call to /wp-json/wp/v2/pages* actually becomes a 500 error additionally:

(it also has this error message present in a response header, though it's not shown in this screenshot)

I have looked at the php debug and wp debug settings and so far have been unable to get any further error message from the 500 error...

Problem

Some ALPS blocks support a limited styled text (ALPS Highlighted Paragraph) but many that need it do not. This results in some extra work and inconsistencies.

Solution

Enable limited styling of text in the following blocks:

• ALPS Accordion
• ALPS CTA description field
• ALPS Content Block description field
• ALPS Content Expand description field
• ALPS Content Show More description field
• ALPS Content Show More body field

Problem

While editing, it is hard to see where one field begins and one ends. Additionally, it is impossible to style the text entered in the body of the block.

Solution Story

• User should see a clear view of the fields of a block.
• User should be able to paste text into any field on the block. (Also mentioned in #25)
• User should be able to style the text like you can with ALPS Highlighted Paragraph (Also mentioned in #26)

@daniel-eesti commented on Mon Feb 20 2023

ALPS widgets like "ALPS - Text with Link" and "ALPS - Author Box" (and maybe others) could not be added to more than one area of the page (top, bottom, or sidebar). For instance, if we add the "ALPS - Text with Link" widget to the Page Top or Page bottom, it disappears from Page Sidebar if it was added there previously.

Video Description: https://www.dropbox.com/s/ddhgwnaqrka5ein/ALPS%20widgets%20could%20not%20be%20added%20to%20more%20than%20one%20area%20of%20the%20page.mp4?dl=0

@hans-olson commented on Wed Feb 22 2023

@daniel-eesti

ALPSv3 does not take advantage of all standard widget areas. I think what you are trying to do would be an enhancement.

@designerbrent commented on Wed Feb 22 2023

This does appear to be a big. In the past, that functionality was working.

@hans-olson commented on Wed Feb 22 2023

We need to get a list of widgets that COM wants to use so we can enhance those widgets. Once we get the list, we can prioritize the enhancement.

This does appear to be a bug. In the past, that functionality was working.

Functionality beyond the page and post sidebars has not been tested by me. It is hard to say when this happened.

@hans-olson commented on Wed Feb 22 2023

I suggest we need to get a list of widgets that COM wants to use so we can make sure the widgets. Once we get the list, we can prioritize the fixes as an enhancement.

We need to enable HTML in the rendering of the ALPS Media Block. When you include html in the description field, it works in the editor view, but not on the front end.

Hi there, I first noticed this issue a couple of months back, and verified that it's still a problem. Is anyone still monitoring this repo?

Using ALPS Wordpress Theme v.3.0.32, many Wordpress-Blocks are not available. I don't know, why they are blocked with the ALPS-Theme, but however, in this issue, i report, that in my Theme v. 3.0.32, there is no Button-Block.

I am using latest alps-Gutenberg-blocks 1.3.5

Post's featured image and image block(?) causes a Cumulative Layout Shift of more than 0.1 on these pages:

https://www.adventist.org/nature-of-humanity/four-lessons-from-the-potters-house/ - 0.21
https://www.adventist.org/gift-of-prophecy/the-gift-of-prophecy/ - 0.19
https://www.adventist.org/world-church/east-central-africa/ - 0.16

In ALPS CTA block doesn't work upload button for pictures.

It opens Media Library but it doesn't add the picture after it was selected.

I worked with ALPS-Gutenberg-Block v.1.0.0.
Because there were missing a lot of Blocks, i investigated, and saw, that the alps-gutenberg-block plugin have not been updated with the themes update process.
I just want to report this issue, I don't know, if this is a singular case. I will observer this, if i get an update notification of future plugin update releases.