I've just added this Github Action to a Rails project and I saw that the reports aren't being "published" after running. I can see in the logs that there were issues, but nothing is available then in the "checks" tab.

Is there any configuration I'm missing?

I tried with and without specific runners, same problem.

The LICENSE file in this repo is empty. Is that just an oversight, or is the intention that this code is proprietary?

Error: No more than 50 items are allowed; 53 were supplied.

POST /{repo}/check-runs

Hi,

What's happened to https://github.com/AdWerx/dockerfiles/tree/master/pronto-ruby ?

I'm trying to support running my action on gitlab and it looks like moving from Checks API to pronto is a good way to do that. Your work looks like it'd be really useful to maintain the Checks API support, but I suspect some of the important bits are inside that base image!

Hey there!

I'm trying to add a reek step to pronto action but it gives me:

/usr/local/lib/ruby/site_ruby/2.5.0/rubygems/specification.rb:2302:in `raise_if_conflicts': Unable to activate reek-5.5.0, because parser-2.7.0.1 conflicts with parser (>= 2.5.0.0, != 2.5.1.1, < 2.7) (Gem::ConflictError)

You can check that here: https://github.com/mbajur/pronto-ruby-bug/pull/2/checks?check_run_id=372623270

Here is the repro PR you're a contributor in if needed: mbajur/pronto-ruby-bug#2

Thanks!

Wow, love this, and would love to use it, unfortunately when trying to set it up on private repo with the suggested setup I was getting this error:

/usr/local/lib/ruby/site_ruby/2.5.0/rubygems/core_ext/kernel_require.rb:54:in `require': cannot load such file -- rubocop-performance (LoadError)

Was wondering if you had some suggestions.

Thanks for the great workflow! I was looking to add erb_lint support, when I noticed that the pronto-erb_lint gem is already required in the Gemfile, and the changelog suggested that it was already supported a number of years ago.

I added erb_lint to the end of my config:

name: Pronto
on: [ pull_request ]
jobs:
  pronto:
    runs-on: ubuntu-latest
    permissions:
      pull-requests: write
      statuses: write
    steps:
      - uses: actions/checkout@v3
        with:
          fetch-depth: 0
      - uses: HeRoMo/[email protected]
        with:
          github_token: ${{ secrets.GNARBOT_TOKEN }}
          runner: rubocop brakeman rails_best_practices erb_lint
          formatters: text github_status github_pr_review

When I run it, I get this error:

Strictly speaking, erb_lint isn't in the list of supported runners. However, it looks like it should work according to the Dockerfile. Is there any particular reason erb_lint isn't supported?

Hey there!

I'm trying to add one vulnerability to ignored list using .pronto-bundler_audit.yml config file recommended by pronto-bundler_audit authors, it's contents looks as follows:

Advisories:
  Ignore:
    - CVE-2015-9284

While running pronto locally using pronto run --runner bundler_audit ignores this vulnerability perfectly fine, github action seems to not be loading this file and raises a check fail for given vulnerability.

Any idea what's going on in here? If you want to reproduce that, just run this action on ruby repo with gem 'omniauth', '1.9.0' entry in Gemfile and the config file pasted above.

Thanks!

Hey!

I am trying to use this action and it all works great when i am the one who opens/pushes the changes. However, once dependabot is opening a PR, this action is always failing with:

Faraday::Error::ClientError.inherited called from /usr/local/bundle/gems/octokit-4.14.0/lib/octokit/middleware/follow_redirects.rb:14.
/runner/src/github_action_check_run_formatter.rb:[10](https://github.com/xxx/yyy/actions/runs/6343338290/job/17230992679?pr=506#step:8:11): warning: already initialized constant Pronto::Formatter::FORMATTERS
/usr/local/bundle/gems/pronto-0.10.0/lib/pronto/formatter/formatter.rb:13: warning: previous definition of FORMATTERS was here
/usr/local/bundle/gems/octokit-4.14.0/lib/octokit/response/raise_error.rb:16:in `on_complete': POST https://api.github.com/repos/xxx/yyy/check-runs: 403 - Resource not accessible by integration // See: https://docs.github.com/rest/checks/runs#create-a-check-run (Octokit::Forbidden)

I tried every single solution i've found on the internet to try to fix it but nothing worked. Including https://docs.github.com/en/code-security/code-scanning/troubleshooting-code-scanning/resource-not-accessible-by-integration

I have a following action config:

name: Pronto

on:
  - pull_request

jobs:
  run:
    runs-on: ubuntu-latest
    permissions:
      checks: write
      contents: read
    steps:
    - uses: actions/checkout@v1
    - run: echo `git merge-base --fork-point dev`
    - run: echo `git merge-base --fork-point origin/dev`
    - run: echo `git merge-base --fork-point origin/master`
    - id: get_base
      run: echo ::set-output name=sha::`git merge-base HEAD origin/dev || git merge-base HEAD origin/master`

    - name: Run Pronto
      uses: adwerx/[email protected]
      with:
        target: ${{ steps.get_base.outputs.sha }}
        runners: >-
          rails_schema rails_data_schema
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

and it raises a following error:

/usr/local/bundle/gems/pronto-0.10.0/lib/pronto/git/repository.rb:87:in `merge_base': failed to parse revision specifier - Invalid pattern '' (Rugged::InvalidError)
	from /usr/local/bundle/gems/pronto-0.10.0/lib/pronto/git/repository.rb:87:in `merge_base'
	from /usr/local/bundle/gems/pronto-0.10.0/lib/pronto/git/repository.rb:17:in `diff'
	from /usr/local/bundle/gems/pronto-0.10.0/lib/pronto.rb:62:in `run'
	from /usr/local/bundle/gems/pronto-0.10.0/lib/pronto/cli.rb:66:in `block in run'
	from /usr/local/bundle/gems/pronto-0.10.0/lib/pronto/cli.rb:64:in `chdir'
	from /usr/local/bundle/gems/pronto-0.10.0/lib/pronto/cli.rb:64:in `run'
	from /usr/local/bundle/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
	from /usr/local/bundle/gems/thor-0.20.3/lib/thor/invocation.rb:[12](https://github.com/Cuseum/spotzer-cms/actions/runs/6392060242/job/17348571308?pr=2948#step:9:13)6:in `invoke_command'
	from /usr/local/bundle/gems/thor-0.[20](https://github.com/Cuseum/spotzer-cms/actions/runs/6392060242/job/17348571308?pr=2948#step:9:21).3/lib/thor.rb:387:in `dispatch'
	from /usr/local/bundle/gems/thor-0.20.3/lib/thor/base.rb:466:in `start'
	from /runner/pronto:41:in `block in <main>'
	from /runner/pronto:40:in `chdir'
	from /runner/pronto:40:in `<main>'

Any idea what can be done about it?

Hey @jbielick!

So after giving a deeper look at current eslint it appears you were right about supporting different plugins and configurations. It works OK for simple installations, but for more advanced installations it is missing support for some advanced configurations and installations.

At this moment I can think of 3 options right now of resolving this problem:

1. Cherry-pick post popular configurations ( standart/google/airbnb ) and plugins ( TOP30 by number of starts ) and

2. Allow people to have a list of their configurations/plugins to be listed in their package.json and run npm install against their package.json before running pronto lint. (See https://github.com/hallee/eslint-action/blob/master/lib/entrypoint.sh for reference )

3. Get rid of eslint pronto runner and suggest people to use separate Github Action for that.

Personally myself would love to stick with #1 or #2, since it really like current solution and would like to keep everything under the same roof.

What are you thoughts over here?