adyen / adyen-cse-android Goto Github PK

In this commit f0a19c4, CardBuilder was introduced and all the setX methods on Card were deprecated without explanation. CardBuilder.build() requires the card number, cardholder name, and some other fields to be set or else an error is thrown. This is fine for users who are adding a new credit card, but the builder doesn't allow for tokenizing information to verify a CVV.

Tokenizing a card's CVV is explicitly called out as a feature in the Javascript SDK (https://github.com/Adyen/adyen-cse-web#cvc-encryption) and there are no technical limitations on doing so in the iOS CSE SDK. It's still possible to do this in the Android SDK, but doing so requires using the deprecated methods.

For now, I'll use these deprecated methods to verify a CVV, but I think it would be good to explicitly support this common action. Any advice or context around this decision would be greatly appreciated.

Following the readme instructions was not enough to have adyen-cse included to my project, I had to add

dependencies {
  compile(name:'adyencse-1.0.0', ext:'aar') 
}

...to get the aar compiled.

Furthermore, I'd suggest looking at hosting the .aar at e.g. jCenter or Maven Central, so you'd have to only add single dependencies line like:

dependencies {
    compile 'com.adyen.adyencse:adyencse:1.0.0'
}

...instead of the custom download task etc.

Hey! Any plans to migrate to MavenCentral or JitPack as JCenter will be sunset on May 1st, 2021?

Useful hints on the migration process can be found here.

Thanks!

hello guys,
as android 9.0 migration doc says, it remove direct access to Build.serial, you'll get "unknown" when you use reflection to get the value of "SERIAL" field like Build.class.getField("SERIAL").get(null)

it complains when use tools test for non-SDK interfaces

would you like to change the way to identify the phone?

Hello guys,

I don't understand why this 'sdk' is not in pure java.
Can you update this ARR to a JAR ?
As your SDK is open source you can also push this library to a Maven.

Regards

Looks like this library uses nothing but java and javaxpackages. There are no import from the Android SDK whatsoever. So why is the min SDK version set to 19?

I've copied the classes and successfully encoded a card on Android 15. Is it safe to use on older SDKs?