Giter VIP home page Giter VIP logo

Comments (12)

ImDevinC avatar ImDevinC commented on September 6, 2024

All of them for every set?

from mtg-familiar.

sethladd avatar sethladd commented on September 6, 2024

At least for a set. :)

from mtg-familiar.

ImDevinC avatar ImDevinC commented on September 6, 2024

Latest set? Ask for choice? That could still be a lot of space, but it's worth looking at I guess

from mtg-familiar.

sethladd avatar sethladd commented on September 6, 2024

Here's my use case: I was standing in line to board a plane and i wanted to browse magic cards. Unfortunately, none of the pictures worked when I had to go into airplane mode. It would have been great to ask for the pictures to be cached/downloaded for a few sets.

We might also want to have a least-recently-used cache of images, if only to avoid all the network traffic and speed up the app.

from mtg-familiar.

AEFeinstein avatar AEFeinstein commented on September 6, 2024

A cache is doable. The app already handles card prices with a 24 hour expiring cache. I just don't want users to be chewing up space on their device without realizing it. Pre-caching on a per-set basis is also simple enough. Nothing a multi-choice alert dialog can't handle.

from mtg-familiar.

sethladd avatar sethladd commented on September 6, 2024

I think it's reasonable to say "cache XX of data" as a user pref, to transparently reduce network traffic and speed up the app. Default to 100 MB? How big is each image?

As a user, I want to explicitly say "store all the images for this set", which is separate than the transparent LRU cache. I don't want images to disappear if I've explicitly chosen to get all the images for, say, M15.

from mtg-familiar.

ImDevinC avatar ImDevinC commented on September 6, 2024

Any idea on where to choose what set to download entirely? It doesn't seem to fit anywhere in the flow of what's there so far

from mtg-familiar.

AEFeinstein avatar AEFeinstein commented on September 6, 2024

Somewhere in the preferences I think. Maybe under search and results?

from mtg-familiar.

ImDevinC avatar ImDevinC commented on September 6, 2024

I think that's good for caching, but should we put full set download in there too? I guess that might be the most sensible place based on the other fragments

from mtg-familiar.

AEFeinstein avatar AEFeinstein commented on September 6, 2024

I added caching in d128008. It still needs a slider to control the cache size, and a way to precache images.

from mtg-familiar.

AEFeinstein avatar AEFeinstein commented on September 6, 2024

Added the seek bar preference in e8fefa8

from mtg-familiar.

sethladd avatar sethladd commented on September 6, 2024

Thanks!

from mtg-familiar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.