aefeinstein / mtg-familiar Goto Github PK

Would also love for the app to pre download the card images.

Have a way in the settings to download and cache a sets-worth of cards. This may not work as the user intends if the LRU cache isn't large enough for the entire set.

Segmented Wurm from Beatdown Box Set displays wrong art.

The ability to create and store decklists would be an excellent addition.

I was thinking the card selection UI could be something similar to the wishlist, with the addition of main and sideboard parts of the list, and a deck slot selection.

The European Central Bank hosts some nice XML with current exchange rates. It would be nice to convert prices based on locale.

Reminder to check into ability to save the Images from the full card art.

Wondering if there was any particular reason that there is no long Click listener for the trade cards as there is for the wishlist before I go ahead and write one up and do a pull request.

This is a problem on at least the OnePlus One phone & Blur launcher.

The app uses the system language for strings, but some users have requested a setting which overrides the system default.

Steps to reproduce:

1. Use the Card Search fragment to search for a card
2. Open a card
3. Rotate the screen

This only seems to happen here. Doing this after adding a card to the Wishlist and then viewing the card does not have this same issue.

Capitalization changed in CNS, so the card isn't consolidated properly. Will be fixed when the new scraper is online.

Hey,

I don't know the best way to contact you, but this seems to be it. I came across this project and am very interested in helping out. Is there anything in specific you'd like to see done, but don't have the time or motivation for? I'd be happy to help.

Best way to contact me is either my email: [email protected] or responding to this issue.

Thanks!

-niothiel

Currently, search results can be filtered by converted mana cost, but it would be nice to also see results with "X" explicitly in their cost

Can u guys make the app available for kindle fire. I love the app but can't use on my kindle.

I have noticed that Conspiracy foil prices do not work in the Trading part of the app. Could you please fix this?

My FLGS prices cards mostly by rarity. It would be a great help to search by rarity as well as all the other great search options. Thanks

Adding an FTV:20 Jace the Mind Sculptor to the trade list defaults to $0.00. I wish. We should probably check if all non-foil prices are 0 and a foil price exists, and default to the foil price in that case.

Turns out MagicCardMarket has an API. We could use that to fetch more price data.

Searching for Kamahl, Pit Fighter with consolidation on and off only returns the HVM Kamahl. Separately, in the dev build, the button to switch sets for Kamahl isn't showing up.

Trying to add lands gives card not found on the following URL:

http://partner.tcgplayer.com/x3/phl.asmx/p?pk=MTGFAMILIA&s=Fate+Reforged&p=Island

The patch generator failed for Indulgent Tormentor, listing it/s P/T as 5/5 instead of 5/3. This is a patch problem, not a Familiar bug, but this was the best place to track the issue.

What steps will reproduce the problem?

1. Go into the rules fragment.
2. Go at least 3 pages deep by utilizing links.
3. Click the "exit rules" menu button

What is the expected output? What do you see instead?
I expect to return to the main rules page, with the big categories and the glossary. Instead, I go back exactly two pages.

Or it might not update properly... (at least comp. rules: the date used for comparison is that of the build for new installs).

This is not an issue, but a post-it.

When the user long-presses a card in the wishlist, it should pop a dialog to quickly remove all of those cards from the wishlist.

This bug comes from the fact that Gatherer correctly alphabetizes The Hive (http://gatherer.wizards.com/Pages/Card/Details.aspx?multiverseid=11530), but the collectors number has it alphabetized by "Hive" instead of "The". This shifts the collectors numbers, which are used for image lookups.

Each of the seven checkboxes will have four drawables: light unchecked, light checked, dark unchecked, and dark checked. You should check in a new /Art/checkboxes.svg to the Material branch and drawables with the following naming convention, where the "b" is replaced with the appropriate mana symbol (l for colorless, "foil" for foil):

• btn_check_off_light_b.png
• btn_check_off_light_b.png
• btn_check_on_dark_b.png
• btn_check_on_dark_b.png

Each unchecked checkbox will have a mana symbol centered in it, with a small margin between the symbol and the border (see the current checkboxes).

Each checked checkbox will use that mana symbol's dominant color as a fill for the check, instead of leaving it transparent.

The light themed checkboxes will use the color #009688 for the border and non-check fill and the dark themed checkboxes will use the color #80CBC4 for the border and non-check fill.

Use these SVG mana symbols and SVG material checkboxes as starters.

Right now the result list is always sorted alphabetically first and then by the set's date second. It would be nice to sort the results by other parameters, like CMC, power, color, etc

I'd like to be able to sort the Wish List by set.

My FLGS keeps singles in set binders, and it would be handy for finding cards to have them sorted in the list this way.

In the same vein as the banned & restricted display items in the rules fragment, we could show a list of sets legal for a given format. It would be nice to display the sets interleaved with the banned & restricted items.

A hierarchical view would make it more navigable. The first view would just have a list of formats, and tapping a format would show a new page with the banned & restricted cards, as well as a list of legal sets.

I'm receiving Zero results with a wide open search after selecting the "Commander" format. This could just be a corruption of my own format list, or an issue across the board. Is anyone else seeing no results for Commander searches?

This would be useful for looking up a card in a foreign language. It should be pretty simple to implement. Remember that Collector's Numbers are actually strings (181a, etc).

Add an option to the dice page to roll an N sided die

Even when the card has one printing, some users had used the button to read the full set name, instead of just the set code displayed on the page. The logic to hide it should be removed, and it should be moved lower in the menu XML so that it isn't displayed.

Un-cards are not returned when a user searches for Legacy cards, but oversize ones are. This should be fixed in the SQL query.

There are (as of now) four kinds of sets. Regular expansions (Zendikar, Worldwake, etc), multiplayer products (Archenemy, Planechase, etc), "special" sets (Duel Decks, FTV, etc), and Un- sets (Unglued, Unhinged).

It would be nice to classify each set, and be able to use it as a search filter. This would likely require a new database column, or some hack-y hardcoded list

Where exactly do you get your database from? I've only found the patches on sites.google.com, are you patching the old oracle file (https://www.wizards.com/dci/oracle/OracleAll_050523.txt)? It would be interesting to have an up-to-date database for other MtG-related programs (such as Mindless Automaton) and I didn't manage to find any so far (except severely out-of-date ones).

Side note: I've only recently came back into Magic after a pause of several years, and immediately found this cool app. Great work!

There's still something unexpected happening. If you change the settings to "always display art," save the image, change the set (i.e. M12 Llanowar Elves to Alpha Llanowar Elves), and save the new image, both files end up as the original image. This is not the case for when the image is displayed in a dialog, where it works as expected.

Color identity would be nifty to search by, but it would require either a new database column, or some trickery to query for mana symbols in rules text.

Can the rarity be added to the list of things are showable for a card? Modern cards show the rarity with the colour of the symbol, but all of my cards are ancient and don't indicate what their rarity is.

Prices do not load for Modern Event Deck 2014. One should check the URL that is being built to query TCGPlayer.com

Something in the wishlist dialog process isn't efficient, and it shows when basic lands are added and the user opens the dialog. Speed it up!

The B&R information is already in the app. Add a section to the bottom of the Rules which just displays the lists.

What steps will reproduce the problem?

1. Go into the Comp Rules
2. Search for " layers"
3. The results constantly find results, oddly enough, for "p layers".

• Affects: <=3.1.2 (>???)
• Steps to reproduce:
  • Go to Android settings, change language to Spanish
  • Kill app, relaunch.
  • In seach mode:
    • Fill any (and any number of) field (selecting an edition -"Expansión" button- is fine)
    • Tap on "Rareza", select "Infrecuente"
    • Tap on "¡Buscar!".
• Expected result: Search results matching the criteria
• Actual results: An Android toast pops that reads "No se encontraron resultados" (No results found).
• Workaround: when searching uncommons, change language in android settings, kill app, relaunch, then it will work as expected. Just so people facing this issue have an (utterly distressing and bothersome) alternative.
• Comments:
  • I've testes multiple combinations, and what all failures have in common is android language and "uncommon" filter.
  • If multiple rarities are selected, including "uncommon", this one is just ignored.

This is a pipe dream, but it would be lovely to somehow get translations for rules and the database itself, instead of having large, functional parts of the app in English only.

Right now the wish list is sorted by when the cards were added (if one can call that sorting). It would be nice to sort the results by other parameters, like name, CMC, power, color, etc

Have a dialog to export only the card names, for mass entry on certain sites.

Even with the option enabled to "Force the life counter screen to never go to sleep", after about 30 seconds without changing the life totals, the screen will dim. This has forced me to download a separate app for tracking life totals, as MTG Familiar can only seem to handle the most fast-moving games.

I don't like just being a complainer, so today I downloaded the source code to see if I could find the source of this bug. This is what I found in LifeCounterFragment.java

@Override
public void onUserInactive() {
    if (getFamiliarActivity().mPreferenceAdapter.getKeepScreenOn()) {
        WindowManager.LayoutParams layoutParams = getActivity().getWindow().getAttributes();
        layoutParams.screenBrightness = 0.01f;
        getActivity().getWindow().setAttributes(layoutParams);
    }
}

The 'if' condition seems to be backwards. If the user wants to keep the screen visible, then it should not go unusably dim if he doesn't continually poke at the screen.

Thanks for all your hard work making MTG Familiar such a great app!

Add Commander legality for cards, noting whether the card is banned in the deck or as a commander. Legalities are found here