Comments (4)
hi, @aiekick I understood what internally the script does and now fixed in a proper way.
(Indeed my previous fix didn't make sense. It only worked because it forced your code to reset the FileNameBuffer at a later stage).
Turns out that you use the following lines to reset the default filename:
// Reset default file name
ResetBuffer(FileNameBuffer);
AppendToBuffer(FileNameBuffer, MAX_FILE_DIALOG_NAME_BUFFER, dlg_defaultFileName);
The issue is that the lines above are only called at specific places, which never resets the default filename when vDefaultFileName
changes.
I fixed by adding the above lines just before the SetPath
from OpenDialog
functions.
However, because I understand you would still like to keep the previous file name or path changed by the user on the dialog file input, coding something like the following could work with proper adjustments:
void ImGuiFileDialog::OpenDialog(...){
...
if (dlg_defaultFileName.compare(vDefaultFileName) != 0){
// Whenever the caller has a different `vDefaultFileName`, reset the `FileNameBuffer`
ResetBuffer(FileNameBuffer);
AppendToBuffer(FileNameBuffer, MAX_FILE_DIALOG_NAME_BUFFER, dlg_defaultFileName);
}
...
SetPath(vPath);
}
Let me know if the explanation above makes sense.
Regards and thanks for this great library.
from imguifiledialog.
Hi,
yes it make sense.
fixed in 6cb0564
from imguifiledialog.
@aiekick sorry for the delay. Thanks a lot, this library was really useful.
from imguifiledialog.
interesting, thanks. i will check that tonight.
btw i dont understand your fix, because m_CurrentPath is replaced by vPath just after.
from imguifiledialog.
Related Issues (20)
- ImGuiWindowFlags_NoResize does not work for the file dialog. HOT 1
- not able to refresh the dialog OR dialog does not respond to my mouse HOT 2
- Case-insensitive filter group ignores last member HOT 5
- request:How to use this to create a file manager HOT 1
- add a filesystem interface HOT 1
- Replacestring gets stuck in infinite loop HOT 2
- Images referred in the README.md are missing HOT 1
- MSVC specific pragma directives HOT 10
- ImGuiFileDialogFlags_CaseInsensitiveExtention is broken?? HOT 3
- Show Symlinks HOT 7
- Please '#define IMGUI_DEFINE_MATH_OPERATORS' _BEFORE_ including imgui.h! HOT 2
- User providing absolute path to file dialog results in malformed path HOT 8
- How to configure OpenDialog for "saving as" ? HOT 1
- Android? HOT 1
- Improve Compile Times HOT 1
- Compile Errors and Warnings in v0.6.6 HOT 7
- Compilation warnings: missing override tag HOT 1
- Add a way for compute the size according to the file infos like ext, by ex for separate gltf for have the bin size
- Add way for display a custom tooltip of many fields for a particular file
- Q: How to select directory? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from imguifiledialog.